Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
e6720475
Commit
e6720475
authored
Jul 27, 2016
by
Jon Skeet
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove legacy_enum_values flag for GA.
parent
ba52f2b6
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
14 deletions
+2
-14
csharp_enum.cc
src/google/protobuf/compiler/csharp/csharp_enum.cc
+1
-3
csharp_generator.cc
src/google/protobuf/compiler/csharp/csharp_generator.cc
+0
-3
csharp_options.h
src/google/protobuf/compiler/csharp/csharp_options.h
+1
-8
No files found.
src/google/protobuf/compiler/csharp/csharp_enum.cc
View file @
e6720475
...
...
@@ -68,9 +68,7 @@ void EnumGenerator::Generate(io::Printer* printer) {
for
(
int
i
=
0
;
i
<
descriptor_
->
value_count
();
i
++
)
{
WriteEnumValueDocComment
(
printer
,
descriptor_
->
value
(
i
));
string
original_name
=
descriptor_
->
value
(
i
)
->
name
();
string
name
=
options
()
->
legacy_enum_values
?
descriptor_
->
value
(
i
)
->
name
()
:
GetEnumValueName
(
descriptor_
->
name
(),
descriptor_
->
value
(
i
)
->
name
());
string
name
=
GetEnumValueName
(
descriptor_
->
name
(),
descriptor_
->
value
(
i
)
->
name
());
// Make sure we don't get any duplicate names due to prefix removal.
while
(
!
used_names
.
insert
(
name
).
second
)
{
// It's possible we'll end up giving this warning multiple times, but that's better than not at all.
...
...
src/google/protobuf/compiler/csharp/csharp_generator.cc
View file @
e6720475
...
...
@@ -83,9 +83,6 @@ bool Generator::Generate(
cli_options
.
base_namespace_specified
=
true
;
}
else
if
(
options
[
i
].
first
==
"internal_access"
)
{
cli_options
.
internal_access
=
true
;
}
else
if
(
options
[
i
].
first
==
"legacy_enum_values"
)
{
// TODO: Remove this before final release
cli_options
.
legacy_enum_values
=
true
;
}
else
{
*
error
=
"Unknown generator option: "
+
options
[
i
].
first
;
return
false
;
...
...
src/google/protobuf/compiler/csharp/csharp_options.h
View file @
e6720475
...
...
@@ -45,8 +45,7 @@ struct Options {
file_extension
(
".cs"
),
base_namespace
(
""
),
base_namespace_specified
(
false
),
internal_access
(
false
),
legacy_enum_values
(
false
)
{
internal_access
(
false
)
{
}
// Extension of the generated file. Defaults to ".cs"
string
file_extension
;
...
...
@@ -69,12 +68,6 @@ struct Options {
// Whether the generated classes should have accessibility level of "internal".
// Defaults to false that generates "public" classes.
bool
internal_access
;
// By default, C# codegen now uses PascalCased enum values names, after
// removing the enum type name as a prefix (if it *is* a prefix of the value).
// Setting this option reverts to the previous behavior of just copying the
// value name specified in the .proto file, allowing gradual migration.
// This option will be removed before final release.
bool
legacy_enum_values
;
};
}
// namespace csharp
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment