fix ubsan warning

Signed-off-by: Asra Ali <asraa@google.com>

fix ubsan warning
Signed-off-by: Asra Ali <asraa@google.com>
de3e728c · Asra Ali · Adam Cozzette · 8b096862 · de3e728c
Commit de3e728c authored Jun 20, 2019 by Asra Ali Committed by Adam Cozzette Jul 03, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

strutil.cc src/google/protobuf/stubs/strutil.cc +4 -2

No files found.
--- a/src/google/protobuf/stubs/strutil.cc
+++ b/src/google/protobuf/stubs/strutil.cc
@@ -1065,10 +1065,12 @@ done:
 }

 char* FastInt32ToBufferLeft(int32 i, char* buffer) {
-  uint32 u = i;
+  uint32 u = 0;
  if (i < 0) {
    *buffer++ = '-';
-    u = -i;
+    u -= i;
+  } else {
+    u = i;
  }
  return FastUInt32ToBufferLeft(u, buffer);
 }