Commit da3ce671 authored by Jon Skeet's avatar Jon Skeet Committed by Jon Skeet

Deliberately call simple code to avoid Unity linker pruning

The SampleEnumMethod method was previously only called via
reflection, so the Unity linker thought it could be removed. Ditto
the parameterless constructor in ReflectionHelper.

This PR should avoid that issue, reducing the work needed by
customers to use Google.Protobuf from Unity.
parent a72da27f
......@@ -163,6 +163,8 @@ namespace Google.Protobuf.Reflection
{
try
{
PreventLinkerFailures();
// Try to do the conversion using reflection, so we can see whether it's supported.
MethodInfo method = typeof(ReflectionUtil).GetMethod(nameof(SampleEnumMethod));
// If this passes, we're in a reasonable runtime.
method.CreateDelegate(typeof(Func<int>));
......@@ -174,6 +176,23 @@ namespace Google.Protobuf.Reflection
}
}
/// <summary>
/// This method is effectively pointless, but only called once. It's present (and called)
/// to avoid the Unity linker from removing code that's only called via reflection.
/// </summary>
private static void PreventLinkerFailures()
{
// Exercise the method directly. This should avoid any pro-active linkers from stripping
// the method out.
SampleEnum x = SampleEnumMethod();
if (x != SampleEnum.X)
{
throw new InvalidOperationException("Failure in reflection utilities");
}
// Make sure the ReflectionHelper parameterless constructor isn't removed...
var helper = new ReflectionHelper<int, int>();
}
public enum SampleEnum
{
X
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment