Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
ca6187d5
Commit
ca6187d5
authored
Oct 18, 2017
by
Jisi Liu
Committed by
GitHub
Oct 18, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #3578 from pherl/filedeprecation
Add @Deprecated annotation support for proto file.
parents
3d6cc0e7
f9b81690
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
45 additions
and
2 deletions
+45
-2
Makefile.am
Makefile.am
+1
-0
generate-test-sources-build.xml
java/core/generate-test-sources-build.xml
+1
-0
deprecated_file.proto
.../src/test/proto/com/google/protobuf/deprecated_file.proto
+38
-0
java_file.cc
src/google/protobuf/compiler/java/java_file.cc
+5
-2
No files found.
Makefile.am
View file @
ca6187d5
...
...
@@ -332,6 +332,7 @@ java_EXTRA_DIST=
java/core/src/test/java/com/google/protobuf/WellKnownTypesTest.java
\
java/core/src/test/java/com/google/protobuf/WireFormatTest.java
\
java/core/src/test/proto/com/google/protobuf/any_test.proto
\
java/core/src/test/proto/com/google/protobuf/deprecated_file.proto
\
java/core/src/test/proto/com/google/protobuf/field_presence_test.proto
\
java/core/src/test/proto/com/google/protobuf/lazy_fields_lite.proto
\
java/core/src/test/proto/com/google/protobuf/lite_equals_and_hash.proto
\
...
...
java/core/generate-test-sources-build.xml
View file @
ca6187d5
...
...
@@ -19,6 +19,7 @@
<arg
value=
"${protobuf.source.dir}/google/protobuf/unittest_enormous_descriptor.proto"
/>
<arg
value=
"${protobuf.source.dir}/google/protobuf/unittest_no_generic_services.proto"
/>
<arg
value=
"${protobuf.source.dir}/google/protobuf/unittest_well_known_types.proto"
/>
<arg
value=
"${test.proto.dir}/com/google/protobuf/deprecated_file.proto"
/>
<arg
value=
"${test.proto.dir}/com/google/protobuf/lazy_fields_lite.proto"
/>
<arg
value=
"${test.proto.dir}/com/google/protobuf/lite_equals_and_hash.proto"
/>
<arg
value=
"${test.proto.dir}/com/google/protobuf/multiple_files_test.proto"
/>
...
...
java/core/src/test/proto/com/google/protobuf/deprecated_file.proto
0 → 100644
View file @
ca6187d5
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
// https://developers.google.com/protocol-buffers/
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
syntax
=
"proto3"
;
package
deprecated_file
;
option
deprecated
=
true
;
// TODO (liujisi): Add deprecation options on messages, enums fields as well and
// add tests to verify those annotations are actually generated.
src/google/protobuf/compiler/java/java_file.cc
View file @
ca6187d5
...
...
@@ -248,9 +248,12 @@ void FileGenerator::Generate(io::Printer* printer) {
PrintGeneratedAnnotation
(
printer
,
'$'
,
options_
.
annotate_code
?
classname_
+
".java.pb.meta"
:
""
);
printer
->
Print
(
"public final class $classname$ {
\n
"
"
$deprecation$
public final class $classname$ {
\n
"
" private $ctor$() {}
\n
"
,
"classname"
,
classname_
,
"ctor"
,
classname_
);
"deprecation"
,
file_
->
options
().
deprecated
()
?
"@java.lang.Deprecated "
:
""
,
"classname"
,
classname_
,
"ctor"
,
classname_
);
printer
->
Annotate
(
"classname"
,
file_
->
name
());
printer
->
Indent
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment