Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
c7680721
Commit
c7680721
authored
Nov 08, 2014
by
Veres Lajos
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
typo fixes -
https://github.com/vlajos/misspell_fixer
parent
baca1a8a
Hide whitespace changes
Inline
Side-by-side
Showing
22 changed files
with
50 additions
and
50 deletions
+50
-50
DynamicMessage.java
java/src/main/java/com/google/protobuf/DynamicMessage.java
+1
-1
RepeatedFieldBuilder.java
...c/main/java/com/google/protobuf/RepeatedFieldBuilder.java
+1
-1
SingleFieldBuilder.java
...src/main/java/com/google/protobuf/SingleFieldBuilder.java
+1
-1
TextFormat.java
java/src/main/java/com/google/protobuf/TextFormat.java
+4
-4
generator_test.py
python/google/protobuf/internal/generator_test.py
+1
-1
service_reflection_test.py
python/google/protobuf/internal/service_reflection_test.py
+1
-1
message.h
python/google/protobuf/pyext/message.h
+1
-1
repeated_composite_container.h
python/google/protobuf/pyext/repeated_composite_container.h
+1
-1
scoped_pyobject_ptr.h
python/google/protobuf/pyext/scoped_pyobject_ptr.h
+1
-1
mox.py
python/mox.py
+1
-1
command_line_interface.h
src/google/protobuf/compiler/command_line_interface.h
+1
-1
cpp_unittest.cc
src/google/protobuf/compiler/cpp/cpp_unittest.cc
+1
-1
java_file.cc
src/google/protobuf/compiler/java/java_file.cc
+1
-1
java_helpers.h
src/google/protobuf/compiler/java/java_helpers.h
+1
-1
descriptor.cc
src/google/protobuf/descriptor.cc
+1
-1
descriptor.h
src/google/protobuf/descriptor.h
+2
-2
tokenizer.h
src/google/protobuf/io/tokenizer.h
+1
-1
common.h
src/google/protobuf/stubs/common.h
+2
-2
template_util.h
src/google/protobuf/stubs/template_util.h
+1
-1
text_format.cc
src/google/protobuf/text_format.cc
+19
-19
text_format_unittest.cc
src/google/protobuf/text_format_unittest.cc
+6
-6
unittest_import.proto
src/google/protobuf/unittest_import.proto
+1
-1
No files found.
java/src/main/java/com/google/protobuf/DynamicMessage.java
View file @
c7680721
...
...
@@ -59,7 +59,7 @@ public final class DynamicMessage extends AbstractMessage {
* oneofCases stores the FieldDescriptor for each oneof to indicate
* which field is set. Caller should make sure the array is immutable.
*
* This contructor is package private and will be used in
* This con
s
tructor is package private and will be used in
* {@code DynamicMutableMessage} to convert a mutable message to an immutable
* message.
*/
...
...
java/src/main/java/com/google/protobuf/RepeatedFieldBuilder.java
View file @
c7680721
...
...
@@ -54,7 +54,7 @@ import java.util.List;
* that desires a Message instead of a Builder. In terms of the implementation,
* the {@code SingleFieldBuilder} and {@code RepeatedFieldBuilder}
* classes cache messages that were created so that messages only need to be
* created when some change occured in its builder or a builder for one of its
* created when some change occur
r
ed in its builder or a builder for one of its
* descendants.
*
* @param <MType> the type of message for the field
...
...
java/src/main/java/com/google/protobuf/SingleFieldBuilder.java
View file @
c7680721
...
...
@@ -47,7 +47,7 @@ package com.google.protobuf;
* that desires a Message instead of a Builder. In terms of the implementation,
* the {@code SingleFieldBuilder} and {@code RepeatedFieldBuilder}
* classes cache messages that were created so that messages only need to be
* created when some change occured in its builder or a builder for one of its
* created when some change occur
r
ed in its builder or a builder for one of its
* descendants.
*
* @param <MType> the type of message for the field
...
...
java/src/main/java/com/google/protobuf/TextFormat.java
View file @
c7680721
...
...
@@ -1386,7 +1386,7 @@ public final class TextFormat {
// Try to guess the type of this field.
// If this field is not a message, there should be a ":" between the
// field name and the field value and also the field value should not
// start with "{" or "<" which indicates the begining of a message body.
// start with "{" or "<" which indicates the begin
n
ing of a message body.
// If there is no ":" or there is a "{" or "<" after ":", this field has
// to be a message or the input is ill-formed.
if
(
tokenizer
.
tryConsume
(
":"
)
&&
!
tokenizer
.
lookingAt
(
"{"
)
&&
...
...
@@ -1567,7 +1567,7 @@ public final class TextFormat {
// Try to guess the type of this field.
// If this field is not a message, there should be a ":" between the
// field name and the field value and also the field value should not
// start with "{" or "<" which indicates the begining of a message body.
// start with "{" or "<" which indicates the begin
n
ing of a message body.
// If there is no ":" or there is a "{" or "<" after ":", this field has
// to be a message or the input is ill-formed.
if
(
tokenizer
.
tryConsume
(
":"
)
&&
!
tokenizer
.
lookingAt
(
"<"
)
&&
...
...
@@ -1584,8 +1584,8 @@ public final class TextFormat {
}
/**
* Skips the whole body of a message including the beginning delim
e
ter and
* the ending delim
e
ter.
* Skips the whole body of a message including the beginning delim
i
ter and
* the ending delim
i
ter.
*/
private
void
skipFieldMessage
(
Tokenizer
tokenizer
)
throws
ParseException
{
final
String
delimiter
;
...
...
python/google/protobuf/internal/generator_test.py
View file @
c7680721
...
...
@@ -149,7 +149,7 @@ class GeneratorTest(basetest.TestCase):
proto
=
unittest_custom_options_pb2
.
TestMessageWithCustomOptions
()
enum_options
=
proto
.
DESCRIPTOR
.
enum_types_by_name
[
'AnEnum'
]
.
GetOptions
()
self
.
assertTrue
(
enum_options
is
not
None
)
# TODO(gps): We really should test for the presen
s
e of the enum_opt1
# TODO(gps): We really should test for the presen
c
e of the enum_opt1
# extension and for its value to be set to -789.
def
testNestedTypes
(
self
):
...
...
python/google/protobuf/internal/service_reflection_test.py
View file @
c7680721
...
...
@@ -118,7 +118,7 @@ class FooUnitTest(basetest.TestCase):
rpc_controller
=
'controller'
request
=
'request'
# GetDescriptor now static, still works as instance method for compat
a
bility
# GetDescriptor now static, still works as instance method for compat
i
bility
self
.
assertEqual
(
unittest_pb2
.
TestService_Stub
.
GetDescriptor
(),
stub
.
GetDescriptor
())
...
...
python/google/protobuf/pyext/message.h
View file @
c7680721
...
...
@@ -136,7 +136,7 @@ PyObject* InternalGetSubMessage(CMessage* self,
//
// Releases messages to the provided cmessage_list if it is not NULL rather
// than just removing them from the underlying proto. This cmessage_list must
// have a CMessage for each underlying submessage. The CMessages refered to
// have a CMessage for each underlying submessage. The CMessages refer
r
ed to
// by slice will be removed from cmessage_list by this function.
//
// Corresponds to reflection api method RemoveLast.
...
...
python/google/protobuf/pyext/repeated_composite_container.h
View file @
c7680721
...
...
@@ -62,7 +62,7 @@ struct CFieldDescriptor;
//
// When in the attached state all modifications to the container are
// done both on the 'message' and on the 'child_messages'
// list. In this state all Messages refered to by the children in
// list. In this state all Messages refer
r
ed to by the children in
// 'child_messages' are owner by the 'owner'.
//
// When in the released state 'message', 'owner', 'parent', and
...
...
python/google/protobuf/pyext/scoped_pyobject_ptr.h
View file @
c7680721
...
...
@@ -38,7 +38,7 @@
namespace
google
{
class
ScopedPyObjectPtr
{
public
:
// Constructor. Defaults to intializing with NULL.
// Constructor. Defaults to in
i
tializing with NULL.
// There is no way to create an uninitialized ScopedPyObjectPtr.
explicit
ScopedPyObjectPtr
(
PyObject
*
p
=
NULL
)
:
ptr_
(
p
)
{
}
...
...
python/mox.py
View file @
c7680721
...
...
@@ -31,7 +31,7 @@ If an unexpected method (or an expected method with unexpected
parameters) is called, then an exception will be raised.
Once you are done interacting with the mock, you need to verify that
all the expected interactions occured. (Maybe your code exited
all the expected interactions occur
r
ed. (Maybe your code exited
prematurely without calling some cleanup method!) The verify phase
ensures that every expected method was called; otherwise, an exception
will be raised.
...
...
src/google/protobuf/compiler/command_line_interface.h
View file @
c7680721
...
...
@@ -214,7 +214,7 @@ class LIBPROTOC_EXPORT CommandLineInterface {
// true if the next argument in the argv should be used as the value,
// false otherwise.
//
// Ex
ma
ples:
// Ex
am
ples:
// "-Isrc/protos" ->
// name = "-I", value = "src/protos"
// "--cpp_out=src/foo.pb2.cc" ->
...
...
src/google/protobuf/compiler/cpp/cpp_unittest.cc
View file @
c7680721
...
...
@@ -1687,7 +1687,7 @@ TEST_F(OneofTest, SwapBothHasFields) {
EXPECT_EQ
(
message2
.
foo_string
(),
"FOO"
);
}
TEST_F
(
OneofTest
,
CopyContructor
)
{
TEST_F
(
OneofTest
,
CopyCon
s
tructor
)
{
unittest
::
TestOneof2
message1
;
message1
.
set_foo_bytes
(
"FOO"
);
...
...
src/google/protobuf/compiler/java/java_file.cc
View file @
c7680721
...
...
@@ -186,7 +186,7 @@ bool FileGenerator::Validate(string* error) {
// proto2 API without code change. When this happens we'd like to issue an
// warning to let the user know that the outer class name has been changed.
// Although we only do this automatic naming fix for immutable API, mutable
// outer class name will also be affected as it's contructed from immutable
// outer class name will also be affected as it's con
s
tructed from immutable
// outer class name with an additional "Mutable" prefix. Since the naming
// change in mutable API is not caused by a naming conflict, we generate the
// warning for immutable API only.
...
...
src/google/protobuf/compiler/java/java_helpers.h
View file @
c7680721
...
...
@@ -132,7 +132,7 @@ string FieldConstantName(const FieldDescriptor *field);
// Returns the type of the FieldDescriptor.
// This does nothing interesting for the open source release, but is used for
// hacks that improve compat
a
bility with version 1 protocol buffers at Google.
// hacks that improve compat
i
bility with version 1 protocol buffers at Google.
FieldDescriptor
::
Type
GetType
(
const
FieldDescriptor
*
field
);
enum
JavaType
{
...
...
src/google/protobuf/descriptor.cc
View file @
c7680721
...
...
@@ -3296,7 +3296,7 @@ const FileDescriptor* DescriptorBuilder::BuildFile(
// Note: This only works if the input is canonical -- that is, it
// fully-qualifies all type names, has no UninterpretedOptions, etc.
// This is fine, because this idempotency "feature" really only exists to
// accomodate one hack in the proto1->proto2 migration layer.
// accom
m
odate one hack in the proto1->proto2 migration layer.
const
FileDescriptor
*
existing_file
=
tables_
->
FindFile
(
filename_
);
if
(
existing_file
!=
NULL
)
{
// File already in pool. Compare the existing one to the input.
...
...
src/google/protobuf/descriptor.h
View file @
c7680721
...
...
@@ -1268,7 +1268,7 @@ class LIBPROTOBUF_EXPORT DescriptorPool {
};
// Reports an error in the FileDescriptorProto. Use this function if the
// problem occured should interrupt building the FileDescriptorProto.
// problem occur
r
ed should interrupt building the FileDescriptorProto.
virtual
void
AddError
(
const
string
&
filename
,
// File name in which the error occurred.
const
string
&
element_name
,
// Full name of the erroneous element.
...
...
@@ -1278,7 +1278,7 @@ class LIBPROTOBUF_EXPORT DescriptorPool {
)
=
0
;
// Reports a warning in the FileDescriptorProto. Use this function if the
// problem occured should NOT interrupt building the FileDescriptorProto.
// problem occur
r
ed should NOT interrupt building the FileDescriptorProto.
virtual
void
AddWarning
(
const
string
&
/*filename*/
,
// File name in which the error occurred.
const
string
&
/*element_name*/
,
// Full name of the erroneous element.
...
...
src/google/protobuf/io/tokenizer.h
View file @
c7680721
...
...
@@ -350,7 +350,7 @@ class LIBPROTOBUF_EXPORT Tokenizer {
// -----------------------------------------------------------------
// These helper methods make the parsing code more readable. The
// "character classes" refered to are defined at the top of the .cc file.
// "character classes" refer
r
ed to are defined at the top of the .cc file.
// Basically it is a C++ class with one method:
// static bool InClass(char c);
// The method returns true if c is a member of this "class", like "Letter"
...
...
src/google/protobuf/stubs/common.h
View file @
c7680721
...
...
@@ -449,7 +449,7 @@ class scoped_ptr {
// The element type
typedef
C
element_type
;
// Constructor. Defaults to intializing with NULL.
// Constructor. Defaults to in
i
tializing with NULL.
// There is no way to create an uninitialized scoped_ptr.
// The input parameter must be allocated with new.
explicit
scoped_ptr
(
C
*
p
=
NULL
)
:
ptr_
(
p
)
{
}
...
...
@@ -536,7 +536,7 @@ class scoped_array {
// The element type
typedef
C
element_type
;
// Constructor. Defaults to intializing with NULL.
// Constructor. Defaults to in
i
tializing with NULL.
// There is no way to create an uninitialized scoped_array.
// The input parameter must be allocated with new [].
explicit
scoped_array
(
C
*
p
=
NULL
)
:
array_
(
p
)
{
}
...
...
src/google/protobuf/stubs/template_util.h
View file @
c7680721
...
...
@@ -37,7 +37,7 @@
// any changes here, make sure that you're not breaking any platforms.
//
//
// The names cho
o
sen here reflect those used in tr1 and the boost::mpl
// The names chosen here reflect those used in tr1 and the boost::mpl
// library, there are similar operations used in the Loki library as
// well. I prefer the boost names for 2 reasons:
// 1. I think that portions of the Boost libraries are more likely to
...
...
src/google/protobuf/text_format.cc
View file @
c7680721
...
...
@@ -319,16 +319,16 @@ class TextFormat::Parser::ParserImpl {
message
);
}
// Consumes the specified message with the given starting delim
e
ter.
// This method checks to see that the end delim
e
ter at the conclusion of
// the consumption matches the starting delim
e
ter passed in here.
bool
ConsumeMessage
(
Message
*
message
,
const
string
delim
e
ter
)
{
// Consumes the specified message with the given starting delim
i
ter.
// This method checks to see that the end delim
i
ter at the conclusion of
// the consumption matches the starting delim
i
ter passed in here.
bool
ConsumeMessage
(
Message
*
message
,
const
string
delim
i
ter
)
{
while
(
!
LookingAt
(
">"
)
&&
!
LookingAt
(
"}"
))
{
DO
(
ConsumeField
(
message
));
}
// Confirm that we have a valid ending delim
e
ter.
DO
(
Consume
(
delim
e
ter
));
// Confirm that we have a valid ending delim
i
ter.
DO
(
Consume
(
delim
i
ter
));
return
true
;
}
...
...
@@ -428,7 +428,7 @@ class TextFormat::Parser::ParserImpl {
// Try to guess the type of this field.
// If this field is not a message, there should be a ":" between the
// field name and the field value and also the field value should not
// start with "{" or "<" which indicates the begining of a message body.
// start with "{" or "<" which indicates the begin
n
ing of a message body.
// If there is no ":" or there is a "{" or "<" after ":", this field has
// to be a message or the input is ill-formed.
if
(
TryConsume
(
":"
)
&&
!
LookingAt
(
"{"
)
&&
!
LookingAt
(
"<"
))
{
...
...
@@ -526,7 +526,7 @@ class TextFormat::Parser::ParserImpl {
// Try to guess the type of this field.
// If this field is not a message, there should be a ":" between the
// field name and the field value and also the field value should not
// start with "{" or "<" which indicates the begining of a message body.
// start with "{" or "<" which indicates the begin
n
ing of a message body.
// If there is no ":" or there is a "{" or "<" after ":", this field has
// to be a message or the input is ill-formed.
if
(
TryConsume
(
":"
)
&&
!
LookingAt
(
"{"
)
&&
!
LookingAt
(
"<"
))
{
...
...
@@ -551,19 +551,19 @@ class TextFormat::Parser::ParserImpl {
parse_info_tree_
=
CreateNested
(
parent
,
field
);
}
string
delim
e
ter
;
string
delim
i
ter
;
if
(
TryConsume
(
"<"
))
{
delim
e
ter
=
">"
;
delim
i
ter
=
">"
;
}
else
{
DO
(
Consume
(
"{"
));
delim
e
ter
=
"}"
;
delim
i
ter
=
"}"
;
}
if
(
field
->
is_repeated
())
{
DO
(
ConsumeMessage
(
reflection
->
AddMessage
(
message
,
field
),
delim
e
ter
));
DO
(
ConsumeMessage
(
reflection
->
AddMessage
(
message
,
field
),
delim
i
ter
));
}
else
{
DO
(
ConsumeMessage
(
reflection
->
MutableMessage
(
message
,
field
),
delim
e
ter
));
delim
i
ter
));
}
// Reset the parse information tree.
...
...
@@ -571,20 +571,20 @@ class TextFormat::Parser::ParserImpl {
return
true
;
}
// Skips the whole body of a message including the begin
ing delime
ter and
// the ending delim
e
ter.
// Skips the whole body of a message including the begin
ning delimi
ter and
// the ending delim
i
ter.
bool
SkipFieldMessage
()
{
string
delim
e
ter
;
string
delim
i
ter
;
if
(
TryConsume
(
"<"
))
{
delim
e
ter
=
">"
;
delim
i
ter
=
">"
;
}
else
{
DO
(
Consume
(
"{"
));
delim
e
ter
=
"}"
;
delim
i
ter
=
"}"
;
}
while
(
!
LookingAt
(
">"
)
&&
!
LookingAt
(
"}"
))
{
DO
(
SkipField
());
}
DO
(
Consume
(
delim
e
ter
));
DO
(
Consume
(
delim
i
ter
));
return
true
;
}
...
...
src/google/protobuf/text_format_unittest.cc
View file @
c7680721
...
...
@@ -263,7 +263,7 @@ TEST_F(TextFormatTest, PrintUnknownFields) {
}
TEST_F
(
TextFormatTest
,
PrintUnknownFieldsHidden
)
{
// Test printing of unknown fields in a message when supressed.
// Test printing of unknown fields in a message when sup
p
ressed.
unittest
::
OneString
message
;
message
.
set_data
(
"data"
);
...
...
@@ -586,7 +586,7 @@ TEST_F(TextFormatTest, ParseConcatenatedString) {
// Compare.
EXPECT_EQ
(
"foobar"
,
proto_
.
optional_string
());
// Create a parse string with multiple parts on sep
e
rate lines.
// Create a parse string with multiple parts on sep
a
rate lines.
parse_string
=
"optional_string:
\"
foo
\"\n
"
"
\"
bar
\"\n
"
;
...
...
@@ -1324,12 +1324,12 @@ TEST_F(TextFormatParserTest, InvalidFieldValues) {
"Expected
\"
:
\"
, found
\"
{
\"
."
,
1
,
22
);
}
TEST_F
(
TextFormatParserTest
,
MessageDelim
e
ters
)
{
// Non-matching delim
e
ters.
TEST_F
(
TextFormatParserTest
,
MessageDelim
i
ters
)
{
// Non-matching delim
i
ters.
ExpectFailure
(
"OptionalGroup <
\n
\n
}
\n
"
,
"Expected
\"
>
\"
, found
\"
}
\"
."
,
3
,
1
);
// Invalid delim
e
ters.
// Invalid delim
i
ters.
ExpectFailure
(
"OptionalGroup [
\n
\n
]
\n
"
,
"Expected
\"
{
\"
, found
\"
[
\"
."
,
1
,
15
);
...
...
@@ -1340,7 +1340,7 @@ TEST_F(TextFormatParserTest, MessageDelimeters) {
}
TEST_F
(
TextFormatParserTest
,
UnknownExtension
)
{
// Non-matching delim
e
ters.
// Non-matching delim
i
ters.
ExpectFailure
(
"[blahblah]: 123"
,
"Extension
\"
blahblah
\"
is not defined or is not an "
"extension of
\"
protobuf_unittest.TestAllTypes
\"
."
,
...
...
src/google/protobuf/unittest_import.proto
View file @
c7680721
...
...
@@ -43,7 +43,7 @@ package protobuf_unittest_import;
option
optimize_for
=
SPEED
;
// Ex
c
ercise the java_package option.
// Exercise the java_package option.
option
java_package
=
"com.google.protobuf.test"
;
// Do not set a java_outer_classname here to verify that Proto2 works without
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment