Commit b1b9eaa6 authored by Thomas Van Lenten's avatar Thomas Van Lenten

Comments on the next line will go to the next field.

Even though the comments were indented to appear to go with the jspb
case/field, protoc doesn't collect comments like that, so these "hanging"
comments actually "attach" to the next thing added to each.  Looking at
https://github.com/protocolbuffers/protobuf/pull/5566 you see where
the generated code picked up the comment on the wrong field.
parent 0adb74c2
...@@ -68,8 +68,8 @@ enum TestCategory { ...@@ -68,8 +68,8 @@ enum TestCategory {
// https://developers.google.com/protocol-buffers/docs/proto3#json_options // https://developers.google.com/protocol-buffers/docs/proto3#json_options
// for more detail. // for more detail.
JSON_IGNORE_UNKNOWN_PARSING_TEST = 3; JSON_IGNORE_UNKNOWN_PARSING_TEST = 3;
JSPB_TEST = 4; // Test jspb wire format. Google internal only. // Test jspb wire format. Google internal only. Opensource testees just skip it.
// Opensource testees just skip it. JSPB_TEST = 4;
} }
message FailureSet { message FailureSet {
...@@ -92,8 +92,8 @@ message ConformanceRequest { ...@@ -92,8 +92,8 @@ message ConformanceRequest {
oneof payload { oneof payload {
bytes protobuf_payload = 1; bytes protobuf_payload = 1;
string json_payload = 2; string json_payload = 2;
string jspb_payload = 7; // Google internal only. // Google internal only. Opensource testees just skip it.
// Opensource testees just skip it. string jspb_payload = 7;
} }
// Which format should the testee serialize its message to? // Which format should the testee serialize its message to?
......
...@@ -86,7 +86,7 @@ namespace Conformance { ...@@ -86,7 +86,7 @@ namespace Conformance {
/// </summary> /// </summary>
[pbr::OriginalName("JSON_IGNORE_UNKNOWN_PARSING_TEST")] JsonIgnoreUnknownParsingTest = 3, [pbr::OriginalName("JSON_IGNORE_UNKNOWN_PARSING_TEST")] JsonIgnoreUnknownParsingTest = 3,
/// <summary> /// <summary>
/// Test jspb wire format. Google internal only. /// Test jspb wire format. Google internal only. Opensource testees just skip it.
/// </summary> /// </summary>
[pbr::OriginalName("JSPB_TEST")] JspbTest = 4, [pbr::OriginalName("JSPB_TEST")] JspbTest = 4,
} }
...@@ -298,7 +298,7 @@ namespace Conformance { ...@@ -298,7 +298,7 @@ namespace Conformance {
/// <summary>Field number for the "jspb_payload" field.</summary> /// <summary>Field number for the "jspb_payload" field.</summary>
public const int JspbPayloadFieldNumber = 7; public const int JspbPayloadFieldNumber = 7;
/// <summary> /// <summary>
/// Google internal only. /// Google internal only. Opensource testees just skip it.
/// </summary> /// </summary>
[global::System.Diagnostics.DebuggerNonUserCodeAttribute] [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public string JspbPayload { public string JspbPayload {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment