check provided size

9bfed46c · ming · 8af87de9 · 9bfed46c
Commit 9bfed46c authored Jun 18, 2018 by ming
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

js_generator.cc src/google/protobuf/compiler/js/js_generator.cc +2 -1

No files found.
--- a/src/google/protobuf/compiler/js/js_generator.cc
+++ b/src/google/protobuf/compiler/js/js_generator.cc
@@ -3477,7 +3477,8 @@ void Generator::GenerateFile(const GeneratorOptions& options,
    GenerateExtension(options, printer, *it);
  }

-  if (options.import_style == GeneratorOptions::kImportCommonJs) {
+  // if provided is empty, do not export anything
+  if (options.import_style == GeneratorOptions::kImportCommonJs && provided.size()) {
    printer->Print("goog.object.extend(exports, $package$);\n",
                   "package", GetFilePath(options, file));
  }