Commit 92d768c1 authored by Jisi Liu's avatar Jisi Liu Committed by GitHub

Merge pull request #3536 from pherl/io32_11

Remove C++11 features in io_win32.cc
parents 26ac3e8e 77a453a5
...@@ -57,6 +57,7 @@ ...@@ -57,6 +57,7 @@
#include <windows.h> #include <windows.h>
#include <google/protobuf/stubs/io_win32.h> #include <google/protobuf/stubs/io_win32.h>
#include <google/protobuf/stubs/scoped_ptr.h>
#include <cassert> #include <cassert>
#include <memory> #include <memory>
...@@ -71,7 +72,6 @@ namespace win32 { ...@@ -71,7 +72,6 @@ namespace win32 {
namespace { namespace {
using std::string; using std::string;
using std::unique_ptr;
using std::wstring; using std::wstring;
template <typename char_type> template <typename char_type>
...@@ -139,11 +139,11 @@ string join_paths(const string& path1, const string& path2) { ...@@ -139,11 +139,11 @@ string join_paths(const string& path1, const string& path2) {
return path1; return path1;
} }
if (is_separator(path1.back())) { if (is_separator(path1[path1.size() - 1])) {
return is_separator(path2.front()) ? (path1 + path2.substr(1)) return is_separator(path2[0]) ? (path1 + path2.substr(1))
: (path1 + path2); : (path1 + path2);
} else { } else {
return is_separator(path2.front()) ? (path1 + path2) return is_separator(path2[0]) ? (path1 + path2)
: (path1 + '\\' + path2); : (path1 + '\\' + path2);
} }
} }
...@@ -203,24 +203,24 @@ string normalize(string path) { ...@@ -203,24 +203,24 @@ string normalize(string path) {
result << s; result << s;
} }
// Preserve trailing separator if the input contained it. // Preserve trailing separator if the input contained it.
if (is_separator(path.back())) { if (!path.empty() && is_separator(path[path.size() - 1])) {
result << '\\'; result << '\\';
} }
return result.str(); return result.str();
} }
std::unique_ptr<WCHAR[]> as_wstring(const string& s) { WCHAR* as_wstring(const string& s) {
int len = ::MultiByteToWideChar(CP_UTF8, 0, s.c_str(), s.size(), NULL, 0); int len = ::MultiByteToWideChar(CP_UTF8, 0, s.c_str(), s.size(), NULL, 0);
std::unique_ptr<WCHAR[]> result(new WCHAR[len + 1]); WCHAR* result = new WCHAR[len + 1];
::MultiByteToWideChar(CP_UTF8, 0, s.c_str(), s.size(), result.get(), len + 1); ::MultiByteToWideChar(CP_UTF8, 0, s.c_str(), s.size(), result, len + 1);
result.get()[len] = 0; result[len] = 0;
return std::move(result); return result;
} }
wstring as_wchar_path(const string& path) { void as_wchar_path(const string& path, wstring* wchar_path) {
std::unique_ptr<WCHAR[]> wbuf(as_wstring(path)); scoped_array<WCHAR> wbuf(as_wstring(path));
replace_directory_separators(wbuf.get()); replace_directory_separators(wbuf.get());
return wstring(wbuf.get()); wchar_path->assign(wbuf.get());
} }
bool as_windows_path(const string& path, wstring* result) { bool as_windows_path(const string& path, wstring* result) {
...@@ -239,7 +239,7 @@ bool as_windows_path(const string& path, wstring* result) { ...@@ -239,7 +239,7 @@ bool as_windows_path(const string& path, wstring* result) {
::GetCurrentDirectoryA(MAX_PATH, cwd); ::GetCurrentDirectoryA(MAX_PATH, cwd);
mutable_path = join_paths(cwd, mutable_path); mutable_path = join_paths(cwd, mutable_path);
} }
*result = as_wchar_path(normalize(mutable_path)); as_wchar_path(normalize(mutable_path), result);
if (!has_longpath_prefix(result->c_str())) { if (!has_longpath_prefix(result->c_str())) {
// Add the "\\?\" prefix unconditionally. This way we prevent the Win32 API // Add the "\\?\" prefix unconditionally. This way we prevent the Win32 API
// from processing the path and "helpfully" removing trailing dots from the // from processing the path and "helpfully" removing trailing dots from the
...@@ -324,7 +324,7 @@ FILE* fopen(const char* path, const char* mode) { ...@@ -324,7 +324,7 @@ FILE* fopen(const char* path, const char* mode) {
errno = ENOENT; errno = ENOENT;
return NULL; return NULL;
} }
std::unique_ptr<WCHAR[]> wmode(as_wstring(mode)); scoped_array<WCHAR> wmode(as_wstring(mode));
return ::_wfopen(wpath.c_str(), wmode.get()); return ::_wfopen(wpath.c_str(), wmode.get());
#else #else
return ::fopen(path, mode); return ::fopen(path, mode);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment