Commit 76a73945 authored by csharptest's avatar csharptest Committed by rogerk

merged fix for SortedList

parents 7f7a7547 8601fc98
...@@ -93,11 +93,11 @@ namespace Google.ProtocolBuffers ...@@ -93,11 +93,11 @@ namespace Google.ProtocolBuffers
} }
} }
private readonly SortedList<int, IEnumLite> items; private readonly Dictionary<int, IEnumLite> items;
public EnumLiteMap() public EnumLiteMap()
{ {
items = new SortedList<int, IEnumLite>(); items = new Dictionary<int, IEnumLite>();
#if SILVERLIGHT2 #if SILVERLIGHT2
// Silverlight doesn't support Enum.GetValues // Silverlight doesn't support Enum.GetValues
// TODO(jonskeet): Validate that this reflection is permitted, e.g. in Windows Phone 7 // TODO(jonskeet): Validate that this reflection is permitted, e.g. in Windows Phone 7
......
...@@ -87,8 +87,12 @@ namespace Google.ProtocolBuffers ...@@ -87,8 +87,12 @@ namespace Google.ProtocolBuffers
public static FieldSet CreateInstance() public static FieldSet CreateInstance()
{ {
#if SILVERLIGHT2
return new FieldSet(new Dictionary<IFieldDescriptorLite, object>());
#else
// Use SortedList to keep fields in the canonical order // Use SortedList to keep fields in the canonical order
return new FieldSet(new SortedList<IFieldDescriptorLite, object>()); return new FieldSet(new SortedList<IFieldDescriptorLite, object>());
#endif
} }
/// <summary> /// <summary>
...@@ -309,7 +313,16 @@ namespace Google.ProtocolBuffers ...@@ -309,7 +313,16 @@ namespace Google.ProtocolBuffers
/// </summary> /// </summary>
internal IEnumerator<KeyValuePair<IFieldDescriptorLite, object>> GetEnumerator() internal IEnumerator<KeyValuePair<IFieldDescriptorLite, object>> GetEnumerator()
{ {
#if SILVERLIGHT2
List<KeyValuePair<IFieldDescriptorLite, object>> result = new List<KeyValuePair<IFieldDescriptorLite, object>>(fields);
result.Sort(
delegate(KeyValuePair<IFieldDescriptorLite, object> a, KeyValuePair<IFieldDescriptorLite, object> b)
{ return a.Key.CompareTo(b.Key); }
);
return result.GetEnumerator();
#else
return fields.GetEnumerator(); return fields.GetEnumerator();
#endif
} }
/// <summary> /// <summary>
...@@ -461,9 +474,12 @@ namespace Google.ProtocolBuffers ...@@ -461,9 +474,12 @@ namespace Google.ProtocolBuffers
/// </summary> /// </summary>
public void WriteTo(ICodedOutputStream output) public void WriteTo(ICodedOutputStream output)
{ {
foreach (KeyValuePair<IFieldDescriptorLite, object> entry in fields) using (IEnumerator<KeyValuePair<IFieldDescriptorLite, object>> e = GetEnumerator())
{ {
WriteField(entry.Key, entry.Value, output); while (e.MoveNext())
{
WriteField(e.Current.Key, e.Current.Value, output);
}
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment