Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
60a889e0
Commit
60a889e0
authored
Mar 12, 2019
by
Jan Tattermusch
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make check for distinct hashcode optional
parent
d305c2ac
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
3 deletions
+5
-3
RepeatedFieldTest.cs
...src/Google.Protobuf.Test/Collections/RepeatedFieldTest.cs
+2
-1
EqualityTester.cs
csharp/src/Google.Protobuf.Test/EqualityTester.cs
+3
-2
No files found.
csharp/src/Google.Protobuf.Test/Collections/RepeatedFieldTest.cs
View file @
60a889e0
...
@@ -750,7 +750,8 @@ namespace Google.Protobuf.Collections
...
@@ -750,7 +750,8 @@ namespace Google.Protobuf.Collections
var
list2
=
new
RepeatedField
<
double
>
{
SampleNaNs
.
Regular
,
SampleNaNs
.
PayloadFlipped
};
var
list2
=
new
RepeatedField
<
double
>
{
SampleNaNs
.
Regular
,
SampleNaNs
.
PayloadFlipped
};
var
list3
=
new
RepeatedField
<
double
>
{
SampleNaNs
.
Regular
,
SampleNaNs
.
SignallingFlipped
};
var
list3
=
new
RepeatedField
<
double
>
{
SampleNaNs
.
Regular
,
SampleNaNs
.
SignallingFlipped
};
EqualityTester
.
AssertInequality
(
list1
,
list2
);
// All SampleNaNs have the same hashcode under certain targets (e.g. netcoreapp2.1)
EqualityTester
.
AssertInequality
(
list1
,
list2
,
checkHashcode
:
false
);
EqualityTester
.
AssertEquality
(
list1
,
list3
);
EqualityTester
.
AssertEquality
(
list1
,
list3
);
Assert
.
True
(
list1
.
Contains
(
SampleNaNs
.
SignallingFlipped
));
Assert
.
True
(
list1
.
Contains
(
SampleNaNs
.
SignallingFlipped
));
Assert
.
False
(
list2
.
Contains
(
SampleNaNs
.
SignallingFlipped
));
Assert
.
False
(
list2
.
Contains
(
SampleNaNs
.
SignallingFlipped
));
...
...
csharp/src/Google.Protobuf.Test/EqualityTester.cs
View file @
60a889e0
...
@@ -49,13 +49,14 @@ namespace Google.Protobuf
...
@@ -49,13 +49,14 @@ namespace Google.Protobuf
Assert
.
AreEqual
(
first
.
GetHashCode
(),
second
.
GetHashCode
());
Assert
.
AreEqual
(
first
.
GetHashCode
(),
second
.
GetHashCode
());
}
}
public
static
void
AssertInequality
<
T
>(
T
first
,
T
second
)
where
T
:
IEquatable
<
T
>
public
static
void
AssertInequality
<
T
>(
T
first
,
T
second
,
bool
checkHashcode
=
true
)
where
T
:
IEquatable
<
T
>
{
{
Assert
.
IsFalse
(
first
.
Equals
(
second
));
Assert
.
IsFalse
(
first
.
Equals
(
second
));
Assert
.
IsFalse
(
first
.
Equals
((
object
)
second
));
Assert
.
IsFalse
(
first
.
Equals
((
object
)
second
));
// While this isn't a requirement, the chances of this test failing due to
// While this isn't a requirement, the chances of this test failing due to
// coincidence rather than a bug are very small.
// coincidence rather than a bug are very small.
if
(
first
!=
null
&&
second
!=
null
)
// For such rare cases, an argument can be used to disable the check.
if
(
checkHashcode
&&
first
!=
null
&&
second
!=
null
)
{
{
Assert
.
AreNotEqual
(
first
.
GetHashCode
(),
second
.
GetHashCode
());
Assert
.
AreNotEqual
(
first
.
GetHashCode
(),
second
.
GetHashCode
());
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment