Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
600e4e5f
Commit
600e4e5f
authored
Aug 01, 2018
by
Yilun Chong
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix
parent
1bec76f0
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
1 deletion
+6
-1
reader_test.js
js/binary/reader_test.js
+6
-1
No files found.
js/binary/reader_test.js
View file @
600e4e5f
...
...
@@ -682,10 +682,15 @@ describe('binaryReaderTest', function() {
// Previously the skipGroup implementation was wrong, which only consume
// the decoder by nextField. This case is for making the previous
// implementation failed in skipGroup by an early end group tag.
// The reason is 44 = 5 * 8 + 4, this will be translated in to a field
// with number 5 and with type 4 (end group)
writer
.
writeInt64
(
44
,
44
);
// This will make previous implementation failed by invalid tag (7).
writer
.
writeInt64
(
42
,
47
);
writer
.
writeInt64
(
42
,
42
);
// This is for making the previous implementation failed by an invalid
// varint.
// varint. The bytes have at least 9 consecutive minus byte, which will
// fail in this.nextField for previous implementation.
writer
.
writeBytes
(
43
,
[
255
,
255
,
255
,
255
,
255
,
255
,
255
,
255
,
255
,
255
]);
writer
.
writeGroup
(
6
,
dummyMessage
,
function
()
{
writer
.
writeInt64
(
84
,
42
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment