Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
5904279e
Commit
5904279e
authored
Sep 19, 2016
by
Thomas Van Lenten
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove the custom key functions and just use the system provided defaults.
parent
b5bbdb09
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
40 deletions
+3
-40
GPBUnknownFieldSet.m
objectivec/GPBUnknownFieldSet.m
+3
-40
No files found.
objectivec/GPBUnknownFieldSet.m
View file @
5904279e
...
...
@@ -36,39 +36,6 @@
#import "GPBUtilities.h"
#import "GPBWireFormat.h"
#pragma mark CFDictionaryKeyCallBacks
// We use a custom dictionary here because our keys are numbers and
// conversion back and forth from NSNumber was costing us performance.
// If/when we move to C++ this could be done using a std::map and some
// careful retain/release calls.
static
const
void
*
GPBUnknownFieldSetKeyRetain
(
CFAllocatorRef
allocator
,
const
void
*
value
)
{
#pragma unused(allocator)
return
value
;
}
static
void
GPBUnknownFieldSetKeyRelease
(
CFAllocatorRef
allocator
,
const
void
*
value
)
{
#pragma unused(allocator)
#pragma unused(value)
}
static
CFStringRef
GPBUnknownFieldSetCopyKeyDescription
(
const
void
*
value
)
{
return
CFStringCreateWithFormat
(
kCFAllocatorDefault
,
NULL
,
CFSTR
(
"%d"
),
(
int
)
value
);
}
static
Boolean
GPBUnknownFieldSetKeyEqual
(
const
void
*
value1
,
const
void
*
value2
)
{
return
value1
==
value2
;
}
static
CFHashCode
GPBUnknownFieldSetKeyHash
(
const
void
*
value
)
{
return
(
CFHashCode
)
value
;
}
#pragma mark Helpers
static
void
checkNumber
(
int32_t
number
)
{
...
...
@@ -291,13 +258,9 @@ static void GPBUnknownFieldSetSerializedSizeAsMessageSet(const void *key,
int32_t
number
=
[
field
number
];
checkNumber
(
number
);
if
(
!
fields_
)
{
CFDictionaryKeyCallBacks
keyCallBacks
=
{
// See description above for reason for using custom dictionary.
0
,
GPBUnknownFieldSetKeyRetain
,
GPBUnknownFieldSetKeyRelease
,
GPBUnknownFieldSetCopyKeyDescription
,
GPBUnknownFieldSetKeyEqual
,
GPBUnknownFieldSetKeyHash
,
};
fields_
=
CFDictionaryCreateMutable
(
kCFAllocatorDefault
,
0
,
&
keyCallBacks
,
// Use a custom dictionary here because the keys are numbers and conversion
// back and forth from NSNumber isn't worth the cost.
fields_
=
CFDictionaryCreateMutable
(
kCFAllocatorDefault
,
0
,
NULL
,
&
kCFTypeDictionaryValueCallBacks
);
}
ssize_t
key
=
number
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment