Commit 4c5d3edd authored by Adam Michalik's avatar Adam Michalik

Fix integer overflow in FastUInt32ToBufferLeft

If digits > 2, and int is 32 bit, line 999 overflows. It has been fixed
internally in CL 41203823.
parent 9d709f44
...@@ -981,7 +981,7 @@ static const char two_ASCII_digits[100][2] = { ...@@ -981,7 +981,7 @@ static const char two_ASCII_digits[100][2] = {
}; };
char* FastUInt32ToBufferLeft(uint32 u, char* buffer) { char* FastUInt32ToBufferLeft(uint32 u, char* buffer) {
int digits; uint32 digits;
const char *ASCII_digits = NULL; const char *ASCII_digits = NULL;
// The idea of this implementation is to trim the number of divides to as few // The idea of this implementation is to trim the number of divides to as few
// as possible by using multiplication and subtraction rather than mod (%), // as possible by using multiplication and subtraction rather than mod (%),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment