Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
4ba30923
Commit
4ba30923
authored
Nov 15, 2017
by
Dave MacLachlan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
code review cleanup
parent
949596ea
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
GPBMessage.m
objectivec/GPBMessage.m
+5
-5
No files found.
objectivec/GPBMessage.m
View file @
4ba30923
...
...
@@ -2998,6 +2998,9 @@ typedef struct ResolveIvarAccessorMethodResult {
SEL
encodingSelector
;
}
ResolveIvarAccessorMethodResult
;
// |field| can be __unsafe_unretained because they are created at startup
// and are essentially global. No need to pay for retain/release when
// they are captured in blocks.
static
void
ResolveIvarGet
(
__unsafe_unretained
GPBFieldDescriptor
*
field
,
ResolveIvarAccessorMethodResult
*
result
)
{
GPBDataType
fieldDataType
=
GPBGetFieldDataType
(
field
);
...
...
@@ -3040,6 +3043,7 @@ static void ResolveIvarGet(__unsafe_unretained GPBFieldDescriptor *field,
}
}
// See comment about __unsafe_unretained on ResolveIvarGet.
static
void
ResolveIvarSet
(
__unsafe_unretained
GPBFieldDescriptor
*
field
,
GPBFileSyntax
syntax
,
ResolveIvarAccessorMethodResult
*
result
)
{
...
...
@@ -3084,13 +3088,9 @@ static void ResolveIvarSet(__unsafe_unretained GPBFieldDescriptor *field,
// NOTE: hasOrCountSel_/setHasSel_ will be NULL if the field for the given
// message should not have has support (done in GPBDescriptor.m), so there is
// no need for checks here to see if has*/setHas* are allowed.
ResolveIvarAccessorMethodResult
result
=
{
NULL
,
NULL
};
// |field| can be __unsafe_unretained because they are created at startup
// and are essentially global. No need to pay for retain/release when
// they are captured in blocks.
// See comment about __unsafe_unretained on ResolveIvarGet.
for
(
__unsafe_unretained
GPBFieldDescriptor
*
field
in
descriptor
->
fields_
)
{
BOOL
isMapOrArray
=
GPBFieldIsMapOrArray
(
field
);
if
(
!
isMapOrArray
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment