Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
401db44e
Commit
401db44e
authored
Dec 14, 2018
by
Josh Haberman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
More fixes.
parent
eff1a6a0
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
9 deletions
+8
-9
objectivec_helpers.cc
...google/protobuf/compiler/objectivec/objectivec_helpers.cc
+8
-9
No files found.
src/google/protobuf/compiler/objectivec/objectivec_helpers.cc
View file @
401db44e
...
...
@@ -48,9 +48,9 @@
#include <google/protobuf/io/printer.h>
#include <google/protobuf/io/zero_copy_stream_impl.h>
#include <google/protobuf/stubs/io_win32.h>
#include <google/protobuf/stubs/port.h>
#include <google/protobuf/stubs/strutil.h>
// NOTE: src/google/protobuf/compiler/plugin.cc makes use of cerr for some
// error cases, so it seems to be ok to use as a back door for errors.
...
...
@@ -859,7 +859,7 @@ string DefaultValue(const FieldDescriptor* field) {
// Some compilers report reaching end of function even though all cases of
// the enum are handed in the switch.
GOOGLE_LOG
(
FATAL
)
<<
"Can't get here."
;
return
NULL
;
return
string
()
;
}
bool
HasNonZeroDefaultValue
(
const
FieldDescriptor
*
field
)
{
...
...
@@ -1047,9 +1047,8 @@ bool ExpectedPrefixesCollector::ConsumeLine(
const
StringPiece
&
line
,
string
*
out_error
)
{
int
offset
=
line
.
find
(
'='
);
if
(
offset
==
StringPiece
::
npos
)
{
*
out_error
=
string
(
"Expected prefixes file line without equal sign: '"
)
+
line
.
ToString
()
+
"'."
;
*
out_error
=
string
(
"Expected prefixes file line without equal sign: '"
)
+
string
(
line
)
+
"'."
;
return
false
;
}
StringPiece
package
=
line
.
substr
(
0
,
offset
);
...
...
@@ -1474,7 +1473,7 @@ class Parser {
bool
Parser
::
ParseChunk
(
StringPiece
chunk
)
{
if
(
!
leftover_
.
empty
())
{
leftover_
+=
chunk
;
leftover_
+=
string
(
chunk
)
;
p_
=
StringPiece
(
leftover_
);
}
else
{
p_
=
chunk
;
...
...
@@ -1693,11 +1692,11 @@ bool ImportWriter::ProtoFrameworkCollector::ConsumeLine(
if
(
offset
==
StringPiece
::
npos
)
{
*
out_error
=
string
(
"Framework/proto file mapping line without colon sign: '"
)
+
line
.
ToString
(
)
+
"'."
;
string
(
line
)
+
"'."
;
return
false
;
}
StringPiece
framework_name
(
line
,
0
,
offset
);
StringPiece
proto_file_list
(
line
,
offset
+
1
,
line
.
length
()
-
offset
-
1
);
StringPiece
framework_name
=
line
.
substr
(
0
,
offset
);
StringPiece
proto_file_list
=
line
.
substr
(
offset
+
1
);
TrimWhitespace
(
&
framework_name
);
int
start
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment