Commit 304ff3a8 authored by csharptest's avatar csharptest Committed by rogerk

Changes from review e805fdfd3a6b

parent 9b3de692
......@@ -72,6 +72,10 @@ namespace Google.ProtocolBuffers.ProtoGen
return true;
}
/// <summary>
/// This returns true if the field has a non-default default value. For instance this returns
/// false for numerics with a default of zero '0', or booleans with a default of false.
/// </summary>
protected bool HasDefaultValue
{
get
......
......@@ -370,7 +370,7 @@ namespace Google.ProtocolBuffers
WriteRawVarint32(value);
}
public void WriteEnum(int fieldNumber, string fieldName, int value, object textValue)
public void WriteEnum(int fieldNumber, string fieldName, int value, object rawValue)
{
WriteTag(fieldNumber, WireFormat.WireType.Varint);
WriteRawVarint32((uint) value);
......
......@@ -42,7 +42,7 @@ namespace Google.ProtocolBuffers.Collections
/// </summary>
public sealed class PopsicleList<T> : IPopsicleList<T>, ICastArray
{
private static readonly IEnumerable<T> EmptySet = new T[0];
private static readonly T[] EmptySet = new T[0];
private List<T> items;
private bool readOnly;
......@@ -134,7 +134,8 @@ namespace Google.ProtocolBuffers.Collections
public IEnumerator<T> GetEnumerator()
{
return items == null ? EmptySet.GetEnumerator() : items.GetEnumerator();
IEnumerable<T> tenum = (IEnumerable<T>)items ?? EmptySet;
return tenum.GetEnumerator();
}
IEnumerator IEnumerable.GetEnumerator()
......@@ -171,7 +172,7 @@ namespace Google.ProtocolBuffers.Collections
{
if (items == null)
{
return new TItemType[0];
return PopsicleList<TItemType>.EmptySet;
}
return (TItemType[]) (object) items.ToArray();
}
......
......@@ -88,6 +88,7 @@
<ItemGroup>
<Reference Include="mscorlib" />
<Reference Include="System" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
</ItemGroup>
<ItemGroup>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment