Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
22e1cfd8
Commit
22e1cfd8
authored
Dec 13, 2017
by
Jisi Liu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add deprecation annotation for oneof case.
parent
5ce724bc
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
21 additions
and
11 deletions
+21
-11
DeprecatedFieldTest.java
...rc/test/java/com/google/protobuf/DeprecatedFieldTest.java
+14
-6
java_message.cc
src/google/protobuf/compiler/java/java_message.cc
+4
-5
unittest.proto
src/google/protobuf/unittest.proto
+3
-0
No files found.
java/core/src/test/java/com/google/protobuf/DeprecatedFieldTest.java
View file @
22e1cfd8
...
@@ -37,22 +37,22 @@ import junit.framework.TestCase;
...
@@ -37,22 +37,22 @@ import junit.framework.TestCase;
/**
/**
* Test field deprecation
* Test field deprecation
*
*
* @author birdo@google.com (Roberto Scaramuzzi)
* @author birdo@google.com (Roberto Scaramuzzi)
*/
*/
public
class
DeprecatedFieldTest
extends
TestCase
{
public
class
DeprecatedFieldTest
extends
TestCase
{
private
String
[]
deprecatedGetterNames
=
{
private
String
[]
deprecatedGetterNames
=
{
"hasDeprecatedInt32"
,
"hasDeprecatedInt32"
,
"getDeprecatedInt32"
};
"getDeprecatedInt32"
};
private
String
[]
deprecatedBuilderGetterNames
=
{
private
String
[]
deprecatedBuilderGetterNames
=
{
"hasDeprecatedInt32"
,
"hasDeprecatedInt32"
,
"getDeprecatedInt32"
,
"getDeprecatedInt32"
,
"clearDeprecatedInt32"
};
"clearDeprecatedInt32"
};
private
String
[]
deprecatedBuilderSetterNames
=
{
private
String
[]
deprecatedBuilderSetterNames
=
{
"setDeprecatedInt32"
};
"setDeprecatedInt32"
};
public
void
testDeprecatedField
()
throws
Exception
{
public
void
testDeprecatedField
()
throws
Exception
{
Class
<?>
deprecatedFields
=
TestDeprecatedFields
.
class
;
Class
<?>
deprecatedFields
=
TestDeprecatedFields
.
class
;
Class
<?>
deprecatedFieldsBuilder
=
TestDeprecatedFields
.
Builder
.
class
;
Class
<?>
deprecatedFieldsBuilder
=
TestDeprecatedFields
.
Builder
.
class
;
...
@@ -72,7 +72,15 @@ public class DeprecatedFieldTest extends TestCase {
...
@@ -72,7 +72,15 @@ public class DeprecatedFieldTest extends TestCase {
isDeprecated
(
method
));
isDeprecated
(
method
));
}
}
}
}
public
void
testDeprecatedFieldInOneof
()
throws
Exception
{
Class
<?>
oneofCase
=
TestDeprecatedFields
.
OneofFieldsCase
.
class
;
String
name
=
"DEPRECATED_INT32_IN_ONEOF"
;
java
.
lang
.
reflect
.
Field
enumValue
=
oneofCase
.
getField
(
name
);
assertTrue
(
"Enum value "
+
name
+
" should be deprecated."
,
isDeprecated
(
enumValue
));
}
private
boolean
isDeprecated
(
AnnotatedElement
annotated
)
{
private
boolean
isDeprecated
(
AnnotatedElement
annotated
)
{
return
annotated
.
isAnnotationPresent
(
Deprecated
.
class
);
return
annotated
.
isAnnotationPresent
(
Deprecated
.
class
);
}
}
...
...
src/google/protobuf/compiler/java/java_message.cc
View file @
22e1cfd8
...
@@ -437,11 +437,10 @@ void ImmutableMessageGenerator::Generate(io::Printer* printer) {
...
@@ -437,11 +437,10 @@ void ImmutableMessageGenerator::Generate(io::Printer* printer) {
for
(
int
j
=
0
;
j
<
descriptor_
->
oneof_decl
(
i
)
->
field_count
();
j
++
)
{
for
(
int
j
=
0
;
j
<
descriptor_
->
oneof_decl
(
i
)
->
field_count
();
j
++
)
{
const
FieldDescriptor
*
field
=
descriptor_
->
oneof_decl
(
i
)
->
field
(
j
);
const
FieldDescriptor
*
field
=
descriptor_
->
oneof_decl
(
i
)
->
field
(
j
);
printer
->
Print
(
printer
->
Print
(
"$field_name$($field_number$),
\n
"
,
"$deprecation$$field_name$($field_number$),
\n
"
,
"field_name"
,
"deprecation"
,
field
->
options
().
deprecated
()
?
"@java.lang.Deprecated "
:
""
,
ToUpper
(
field
->
name
()),
"field_name"
,
ToUpper
(
field
->
name
()),
"field_number"
,
"field_number"
,
SimpleItoa
(
field
->
number
()));
SimpleItoa
(
field
->
number
()));
}
}
printer
->
Print
(
printer
->
Print
(
"$cap_oneof_name$_NOT_SET(0);
\n
"
,
"$cap_oneof_name$_NOT_SET(0);
\n
"
,
...
...
src/google/protobuf/unittest.proto
View file @
22e1cfd8
...
@@ -189,6 +189,9 @@ message NestedTestAllTypes {
...
@@ -189,6 +189,9 @@ message NestedTestAllTypes {
message
TestDeprecatedFields
{
message
TestDeprecatedFields
{
optional
int32
deprecated_int32
=
1
[
deprecated
=
true
];
optional
int32
deprecated_int32
=
1
[
deprecated
=
true
];
oneof
oneof_fields
{
int32
deprecated_int32_in_oneof
=
2
[
deprecated
=
true
];
}
}
}
message
TestDeprecatedMessage
{
message
TestDeprecatedMessage
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment