Commit 1ce5bd8e authored by Josh Haberman's avatar Josh Haberman

Updates for PR comments.

parent 30a2f70e
...@@ -27,8 +27,9 @@ nodist_generate_datasets_SOURCES = \ ...@@ -27,8 +27,9 @@ nodist_generate_datasets_SOURCES = \
$(benchmarks_protoc_outputs) \ $(benchmarks_protoc_outputs) \
$(benchmarks_protoc_outputs_proto2) $(benchmarks_protoc_outputs_proto2)
# Explicit deps beacuse BUILT_SOURCES are only done before a "make all/check" # Explicit deps because BUILT_SOURCES are only done before a "make all/check"
# so a direct "make test_cpp" could fail if parallel enough. # so a direct "make test_cpp" could fail if parallel enough.
# See: https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html#Recording-Dependencies-manually
generate_datasets-generate_datasets.$(OBJEXT): benchmarks.pb.h google_message1.h google_message2.h generate_datasets-generate_datasets.$(OBJEXT): benchmarks.pb.h google_message1.h google_message2.h
$(benchmarks_protoc_outputs): protoc_middleman $(benchmarks_protoc_outputs): protoc_middleman
......
...@@ -68,16 +68,16 @@ message Metric { ...@@ -68,16 +68,16 @@ message Metric {
// A unique ID for these results. Used for de-duping. // A unique ID for these results. Used for de-duping.
string guid = 1; string guid = 1;
// The tags specify exactly what benchmark was run against the dataset. // The labels specify exactly what benchmark was run against the dataset.
// The specific benchmark suite can decide what these mean, but here are // The specific benchmark suite can decide what these mean, but here are
// some common tags that have a predefined meaning: // some common labels that have a predefined meaning:
// //
// - "dataset": for tests that pertain to a specific dataset. // - "dataset": for tests that pertain to a specific dataset.
// //
// For example: // For example:
// //
// # Tests parsing from binary proto string using arenas. // # Tests parsing from binary proto string using arenas.
// tags={ // labels={
// dataset: "testalltypes", // dataset: "testalltypes",
// op: "parse", // op: "parse",
// format: "binaryproto", // format: "binaryproto",
...@@ -86,7 +86,7 @@ message Metric { ...@@ -86,7 +86,7 @@ message Metric {
// } // }
// //
// # Tests serializing to JSON string. // # Tests serializing to JSON string.
// tags={ // labels={
// dataset: "testalltypes", // dataset: "testalltypes",
// op: "serialize", // op: "serialize",
// format: "json", // format: "json",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment