Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
188f1804
Unverified
Commit
188f1804
authored
Nov 13, 2017
by
Paul Yang
Committed by
GitHub
Nov 13, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
All integer types should accept null in json. (#3869)
parent
fe2b4af3
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
5 deletions
+22
-5
conformance_test.cc
conformance/conformance_test.cc
+16
-0
Message.php
php/src/Google/Protobuf/Internal/Message.php
+6
-5
No files found.
conformance/conformance_test.cc
View file @
188f1804
...
...
@@ -1842,6 +1842,14 @@ bool ConformanceTestSuite::RunSuite(ConformanceTestRunner* runner,
"optionalInt64": null,
"optionalUint32": null,
"optionalUint64": null,
"optionalSint32": null,
"optionalSint64": null,
"optionalFixed32": null,
"optionalFixed64": null,
"optionalSfixed32": null,
"optionalSfixed64": null,
"optionalFloat": null,
"optionalDouble": null,
"optionalBool": null,
"optionalString": null,
"optionalBytes": null,
...
...
@@ -1851,6 +1859,14 @@ bool ConformanceTestSuite::RunSuite(ConformanceTestRunner* runner,
"repeatedInt64": null,
"repeatedUint32": null,
"repeatedUint64": null,
"repeatedSint32": null,
"repeatedSint64": null,
"repeatedFixed32": null,
"repeatedFixed64": null,
"repeatedSfixed32": null,
"repeatedSfixed64": null,
"repeatedFloat": null,
"repeatedDouble": null,
"repeatedBool": null,
"repeatedString": null,
"repeatedBytes": null,
...
...
php/src/Google/Protobuf/Internal/Message.php
View file @
188f1804
...
...
@@ -833,6 +833,8 @@ class Message
}
return
$value
;
case
GPBType
::
INT32
:
case
GPBType
::
SINT32
:
case
GPBType
::
SFIXED32
:
if
(
is_null
(
$value
))
{
return
$this
->
defaultValue
(
$field
);
}
...
...
@@ -850,6 +852,7 @@ class Message
}
return
$value
;
case
GPBType
::
UINT32
:
case
GPBType
::
FIXED32
:
if
(
is_null
(
$value
))
{
return
$this
->
defaultValue
(
$field
);
}
...
...
@@ -863,6 +866,8 @@ class Message
}
return
$value
;
case
GPBType
::
INT64
:
case
GPBType
::
SINT64
:
case
GPBType
::
SFIXED64
:
if
(
is_null
(
$value
))
{
return
$this
->
defaultValue
(
$field
);
}
...
...
@@ -880,6 +885,7 @@ class Message
}
return
$value
;
case
GPBType
::
UINT64
:
case
GPBType
::
FIXED64
:
if
(
is_null
(
$value
))
{
return
$this
->
defaultValue
(
$field
);
}
...
...
@@ -895,11 +901,6 @@ class Message
$value
=
bcsub
(
$value
,
"18446744073709551616"
);
}
return
$value
;
case
GPBType
::
FIXED64
:
if
(
is_null
(
$value
))
{
return
$this
->
defaultValue
(
$field
);
}
return
$value
;
default
:
return
$value
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment