• Nico Weber's avatar
    Remove use of GOOGLE_FALLTHROUGH_INTENDED from protobuf. · c66dd6c2
    Nico Weber authored
    Chrome is running into two issues with the use of this macro
    in open-source protobuf (https://crbug.com/809157):
    
    1. GOOGLE_FALLTHROUGH_INTENDED is defined to nothing on __APPLE__
       platforms, which blocks us from enabling -Wimplicit-fallthrough
       on Mac and iOS. (We use a hermetic self-built modern clang,
       so whatever Xcode bug that exclusion might be for doesn't apply
       to us.)
    
    2. It's in a public header file, and it's included in a public header file.
       When clang suggests adding [[clang::fallthrough]], it checks if it knows of
       a macro expanding to that and if so, suggests inserting that. Since lots of
       chrome code includes protobuf headers, it often suggests inserting
       GOOGLE_FALLTHROUGH_INTENDED (from protobuf) instead of the correct
       FALLTHROUGH (from chrome's base).
    
    Since the fallthrough doens't do anyting useful, just remove it.
    Long ago, this might have had perf impact, but d64a2d99 added a
    parsing fast path that calls this switch as slow fallback, so it should
    be off the hot path nowadays.
    
    No intended behavior change.
    
    This is the public version of internal change 184824132.
    c66dd6c2
port.h 15.7 KB