• Zhigang Gong's avatar
    fix potential race condition in canny.cl. · 0b08d255
    Zhigang Gong authored
    See the below code snippet:
    
    while(l_counter != 0)
    {
        int mod = l_counter % LOCAL_TOTAL;
        int pix_per_thr = l_counter / LOCAL_TOTAL + ((lid < mod) ? 1 : 0);
    
        for (int i = 0; i < pix_per_thr; ++i)
        {
            int index = atomic_dec(&l_counter) - 1;
            ....
        }
        ....
        barrier(CLK_LOCAL_MEM_FENCE);
    }
    
    If we don't put a barrier before the for loop, then there is a possiblity
    that some work item enter this loop but the others are not, the the l_counter
    will be reduced in the for loop and may be changed to zero, and the other
    work items may can't enter the while loop. If this happens, it breaks the
    barrier's rule which requires all the work items reach the same barrier.
    And it may hang the GPU depends on the implementation of opencl platform.
    
    This issue is raised at:
    https://github.com/Itseez/opencv/issues/5175Signed-off-by: 's avatarZhigang Gong <zhigang.gong@linux.intel.com>
    0b08d255
Name
Last commit
Last update
.github Loading commit data...
3rdparty Loading commit data...
apps Loading commit data...
cmake Loading commit data...
data Loading commit data...
doc Loading commit data...
include Loading commit data...
modules Loading commit data...
platforms Loading commit data...
samples Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.tgitconfig Loading commit data...
CMakeLists.txt Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...