1. 20 Mar, 2015 2 commits
    • Vadim Pisarevsky's avatar
    • Owen Healy's avatar
      Fix bug of uninitialized matrix in findTransformECC · ff48387a
      Owen Healy authored
      The matrix templateZM needs to be initialized because otherwise
      uninitialized values leak into the correlation in:
      
          const double correlation = templateZM.dot(imageWarped)
      
      In the worst case this will lead the correlation to be NaN ruining the
      whole routine. The subtraction does not initialize templateZM due to the
      mask.
      
      Unfortunately, the uninitialized values (by altering the correlation)
      have the side effect of dragging out the computation a little longer
      giving a slightly better error bound. This means that fixing this bug
      breaks perf_ecc where
      
          SANITY_CHECK(warpMat, 1e-3);
      
      is just a little too tight and happens to work due to the uninitialized
      values. Since this is a performance not a accuracy test I think it is OK
      to just relax the error bound a little bit (the tight error bound being
      after all the result of a bug).
      ff48387a
  2. 19 Mar, 2015 4 commits
  3. 18 Mar, 2015 1 commit
  4. 17 Mar, 2015 7 commits
  5. 16 Mar, 2015 9 commits
  6. 14 Mar, 2015 4 commits
  7. 13 Mar, 2015 9 commits
  8. 12 Mar, 2015 4 commits