Fix racy modification of ForThread::m_state during invocation of stop()

f260b13a · grundman · 37ce3b8c · f260b13a
Commit f260b13a authored Oct 16, 2015 by grundman
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

parallel_pthreads.cpp modules/core/src/parallel_pthreads.cpp +4 -0

No files found.
--- a/modules/core/src/parallel_pthreads.cpp
+++ b/modules/core/src/parallel_pthreads.cpp
@@ -304,14 +304,18 @@ void ForThread::stop()
 {
    if(m_state == eFTStarted)
    {
+        pthread_mutex_lock(&m_thread_mutex);
        m_state = eFTToStop;
+        pthread_mutex_unlock(&m_thread_mutex);

        run();

        pthread_join(m_posix_thread, NULL);
    }

+    pthread_mutex_lock(&m_thread_mutex);
    m_state = eFTStoped;
+    pthread_mutex_unlock(&m_thread_mutex);
 }

 void ForThread::run()