Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
O
opencv
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
opencv
Commits
df8b057b
Commit
df8b057b
authored
Sep 08, 2018
by
Alexander Alekhin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
avoid `Ptr<> == NULL` checks
parent
64b3c1e6
Show whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
14 additions
and
21 deletions
+14
-21
lut.cpp
modules/core/src/lut.cpp
+5
-12
persistence_cpp.cpp
modules/core/src/persistence_cpp.cpp
+1
-1
test_io.cpp
modules/core/test/test_io.cpp
+3
-3
ocl4dnn_conv_spatial.cpp
modules/dnn/src/ocl4dnn/src/ocl4dnn_conv_spatial.cpp
+1
-1
test_mltests2.cpp
modules/ml/test/test_mltests2.cpp
+2
-2
detect_blob.cpp
samples/cpp/detect_blob.cpp
+1
-1
detect_mser.cpp
samples/cpp/detect_mser.cpp
+1
-1
No files found.
modules/core/src/lut.cpp
View file @
df8b057b
...
@@ -384,21 +384,14 @@ void cv::LUT( InputArray _src, InputArray _lut, OutputArray _dst )
...
@@ -384,21 +384,14 @@ void cv::LUT( InputArray _src, InputArray _lut, OutputArray _dst )
if
(
_src
.
dims
()
<=
2
)
if
(
_src
.
dims
()
<=
2
)
{
{
bool
ok
=
false
;
bool
ok
=
false
;
Ptr
<
ParallelLoopBody
>
body
;
LUTParallelBody
body
(
src
,
lut
,
dst
,
&
ok
);
if
(
ok
)
if
(
body
==
NULL
||
ok
==
false
)
{
ok
=
false
;
ParallelLoopBody
*
p
=
new
LUTParallelBody
(
src
,
lut
,
dst
,
&
ok
);
body
.
reset
(
p
);
}
if
(
body
!=
NULL
&&
ok
)
{
{
Range
all
(
0
,
dst
.
rows
);
Range
all
(
0
,
dst
.
rows
);
if
(
dst
.
total
()
>>
18
)
if
(
dst
.
total
()
>=
(
size_t
)(
1
<<
18
)
)
parallel_for_
(
all
,
*
body
,
(
double
)
std
::
max
((
size_t
)
1
,
dst
.
total
()
>>
16
));
parallel_for_
(
all
,
body
,
(
double
)
std
::
max
((
size_t
)
1
,
dst
.
total
()
>>
16
));
else
else
(
*
body
)
(
all
);
body
(
all
);
if
(
ok
)
if
(
ok
)
return
;
return
;
}
}
...
...
modules/core/src/persistence_cpp.cpp
View file @
df8b057b
...
@@ -537,7 +537,7 @@ void read( const FileNode& node, SparseMat& mat, const SparseMat& default_mat )
...
@@ -537,7 +537,7 @@ void read( const FileNode& node, SparseMat& mat, const SparseMat& default_mat )
return
;
return
;
}
}
Ptr
<
CvSparseMat
>
m
((
CvSparseMat
*
)
cvRead
((
CvFileStorage
*
)
node
.
fs
,
(
CvFileNode
*
)
*
node
));
Ptr
<
CvSparseMat
>
m
((
CvSparseMat
*
)
cvRead
((
CvFileStorage
*
)
node
.
fs
,
(
CvFileNode
*
)
*
node
));
CV_Assert
(
CV_IS_SPARSE_MAT
(
m
));
CV_Assert
(
CV_IS_SPARSE_MAT
(
m
.
get
()
));
m
->
copyToSparseMat
(
mat
);
m
->
copyToSparseMat
(
mat
);
}
}
...
...
modules/core/test/test_io.cpp
View file @
df8b057b
...
@@ -288,9 +288,9 @@ protected:
...
@@ -288,9 +288,9 @@ protected:
fs
[
"test_sparse_mat"
]
>>
m_s2
;
fs
[
"test_sparse_mat"
]
>>
m_s2
;
Ptr
<
CvSparseMat
>
_m_s2
(
cvCreateSparseMat
(
m_s2
));
Ptr
<
CvSparseMat
>
_m_s2
(
cvCreateSparseMat
(
m_s2
));
if
(
!
m_s
||
!
CV_IS_SPARSE_MAT
(
m_s
)
||
if
(
!
m_s
||
!
CV_IS_SPARSE_MAT
(
m_s
.
get
()
)
||
!
cvTsCheckSparse
(
m_s
,
_test_sparse
,
0
)
||
!
cvTsCheckSparse
(
m_s
.
get
(),
_test_sparse
.
get
()
,
0
)
||
!
cvTsCheckSparse
(
_m_s2
,
_test_sparse
,
0
))
!
cvTsCheckSparse
(
_m_s2
.
get
(),
_test_sparse
.
get
()
,
0
))
{
{
ts
->
printf
(
cvtest
::
TS
::
LOG
,
"the read sparse matrix is not correct
\n
"
);
ts
->
printf
(
cvtest
::
TS
::
LOG
,
"the read sparse matrix is not correct
\n
"
);
ts
->
set_failed_test_info
(
cvtest
::
TS
::
FAIL_INVALID_OUTPUT
);
ts
->
set_failed_test_info
(
cvtest
::
TS
::
FAIL_INVALID_OUTPUT
);
...
...
modules/dnn/src/ocl4dnn/src/ocl4dnn_conv_spatial.cpp
View file @
df8b057b
...
@@ -1820,7 +1820,7 @@ void OCL4DNNConvSpatial<Dtype>::prepareKernel(const UMat &bottom, UMat &top,
...
@@ -1820,7 +1820,7 @@ void OCL4DNNConvSpatial<Dtype>::prepareKernel(const UMat &bottom, UMat &top,
std
::
string
previous_key
=
key_
;
std
::
string
previous_key
=
key_
;
generateKey
();
generateKey
();
if
(
key_
.
compare
(
previous_key
)
==
0
&&
bestKernelConfig
!=
NULL
)
if
(
key_
.
compare
(
previous_key
)
==
0
&&
bestKernelConfig
)
return
;
return
;
if
(
bestKernelConfig
)
if
(
bestKernelConfig
)
...
...
modules/ml/test/test_mltests2.cpp
View file @
df8b057b
...
@@ -237,7 +237,7 @@ TEST(ML_ANN, ActivationFunction)
...
@@ -237,7 +237,7 @@ TEST(ML_ANN, ActivationFunction)
x
->
save
(
dataname
+
activationName
[
i
]
+
".yml"
);
x
->
save
(
dataname
+
activationName
[
i
]
+
".yml"
);
#else
#else
Ptr
<
ml
::
ANN_MLP
>
y
=
Algorithm
::
load
<
ANN_MLP
>
(
dataname
+
activationName
[
i
]
+
".yml"
);
Ptr
<
ml
::
ANN_MLP
>
y
=
Algorithm
::
load
<
ANN_MLP
>
(
dataname
+
activationName
[
i
]
+
".yml"
);
ASSERT_TRUE
(
y
!=
NULL
)
<<
"Could not load "
<<
dataname
+
activationName
[
i
]
+
".yml"
;
ASSERT_TRUE
(
y
)
<<
"Could not load "
<<
dataname
+
activationName
[
i
]
+
".yml"
;
Mat
testSamples
=
tdata
->
getTestSamples
();
Mat
testSamples
=
tdata
->
getTestSamples
();
Mat
rx
,
ry
,
dst
;
Mat
rx
,
ry
,
dst
;
x
->
predict
(
testSamples
,
rx
);
x
->
predict
(
testSamples
,
rx
);
...
@@ -330,7 +330,7 @@ TEST_P(ML_ANN_METHOD, Test)
...
@@ -330,7 +330,7 @@ TEST_P(ML_ANN_METHOD, Test)
#endif
#endif
ASSERT_FALSE
(
r_gold
.
empty
());
ASSERT_FALSE
(
r_gold
.
empty
());
Ptr
<
ml
::
ANN_MLP
>
y
=
Algorithm
::
load
<
ANN_MLP
>
(
filename
);
Ptr
<
ml
::
ANN_MLP
>
y
=
Algorithm
::
load
<
ANN_MLP
>
(
filename
);
ASSERT_TRUE
(
y
!=
NULL
)
<<
"Could not load "
<<
filename
;
ASSERT_TRUE
(
y
)
<<
"Could not load "
<<
filename
;
Mat
rx
,
ry
;
Mat
rx
,
ry
;
for
(
int
j
=
0
;
j
<
4
;
j
++
)
for
(
int
j
=
0
;
j
<
4
;
j
++
)
{
{
...
...
samples/cpp/detect_blob.cpp
View file @
df8b057b
...
@@ -178,7 +178,7 @@ int main(int argc, char *argv[])
...
@@ -178,7 +178,7 @@ int main(int argc, char *argv[])
vector
<
Rect
>
zone
;
vector
<
Rect
>
zone
;
vector
<
vector
<
Point
>
>
region
;
vector
<
vector
<
Point
>
>
region
;
Mat
desc
,
result
(
img
.
rows
,
img
.
cols
,
CV_8UC3
);
Mat
desc
,
result
(
img
.
rows
,
img
.
cols
,
CV_8UC3
);
if
(
b
.
dynamicCast
<
SimpleBlobDetector
>
()
!=
NULL
)
if
(
b
.
dynamicCast
<
SimpleBlobDetector
>
()
.
get
()
)
{
{
Ptr
<
SimpleBlobDetector
>
sbd
=
b
.
dynamicCast
<
SimpleBlobDetector
>
();
Ptr
<
SimpleBlobDetector
>
sbd
=
b
.
dynamicCast
<
SimpleBlobDetector
>
();
sbd
->
detect
(
img
,
keyImg
,
Mat
());
sbd
->
detect
(
img
,
keyImg
,
Mat
());
...
...
samples/cpp/detect_mser.cpp
View file @
df8b057b
...
@@ -500,7 +500,7 @@ int main(int argc, char *argv[])
...
@@ -500,7 +500,7 @@ int main(int argc, char *argv[])
vector
<
vector
<
Point
>
>
region
;
vector
<
vector
<
Point
>
>
region
;
Mat
desc
;
Mat
desc
;
if
(
b
.
dynamicCast
<
MSER
>
()
!=
NULL
)
if
(
b
.
dynamicCast
<
MSER
>
()
.
get
()
)
{
{
Ptr
<
MSER
>
sbd
=
b
.
dynamicCast
<
MSER
>
();
Ptr
<
MSER
>
sbd
=
b
.
dynamicCast
<
MSER
>
();
sbd
->
detectRegions
(
img
,
region
,
zone
);
sbd
->
detectRegions
(
img
,
region
,
zone
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment