Changes made to the Maven build process:

* Introduced OSGi Blueprint XML file and Bean class too automatically load the native library.

* Introduced integration testing module to deploy to Karaf OSGi implementation.

* Clears library executable stack flag during build.

* Updated README document.

modules/java/generator/src/java/osgi+OpenCVInterface.java

+package org.opencv.osgi;
+
+/**
+ * Dummy interface to allow some integration testing within OSGi implementation.
+ */
+public interface OpenCVInterface
+{
+}

modules/java/generator/src/java/osgi+OpenCVNativeLoader.java

+package org.opencv.osgi;
+
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+/**
+ * This class is intended to provide a convenient way to load OpenCV's native
+ * library from the Java bundle. If Blueprint is enabled in the OSGi container
+ * this class will be instantiated automatically and the init() method called
+ * loading the native library.
+ */
+public class OpenCVNativeLoader implements OpenCVInterface {
+
+    public void init() {
+        System.loadLibrary("opencv_java320");
+        Logger.getLogger("org.opencv.osgi").log(Level.INFO, "Successfully loaded OpenCV native library.");
+    }
+}

platforms/maven/README.md

@@ -4,16 +4,24 @@ This page describes the how to build OpenCV using [Apache Maven](http://maven.ap
 
 The following assumes building on Debian-based Linux platform.
 
-## Overview
+## 1 - Overview
 The Maven build process aims to:
   1. Provide a simpler route to build OpenCV and Java bundles.
   2. Automatically check the required native dependencies.
   3. Make the Java libraries OSGi compatible.
   4. Include the native OpenCV native library inside the Java bundle.
-  5. Allow the build to function on x86, x86_64 or amd architectures, Debian-based Linux platform.
+  5. Integration testing of the bundle within an OSGi environment.
+  6. Allow the build to function on x86, x86_64 or amd architectures, Debian-based Linux platform.
 
-### Starting the build
-#### Environment variables
+### 2 - Preparing The Build environment
+To build using the Maven build process both `Maven` and and up-to-date `JDK` (Java Development Kit) need to be installed. If you know you already have these installed then continue to `Environment Variable` otherwise the easiest solution is to install them using the aptitude package manager:
+
+`sudo aptitude install maven default-jdk`
+
+Note that installing via `aptitude` you are unlikely to get the latest version of Maven or JDK although if you are not developing Java code this shouldn't matter for this build process.
+
+### 3 - Starting the build
+#### 3.1 - Environment variables
 **Applicability:** All processors.
 
    The following environment variables must be set otherwise the build will fail and halt:
@@ -28,37 +36,36 @@ It is recommended that advantage is taken of multiple processor cores to reduce
 However if this flag is not set the build will NOT fail. On a RaspberryPi 2 typical build times are 5 hours with `-j1` (which is the default if `$MAKEFLAGS` is not specified) and a little over 2 hours with `-j4`.
 
 All of the above environment variables can be set on an ad-hoc basis using 'export'.
-#### Build Directory
+#### 3.2 - Build Directory
 **Applicability:** All processors
 
 By default the following build directories are created.
 
 `<OpenCV_root_dir>/build`
 
-`<OpenCV_root_dir>/build/target`
+`<OpenCV_root_dir>/build/maven/opencv/target`
 
-Under `build` are the standard OpenCV artifacts. Under `build/target` can be found the OSGi compatible Java bundle. When deploying the bundle into an OSGi framework e.g. [Apache Karaf](http://karaf.apache.org/), loading of the native library is automatically taken care of. The standard Java library as created by the CMake process is also available as specified in the existing OpenCV documentation.
+`<OpenCV_root_dir>/build/maven/opencv-it/target`
+
+Under `build` are the standard OpenCV artifacts. Under `build/maven/opencv/target` can be found the OSGi compatible Java bundle. When deploying the bundle into an OSGi framework e.g. [Apache Karaf](http://karaf.apache.org/), loading of the native library is automatically taken care of. An integration testing module is created under the `open-cv` directory and is only of use during the build. The standard Java library as created by the CMake process is also available as specified in the existing OpenCV documentation.
 
 The Maven build is initiated from the directory contain the `pom.xml` file.
-#### x86 or x86_64 Architecture:
+#### 3.3 - x86 or x86_64 Architecture:
 Generally all that is required is the standard Maven command:
 
-`mvn clean install`
+`mvn clean install -Ddownload.cmake=false`
 
 One of the first things the build will do is check the required native dependencies. The Maven build indicates the status of the required dependencies and will fail at this point if any are missing. Install using the package manager e.g. aptitude or apt-get, and restart the build with the above command.
 
 Once the build succesfully completes the OSGi compatible artifacts are available as described above in 'Build Directory'.
 
-#### ARM 32-bit Architecture - Raspbian Distribution
+#### 3.4 - ARM 32-bit Architecture - Raspbian Distribution
 Similar to the x86 architecture the native dependencies are first checked so install any that are missing, however at the time of writing there are no official `libtbb2` and `libtbb-dev` packages in Raspbian. Version 4.4.3 of Intel's Thread Building Blocks library are available [here](http://www.javatechnics.com/thread-building-blocks-tbb-4-4-3-for-raspbian) as a Raspbian-compatible Debian packages.
 
 **PLEASE NOTE THESE ARE NOT OFFICIAL RASPBIAN PACKAGES. INSTALL AT YOUR OWN RISK.**
 
 OpenCV is built using CMake and the Maven build process uses the the [cmake-maven plugin](https://github.com/cmake-maven-project/cmake-maven-project). The cmake-maven plugin by default downloads CMake at build time but unfortunately there is no binary for ARM architecture currently available. As a work around it is possible to use the native CMake (which is checked for availability in the above dependency checks). Assuming all native dependencies are available the build can be started with the following command:
 
-`mvn clean install -Duse.native.cmake=true`
+`mvn clean install -Ddownload.cmake=false`
 
 Upon a successful build the libraries will be available as described above in 'Build Directory'.
-
-#### cmake-mave-plugin 3.4.1-b2-SNAPSHOT
-Should this plugin not be available in Maven central, the source can be found at my GitHub page [here](https://github.com/jtkb/cmake-maven-project), checkout the `raspberrypi` branch and install. On x86 it is a standard Maven build and install command. If building on Raspbian you also need to supply the `-Duse.native.cmake=true` command-line option.

platforms/maven/opencv-it/pom.xml

+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.opencv</groupId>
+        <artifactId>opencv-parent</artifactId>
+        <version>3.2.0</version>
+    </parent>
+    <groupId>org.opencv</groupId>
+    <artifactId>opencv-it</artifactId>
+    <name>OpenCV Integration Test</name>
+    <dependencies>
+        <dependency>
+            <groupId>org.ops4j.pax.exam</groupId>
+            <artifactId>pax-exam-container-karaf</artifactId>
+            <version>${pax.exam.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.ops4j.pax.exam</groupId>
+            <artifactId>pax-exam-junit4</artifactId>
+            <version>${pax.exam.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.geronimo.specs</groupId>
+            <artifactId>geronimo-atinject_1.0_spec</artifactId>
+            <version>1.0</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.ops4j.pax.url</groupId>
+            <artifactId>pax-url-aether</artifactId>
+            <version>1.6.0</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.osgi</groupId>
+            <artifactId>org.osgi.core</artifactId>
+            <version>4.3.1</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.osgi</groupId>
+            <artifactId>org.osgi.compendium</artifactId>
+            <version>4.3.0</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-api</artifactId>
+            <version>1.7.24</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-simple</artifactId>
+            <version>1.7.24</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <artifactId>org.apache.karaf.log.core</artifactId>
+            <groupId>org.apache.karaf.log</groupId>
+            <version>4.0.6</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.ops4j.pax.logging</groupId>
+            <artifactId>pax-logging-api</artifactId>
+            <version>1.8.0</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>4.8.1</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>opencv</artifactId>
+            <version>${project.version}</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
+    <build>
+        <directory>../../../build/maven/opencv-it/target</directory>
+        <testSourceDirectory>src/test/java</testSourceDirectory>
+        <testOutputDirectory>../../../build/maven/opencv-it/target</testOutputDirectory>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <version>2.15</version>
+            </plugin>
+        </plugins>
+    </build>
+</project>

platforms/maven/opencv-it/src/test/java/org/opencv/osgi/DeployOpenCVTest.java

+package org.opencv.osgi;
+
+import java.io.File;
+import javax.inject.Inject;
+import junit.framework.TestCase;
+import org.apache.karaf.log.core.LogService;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.ops4j.pax.exam.Configuration;
+import static org.ops4j.pax.exam.CoreOptions.maven;
+import static org.ops4j.pax.exam.CoreOptions.mavenBundle;
+import org.ops4j.pax.exam.Option;
+import org.ops4j.pax.exam.junit.PaxExam;
+import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.karafDistributionConfiguration;
+import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.keepRuntimeFolder;
+import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.logLevel;
+import org.ops4j.pax.exam.karaf.options.LogLevelOption;
+import org.ops4j.pax.exam.options.MavenArtifactUrlReference;
+import org.ops4j.pax.exam.spi.reactors.ExamReactorStrategy;
+import org.ops4j.pax.exam.spi.reactors.PerClass;
+import org.ops4j.pax.logging.spi.PaxLoggingEvent;
+import org.osgi.framework.BundleContext;
+
+/**
+ *
+ * @author Kerry Billingham <contact@AvionicEngineers.com>
+ */
+@ExamReactorStrategy(PerClass.class)
+@RunWith(PaxExam.class)
+public class DeployOpenCVTest {
+
+    /*
+    The expected string in Karaf logs when the bundle has deployed and native library loaded.
+    */
+    private static final String OPEN_CV_SUCCESSFUL_LOAD_STRING = "Successfully loaded OpenCV native library.";
+
+    private static final String KARAF_VERSION = "4.0.6";
+
+    @Inject
+    protected BundleContext bundleContext;
+
+    @Inject
+    private LogService logService;
+
+    /*
+    This service is required to ensure that the native library has been loaded
+    before any test is carried out.
+    */
+    @Inject
+    private OpenCVInterface openCVInterface;
+
+    @Configuration
+    public static Option[] configuration() throws Exception {
+        MavenArtifactUrlReference karafUrl = maven()
+                .groupId("org.apache.karaf")
+                .artifactId("apache-karaf")
+                .version(KARAF_VERSION)
+                .type("tar.gz");
+        return new Option[]{
+            karafDistributionConfiguration()
+            .frameworkUrl(karafUrl)
+            .unpackDirectory(new File("../../../build/target/exam"))
+            .useDeployFolder(false),
+            keepRuntimeFolder(),
+            mavenBundle()
+            .groupId("org.opencv")
+            .artifactId("opencv")
+            .version("3.2.0"),
+            logLevel(LogLevelOption.LogLevel.INFO)
+        };
+    }
+
+    /**
+     * Tests that the OpenCV bundle has been successfully deployed and that the
+     * native library has been loaded.
+     */
+    @Test
+    public void testOpenCVNativeLibraryLoadSuccess() {
+
+        Iterable<PaxLoggingEvent> loggingEvents = logService.getEvents();
+        boolean loadSuccessful = logsContainsMessage(loggingEvents, OPEN_CV_SUCCESSFUL_LOAD_STRING);
+
+        TestCase.assertTrue("Could not determine if OpenCV library successfully loaded from the logs.", loadSuccessful);
+
+    }
+
+    private boolean logsContainsMessage(Iterable<PaxLoggingEvent> logEnumeration, final String logMessageString) {
+        boolean contains = false;
+        for (PaxLoggingEvent logEntry : logEnumeration) {
+            if (logEntry.getMessage().contains(logMessageString)) {
+                contains = true;
+                break;
+            }
+        }
+        return contains;
+    }
+}

platforms/maven/opencv/resources/OSGI-INF/blueprint/blueprint.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<blueprint
+    xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'
+    xmlns='http://www.osgi.org/xmlns/blueprint/v1.0.0'
+    xsi:schemaLocation='http://www.osgi.org/xmlns/blueprint/v1.0.0 https://osgi.org/xmlns/blueprint/v1.0.0/blueprint.xsd'>
+
+    <bean id="opencvnativeloader" class="org.opencv.osgi.OpenCVNativeLoader" scope="singleton" init-method="init" />
+
+    <service id="opencvtestservice" ref="opencvnativeloader" interface="org.opencv.osgi.OpenCVInterface" />
+
+</blueprint>

platforms/maven/opencv/scripts/execstack_check

+#!/bin/bash
+
+##################################################################
+#
+#	This script will clear the executable flag on
+#	the specified library and then check it has
+#	been cleared as a separate operation.
+#
+#	$1 - The absolute path to the OpenCV native library.
+#
+#	Returns:
+#	0 - The executable flag has been cleared
+#	1 - The executable flag could NOT be cleared (failure).
+#
+#   Kerry Billingham <contact (at) avionicengineers (d0t) com>
+#   11 March 2017
+#
+##################################################################
+red=$'\e[1;31m'
+green=$'\e[1;32m'
+end=$'\e[0m'
+echo "${green}[INFO] Checking that the native library executable stack flag is NOT set.${end}"
+execstack -c $1
+execstack -q $1 | grep -o ^-
+if [ $? -ne 0 ]; then
+    echo
+    echo "${red}[ERROR] The Executable Flag could not be cleared on the library $1.${end}"
+    exit 1
+fi
+exit 0