Commit 3ec0e094 authored by Andreas Stührk's avatar Andreas Stührk Committed by Dikay900

TIFF loader: Allocate large enough buffer when (bpp * ncn) > 8.

Conflicts:
	modules/highgui/src/grfmt_tiff.cpp

floodfill return value removed
parent 653810e4
...@@ -247,7 +247,8 @@ bool TiffDecoder::readData( Mat& img ) ...@@ -247,7 +247,8 @@ bool TiffDecoder::readData( Mat& img )
(!is_tiled && tile_height0 == std::numeric_limits<uint32>::max()) ) (!is_tiled && tile_height0 == std::numeric_limits<uint32>::max()) )
tile_height0 = m_height; tile_height0 = m_height;
AutoBuffer<uchar> _buffer( size_t(8) * tile_height0*tile_width0); const size_t buffer_size = bpp * ncn * tile_height0 * tile_width0;
AutoBuffer<uchar> _buffer( buffer_size );
uchar* buffer = _buffer; uchar* buffer = _buffer;
ushort* buffer16 = (ushort*)buffer; ushort* buffer16 = (ushort*)buffer;
float* buffer32 = (float*)buffer; float* buffer32 = (float*)buffer;
...@@ -313,9 +314,9 @@ bool TiffDecoder::readData( Mat& img ) ...@@ -313,9 +314,9 @@ bool TiffDecoder::readData( Mat& img )
case 16: case 16:
{ {
if( !is_tiled ) if( !is_tiled )
ok = (int)TIFFReadEncodedStrip( tif, tileidx, (uint32*)buffer, (tsize_t)-1 ) >= 0; ok = (int)TIFFReadEncodedStrip( tif, tileidx, (uint32*)buffer, buffer_size ) >= 0;
else else
ok = (int)TIFFReadEncodedTile( tif, tileidx, (uint32*)buffer, (tsize_t)-1 ) >= 0; ok = (int)TIFFReadEncodedTile( tif, tileidx, (uint32*)buffer, buffer_size ) >= 0;
if( !ok ) if( !ok )
{ {
...@@ -384,9 +385,9 @@ bool TiffDecoder::readData( Mat& img ) ...@@ -384,9 +385,9 @@ bool TiffDecoder::readData( Mat& img )
case 64: case 64:
{ {
if( !is_tiled ) if( !is_tiled )
ok = (int)TIFFReadEncodedStrip( tif, tileidx, buffer, (tsize_t)-1 ) >= 0; ok = (int)TIFFReadEncodedStrip( tif, tileidx, buffer, buffer_size ) >= 0;
else else
ok = (int)TIFFReadEncodedTile( tif, tileidx, buffer, (tsize_t)-1 ) >= 0; ok = (int)TIFFReadEncodedTile( tif, tileidx, buffer, buffer_size ) >= 0;
if( !ok || ncn != 1 ) if( !ok || ncn != 1 )
{ {
......
...@@ -487,7 +487,6 @@ int cv::floodFill( InputOutputArray _image, InputOutputArray _mask, ...@@ -487,7 +487,6 @@ int cv::floodFill( InputOutputArray _image, InputOutputArray _mask,
if ( (cn != 1) && (cn != 3) ) if ( (cn != 1) && (cn != 3) )
{ {
CV_Error( CV_StsBadArg, "Number of channels in input image must be 1 or 3" ); CV_Error( CV_StsBadArg, "Number of channels in input image must be 1 or 3" );
return;
} }
if( connectivity == 0 ) if( connectivity == 0 )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment