Commit 3be51ded authored by Alexey Spizhevoy's avatar Alexey Spizhevoy

fixed typo in opencv_stitching

parent 0ec452c1
...@@ -38,80 +38,80 @@ ...@@ -38,80 +38,80 @@
// or tort (including negligence or otherwise) arising in any way out of // or tort (including negligence or otherwise) arising in any way out of
// the use of this software, even if advised of the possibility of such damage. // the use of this software, even if advised of the possibility of such damage.
// //
//M*/ //M*/
#include "autocalib.hpp" #include "autocalib.hpp"
#include "util.hpp" #include "util.hpp"
using namespace std; using namespace std;
using namespace cv; using namespace cv;
void focalsFromHomography(const Mat& H, double &f0, double &f1, bool &f0_ok, bool &f1_ok) void focalsFromHomography(const Mat& H, double &f0, double &f1, bool &f0_ok, bool &f1_ok)
{ {
CV_Assert(H.type() == CV_64F && H.size() == Size(3, 3)); CV_Assert(H.type() == CV_64F && H.size() == Size(3, 3));
const double* h = reinterpret_cast<const double*>(H.data); const double* h = reinterpret_cast<const double*>(H.data);
double d1, d2; // Denominators double d1, d2; // Denominators
double v1, v2; // Focal squares value candidates double v1, v2; // Focal squares value candidates
f1_ok = true; f1_ok = true;
d1 = h[6] * h[7]; d1 = h[6] * h[7];
d2 = (h[7] - h[6]) * (h[7] + h[6]); d2 = (h[7] - h[6]) * (h[7] + h[6]);
v1 = -(h[0] * h[1] + h[3] * h[4]) / d1; v1 = -(h[0] * h[1] + h[3] * h[4]) / d1;
v2 = (h[0] * h[0] + h[3] * h[3] - h[1] * h[1] - h[4] * h[4]) / d2; v2 = (h[0] * h[0] + h[3] * h[3] - h[1] * h[1] - h[4] * h[4]) / d2;
if (v1 < v2) swap(v1, v2); if (v1 < v2) swap(v1, v2);
if (v1 > 0 && v2 > 0) f1 = sqrt(abs(d1) > abs(d2) ? v1 : v2); if (v1 > 0 && v2 > 0) f1 = sqrt(abs(d1) > abs(d2) ? v1 : v2);
else if (v1 > 0) f1 = sqrt(v1); else if (v1 > 0) f1 = sqrt(v1);
else f1_ok = false; else f1_ok = false;
f0_ok = true; f0_ok = true;
d1 = h[0] * h[3] + h[1] * h[4]; d1 = h[0] * h[3] + h[1] * h[4];
d2 = h[0] * h[0] + h[1] * h[1] - h[3] * h[3] - h[4] * h[4]; d2 = h[0] * h[0] + h[1] * h[1] - h[3] * h[3] - h[4] * h[4];
v1 = -h[2] * h[5] / d1; v1 = -h[2] * h[5] / d1;
v2 = (h[5] * h[5] - h[2] * h[2]) / d2; v2 = (h[5] * h[5] - h[2] * h[2]) / d2;
if (v1 < v2) swap(v1, v2); if (v1 < v2) swap(v1, v2);
if (v1 > 0 && v2 > 0) f0 = sqrt(abs(d1) > abs(d2) ? v1 : v2); if (v1 > 0 && v2 > 0) f0 = sqrt(abs(d1) > abs(d2) ? v1 : v2);
else if (v1 > 0) f0 = sqrt(v1); else if (v1 > 0) f0 = sqrt(v1);
else f0_ok = false; else f0_ok = false;
} }
void estimateFocal(const vector<ImageFeatures> &features, const vector<MatchesInfo> &pairwise_matches, void estimateFocal(const vector<ImageFeatures> &features, const vector<MatchesInfo> &pairwise_matches,
vector<double> &focals) vector<double> &focals)
{ {
const int num_images = static_cast<int>(features.size()); const int num_images = static_cast<int>(features.size());
focals.resize(num_images); focals.resize(num_images);
vector<double> all_focals; vector<double> all_focals;
for (int i = 0; i < num_images; ++i) for (int i = 0; i < num_images; ++i)
{ {
for (int j = 0; j < num_images; ++j) for (int j = 0; j < num_images; ++j)
{ {
const MatchesInfo &m = pairwise_matches[i*num_images + j]; const MatchesInfo &m = pairwise_matches[i*num_images + j];
if (m.H.empty()) if (m.H.empty())
continue; continue;
double f0, f1; double f0, f1;
bool f0ok, f1ok; bool f0ok, f1ok;
focalsFromHomography(m.H, f0, f1, f0ok, f1ok); focalsFromHomography(m.H, f0, f1, f0ok, f1ok);
if (f0ok && f1ok) if (f0ok && f1ok)
all_focals.push_back(sqrt(f0 * f1)); all_focals.push_back(sqrt(f0 * f1));
} }
} }
if (static_cast<int>(all_focals.size()) < num_images - 1) if (static_cast<int>(all_focals.size()) >= num_images - 1)
{ {
LOGLN("Can't estimate focal length, will use anaive approach"); nth_element(all_focals.begin(), all_focals.begin() + all_focals.size()/2, all_focals.end());
double focals_sum = 0; for (int i = 0; i < num_images; ++i)
for (int i = 0; i < num_images; ++i) focals[i] = all_focals[all_focals.size()/2];
focals_sum += features[i].img_size.width + features[i].img_size.height; }
for (int i = 0; i < num_images; ++i) else
focals[i] = focals_sum / num_images; {
} LOGLN("Can't estimate focal length, will use naive approach");
else double focals_sum = 0;
{ for (int i = 0; i < num_images; ++i)
nth_element(all_focals.begin(), all_focals.begin() + all_focals.size()/2, all_focals.end()); focals_sum += features[i].img_size.width + features[i].img_size.height;
for (int i = 0; i < num_images; ++i) for (int i = 0; i < num_images; ++i)
focals[i] = all_focals[all_focals.size()/2]; focals[i] = focals_sum / num_images;
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment