Commit 2be805ce authored by Anatoly Orlov's avatar Anatoly Orlov

kalman.py was broken totally

1. Following condition is True on each iteration becuase -1 % 0xFF is 255 not -1

code = cv2.waitKey(100) % 0x100
if code != -1:
   break

this were resetting point position on each cycle not on key press as intended

2. Previous small bug were masking serious bug with matrix operation on matrices of incorrect size.
   As the result on 2nd iteration of internal cycle program has crushed.

   I have fixed it too, matrix operation was taken from examples/cpp/kalman.cpp where it looks like
   randn( processNoise, Scalar(0), Scalar::all(sqrt(KF.processNoiseCov.at<float>(0, 0))));
   which is something totally different from previous code here.

   Example behave as it should now, i.e. point moving by circle trajectory as in C++ example.
parent ff0d1158
......@@ -19,7 +19,7 @@ if PY3:
long = int
import cv2
from math import cos, sin
from math import cos, sin, sqrt
import numpy as np
if __name__ == "__main__":
......@@ -81,12 +81,12 @@ if __name__ == "__main__":
kalman.correct(measurement)
process_noise = kalman.processNoiseCov * np.random.randn(2, 1)
process_noise = sqrt(kalman.processNoiseCov[0,0]) * np.random.randn(2, 1)
state = np.dot(kalman.transitionMatrix, state) + process_noise
cv2.imshow("Kalman", img)
code = cv2.waitKey(100) % 0x100
code = cv2.waitKey(100)
if code != -1:
break
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment