1. 31 May, 2019 1 commit
    • Sang Ik Lee's avatar
      Cleanup how compile flags are set and used by nGraph and external projects. (#2942) · 08dcd01b
      Sang Ik Lee authored
      * Cleanup how compile flags set and used by nGraph and external projects.
      Set C++11 through CMake and pass it down to external projects.
      Prefer CMake variables such as CMAKE_POSITION_INDEPENDENT_CODE and
      CMAKE_CXX_STANDARD instead of explicitly setting compiler dependent
      flags.
      Create json compilation database for external projects.
      CMAKE_CXX_FLAGS is used as common global options for nGraph and external
      projects.
      add_compile_options() is used for local options for current and sub
      directories.
      add_definitions() is used for setting definitions for current and sub
      directories.
      Note: Global options are not passed down to some external projects.
      Note: mkl-dnn resets CMAKE_CXX_FLAGS internally.
      Note: TBB and MLSL are not CMake based.
      Noet: Eigen and json is header only library.
      
      * Fix error.
      
      * Fix error. (second attempt)
      
      * Cleanup code.
      
      * Allow check for undefined macro.
      
      * Try to fix cldnn issue.
      
      * Set type for CMake arguments.
      
      * Pass C++ standard to protobuf.
      
      * Pass C++ standard down to TBB.
      
      * Change how Clang specific flags are handled.
      
      * Fix error.
      
      * Workaround for compile error on Baidu's PDPD docker.
      
      * Fix windows build error.
      08dcd01b
  2. 06 Mar, 2019 1 commit
    • Scott Cyphers's avatar
      Cyphers/r15catchup (#2567) · 94ce950b
      Scott Cyphers authored
      * Fix bug introduced by #2238 on r0.15 (#2515)
      
      * Fix bug introduced by #2238
      
      * style
      
      * Avijit/add diag 4 distributed debugging (#2523)
      
      * Fix bug introduced by #2238
      
      * Added a debug logging macro: NGRAPH_DIST_DEBUG which prints the timestamp and MPI rank for distributed AllReduceops
      
      * Fixed code formatting.
      
      * Moved the logging implementation to log.cpp
      
      * Fixed clang warning
      
      * Don't use namespace in header
      
      * Fix ifdef
      
      * disable warning
      
      * Fix files that had missing headers (#2539) (#2541)
      
      * Update mkl-dnn to v0.18. (#2543)
      
      * Update mkl-dnn to v0.18.
      
      * Update mkl-dnn patch file.
      
      * Fixed Centos build issues (gcc 4.8.5 doesn't implement std::put_time - hence the issue). Also fixed a logical error in the distributed setup for unit tests (#2545)
      
      * Migrate Klocwork issues (#2557)
      
      * Migrate Klocwork fixes
      
      * change to kick off another build
      
      * Fix crash by correcting index (#2561)
      
      * Update build script to fix Windows build issues and add some work tow… (#2531)
      
      * Update build script to fix Windows build issues and add some work towards making codegen work on Windows.
      
      * Use "git apply" instead of "patch". (#2532)
      
      Enable using pre-installed MKLDNN on Window.
      
      * Remove commented out lines.
      94ce950b
  3. 26 Feb, 2019 1 commit
  4. 22 Feb, 2019 1 commit
  5. 19 Feb, 2019 1 commit
  6. 04 Feb, 2019 1 commit
    • Robert Kimball's avatar
      Windows support. (#2394) · 45a0fb47
      Robert Kimball authored
      * fix windows build
      
      * wip
      
      * mkldnn seems to build
      
      * address various errors building cpu backend with MSVC
      
      * wip
      
      * wip
      
      * Windows support.
      
          * Delete dependency of LLVM when building with MSVC.
      
      * Define EIGEN_HAS_CONSTEXPR when using MSVS.
      
      * Fix MSVC build errors.
      
          * Incorrect argument to 'decltype'. It is VC bug. Work around the
          error with rename the function into different name.
      
          * MINMAX issue in matmul_bias.cpp.
      
          * Correct TBB_LINK_LIBS on Windows.
      
      * Fix MSVC link errors.
      
          1. redefine problems in cpu_builder.obj and convert_layout.obj. It
          is because cpu_builder.hpp contains an implicit implement of
          function runtime::cpu::Builder::build for cpu::op::ConvertLayout.
          The fix is deleting the registration item in cpu_builder.cpp and
          using REGISTER_CPU_OP_BUILDER in convert_layout.cpp.
      
          2. Fix the dependent libraries path on Windows. It should be *.lib
          not *.dll when linking these libraries.
      
      * Set visibility for CPU backend to fix the MSVC linker error.
      
          MSVC complain that the .def file exceed the size limitatoin
          when using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS. All the functions
          with CPU_BACKEND_API are used by unit test or nbench.
      
      * Fix unit test build errors on Windows.
      
          * backend_unary_elementwise.in.cpp: Use all_close_f to test case
          BACKEDND sqrt
      
          * cpu_fustion.cpp: Fix 'NUM_STEPS' cannot be implicitly
          captured because no default capture mode has been specified
      
          * cpu_test.cpp: Use portable setenv and unsetenv from misc.hpp.
      
          * tools.cpp: Use portable fpopen from misc.hpp.
      
          * misc.hpp/misc.cpp: Add new files to host misc functions that Linux and
          Windows using different implementation.
      
      * Make Debug mode work with MSVC.
      
      * style
      
      * fix line ending
      45a0fb47
  7. 17 Jan, 2019 1 commit
  8. 03 Jan, 2019 1 commit
  9. 28 Dec, 2018 1 commit
  10. 23 Dec, 2018 1 commit
  11. 11 Dec, 2018 1 commit
    • Robert Kimball's avatar
      Windows build support (#2177) · 9234cc69
      Robert Kimball authored
      * files pulled from bob/winbuild
      
      * fix compile problems
      
      * fix a few windows build errors
      
      * add windows file to exclude from git
      
      * add comment why change was made
      
      * revert obsolete change
      
      * more cleanup
      
      * building interpreter and unit test on windows with DLLs
      
      * Add flag for windows to export all symbols. Short term fix.
      
      * enable MD build
      
      * address warnings
      
      * dump all windows build results to a single directory
      
      * fix windows backend dll open issue
      
      * remove debug
      
      * fix file iterator for windows
      
      * fix merge error
      
      * fix test failure
      
      * change header from h to hpp in hopes of making python happy
      
      * address more linux build issues
      
      * fix visibility enable
      9234cc69
  12. 09 Nov, 2018 1 commit
  13. 07 Nov, 2018 1 commit
  14. 04 Jun, 2018 1 commit
    • Robert Kimball's avatar
      Modernize cmake usage (#1032) · eef750df
      Robert Kimball authored
      * Update cmake files to more modern approach
      
      * disable building libraries that are not required
      
      * handle more build cases
      
      * add versions to backend libs. add start of package target.
      
      * add create_backend to backends
      
      * temporary workaround to tbb not linking correctly with gcc
      
      * install codegen lib
      
      * force tbb to link to the cpu backend so that it is available for codegen
      
      * fix clang build error
      
      * fix warning for codegen build
      
      * update cuda header paths
      
      * change error message for opening backend shared library
      
      * set lib path
      eef750df
  15. 16 Mar, 2018 1 commit
  16. 14 Feb, 2018 1 commit
  17. 09 Feb, 2018 1 commit
  18. 08 Feb, 2018 1 commit
  19. 05 Feb, 2018 1 commit
    • Adam Procter's avatar
      Compatibility fixes for gcc-4.8.5 and CentOS-7.4 (#444) · 8bccef1a
      Adam Procter authored
      (Squashing this commit but going to leave the full log here, unlike the way I usually do things)
      
      * Incremental work on compatibility with system requirements
      
      * Lower cmake version requirement so we can work with CentOS 7.4
      
      * Disambiguate isnan call (CentOS's compiler doesn't like it)
      
      * Make external_tbb conditional on NGRAPH_CPU_ENABLE
      
      * Make MKLDNN inclusion conditional on NGRAPH_CPU_ENABLE
      
      * Roll back desperation change to Ubuntu 14.04 binaries
      
      * De-revert copyright date change (arrgh)
      
      * Revert change of TBB's hard-coded compiler choice to gcc
      
      * Cleanup of modified CMake stuff
      
      * Add broken support for building LLVM from source
      
      * Explain modification to json.hpp required compiler version
      
      * Make TBB optional, and on by default. To disable, cmake -DNGRAPH_TBB_ENABLE=FALSE
      
      * Add reasonable default for LLVM's CMAKE_ASM_COMPILER so users don't have to specify it
      
      * Force TBB disabled if CMake is too old to build it (for CentOS)
      
      * Build LLVM OpenMP as external project
      
      * Tweak LLVM build options
      
      * Minor comment edit in cmake scripts
      
      * Workaround (fix?) for codegen crashes on CentOS
      
      * Add some header paths for CentOS to resource_generator; temporary(?) tweak to ignore nonexistent paths
      
      * Remove CMake compatibility figleaf since LLVM will require 3.1+ anyway
      
      * Fix the TBB-enable flag to default to on
      
      * Remove hard-coded choice of clang as tbb compiler
      
      * ln -s -> ln -sf in command to create link for OpenMP source dir
      
      * Make OpenMP build so it doesn't require symlink
      
      * Allow use of prebuilt LLVM if requested at cmake time
      
      * Some INSTALL instructions
      
      * Allow NGRAPH_USE_PREBUILT_LLVM to be set in environment variable
      
      * Tweak CI cmake options to use prebuilt LLVM
      
      * Remove debug messages
      
      * Rework defaulting behavior for LLVM_TARBALL_URL and LLVM_SHA1_HASH
      
      * Remove warning message for unavailable header file directories
      8bccef1a
  20. 08 Aug, 2017 1 commit
  21. 07 Aug, 2017 1 commit
  22. 25 Jul, 2017 1 commit