1. 01 Sep, 2018 1 commit
  2. 31 Aug, 2018 2 commits
    • Adam Procter's avatar
      c386da90
    • Scott Cyphers's avatar
      Validate/infer types as a virtual function (#1463) · 132b5305
      Scott Cyphers authored
      * Validate/infer types as a virtual function
      BroadcastLike, ScalarConstantLike
      Set output shape separately from output types
      Remove some obsolete tests
      Replace *Like ops with fixed type versions
      
      * Review comments
      
      * Remove TensorViewType
      
      * Remove PrimaryTensorView
      
      * Reviewer comments
      
      * Style fix.
      
      * Another try at GPU
      
      * GPU
      
      * Simplify class hierarchy
      
      * More of previous.
      
      * Better errors
      
      * Remove unneeded classes
      
      * Merge
      
      * Update Python bindings
      
      * clang-format
      
      * Remove redundant files
      
      * Remove commented out lines
      
      * clang-format
      
      * Group includes
      
      * Missing tests
      
      * Merge error
      132b5305
  3. 29 Aug, 2018 1 commit
  4. 27 Aug, 2018 1 commit
  5. 21 Aug, 2018 1 commit
    • Nick Korovaiko's avatar
      ArgMin (#1435) · 951e77b4
      Nick Korovaiko authored
      * argmin
      
      * address feedbacka argmin
      
      * add new lines
      
      *  addnew lines
      
      * address adam's nitpicks
      
      * scott's feedback
      
      * fix unit tests
      951e77b4
  6. 27 Jul, 2018 1 commit
    • Adam Procter's avatar
      Add some convenience macros/classes for error messages (#1258) · deacf29a
      Adam Procter authored
      * Testing out some ideas for better error messages on AvgPool
      
      * Add uncaught_exception() check to ConstructionAssertLogger dtor
      
      * More general assertion class, not homed inside Node
      
      * Minor formatting change
      
      * NODE_ASSERT for type prop failure
      
      * Produce lighter-weight DummyAssertionHandler when assertion succeeds
      
      * New ctor for AssertionHelper that takes a single location arg; more const&-ness for the constructors
      
      * Remove move constructor for AssertionHelper; fix broken test in assertion.cpp
      
      * Miscellaneous improvements
      
      * Templatized AssertionHelper so different exception classes can be used; implemented TYPE_CHECK_ASSERT around this
      * Changed from a "stack" of locations to a single location (the stack was too complicated)
      * Added "FAIL" classes/macros which do not take a condition
      
      * Rename a helper function
      
      * Cleanup, cruft removal
      
      * Add test to make sure the assert helper has the lifetime we expect
      
      * Missing includes
      deacf29a
  7. 11 May, 2018 1 commit
  8. 23 Apr, 2018 1 commit
  9. 16 Apr, 2018 1 commit
  10. 26 Mar, 2018 1 commit
  11. 21 Mar, 2018 1 commit
  12. 09 Mar, 2018 1 commit
  13. 27 Feb, 2018 1 commit
  14. 23 Feb, 2018 1 commit
  15. 20 Feb, 2018 1 commit
  16. 12 Feb, 2018 1 commit
  17. 08 Feb, 2018 1 commit
  18. 06 Feb, 2018 1 commit
    • Adam Procter's avatar
      Three changes to pooling (#437) · b070ef8d
      Adam Procter authored
      1. AvgPoolBackprop type checking
      2. Padding for max-pool op and kernel
      3. Max pool backprop kernel, and integrating everything with CPU backend/serializer
      3a. Add optional backpointer from the max pool backprop op to the forward prop op
      b070ef8d
  19. 30 Jan, 2018 1 commit
  20. 19 Jan, 2018 3 commits
  21. 12 Jan, 2018 1 commit
  22. 08 Jan, 2018 1 commit
  23. 05 Jan, 2018 1 commit
  24. 30 Dec, 2017 1 commit
    • Adam Procter's avatar
      Forward prop for max pooling (#305) · d901282e
      Adam Procter authored
      * Definition and type checking for max pool
      
      * Implement kernel, integrate into INTERPRETER, add a few unit tests, make function result type mismatch error message more informative (still need to update tests to reflect that)
      
      * Temporarily delete unit tests to ease merge
      
      * Temporarily delete unit tests to ease merge
      
      * Restore deleted unit tests
      
      * Fix a broken error message check in the unit tests
      
      * Update to handle various TensorViewType-related things going away; add NGVM support
      
      * Add codegen case
      
      * Change various get_blah_shape methods to return const refs, and while we're here, make a similar change where it should have been done in convolution
      
      * Use NDArray for max-pool tests
      d901282e
  25. 29 Dec, 2017 1 commit
    • Scott Cyphers's avatar
      Get value types out of public API, multi-values from Function (#340) · d092cb91
      Scott Cyphers authored
      * Function can have multiple results
      Remove external use of ValueType, TupleType, Tuple
      Remove many external uses of Output and Input
      
      * corresponding CPU backend changes
      
      * Update master changes.
      
      * Remove type arg from Function, add changes.md
      
      * Merge changes.
      
      * Move bodies to .cpp, add brief doc
      
      * Merge CPU changes.
      
      * Remove xla includes from non-xla files
      
      * Remove xla from tests
      
      * First part of xla tuple support
      
      * change fprop_cache to assume multi-output bprop functions
      
      * New wrappers for handling tuples with XLA
      
      * Review comments
      
      * remove old xla files
      
      * fix merge errors
      
      * hand edit models to use multi output instead of tuples
      d092cb91
  26. 21 Dec, 2017 1 commit
  27. 19 Dec, 2017 1 commit
    • Robert Kimball's avatar
      Remove ParameterizedConstant (#309) · 833a8f14
      Robert Kimball authored
      * remove use of ParameterizedConstant from unit test. Now using Constant instead. Constant is not a templated class.
      
      * move ParameterizedTensorView to NGVM directory
      
      * element_type cleanup
      833a8f14
  28. 18 Dec, 2017 2 commits
    • Scott Cyphers's avatar
      Cyphers/shape (#310) · 8a569f27
      Scott Cyphers authored
      * Add and use get_shape() and get_element_type() on Input/Output
      
      * Fix Output
      
      * Formatting.
      
      * Format.
      
      * Use reference
      
      * Convolution.
      8a569f27
    • Adam Procter's avatar
      Convolution forward prop (#294) · 122db5ff
      Adam Procter authored
      * Test GitHub-JIRA integration, nothing useful in this commit
      
      NGTF-388 #comment Testing JIRA integration
      
      * WIP on convolution
      
      * Type checking for convolution
      
      * Docstrings for convolution
      
      * Add convolution reference kernel; it works on some unit tests copied and pasted from my old branch.
      
      * Bugfix for dilated conv, and improvement to conv test generation
      
      * Remove get_arguments calls from convolution stuff
      
      * Add convolution to CPU; also a few fixes to the test generation stuff
      
      * Add copyright header to convolution ref script
      
      * Move copyright header to the correct place
      
      * A few more tests
      
      * Remove fallback behavior of blanking out the convolution ref file, since we're not generating it from the build system anymore
      
      * Delete stale comment
      
      * Merge stuff for the convolution ref script
      
      * Clean up rebase mess
      
      * Review comments
      
      * Review comment (n_foo -> foo_count)
      122db5ff
  29. 14 Dec, 2017 1 commit
    • Nick Korovaiko's avatar
      Toward removing tuples and m_arguments (yuge rebase and fixes) (#301) · fce3c524
      Nick Korovaiko authored
      * tuple -> xla_tuple (+headers)
      
      xla_get_tuple_element
      
      get_tuple_element headers
      
      adding get_tuple_element + fixes
      
      get_tuple_element
      
      XLAFunction; breaks tests
      
      compiling libngraph.so w/ XLAFunction and Function; fixing tests is next
      
      build & test fixes
      
      formatting
      
      m_arguments -> get_arguments (first step to hide m_arguments)
      
      removing some get_arguments
      
      get_arguments -> get_arguments_DEPRECATED
      
      more DEPRECATED
      
      formatting
      
      m_arguments no more! at least technically
      
      halfway
      
      tests pass
      
      xla_function.cpp/hpp
      
      move defs into cpp files
      
      get_input_argument -> get_input_op
      
      formatting
      
      * add xla_function.* and assert -> throw
      
      * assert -> throw, remove cassert
      
      * removing emitter.cpp; poor guy got left behind
      
      * addressing feedback p1
      
      * rename GetTupleElement -> GetOutputElement
      
      * adding a comment to get_arguments_FOR_GRAPH_REWRITE_ONLY
      
      * removing virtual off set_name
      fce3c524
  30. 11 Dec, 2017 1 commit
    • Adam Procter's avatar
      Generalized dot (#291) · cba4e54e
      Adam Procter authored
      * WIP generalized dot
      
      * Add some multi-axis 3D, 4D, and 5D tests
      
      * Add test on some 'pretty big' tensors
      
      * Reworked dot to have less flexible axis-pairing behavior
      
      * Backprop for dot... and a fix for a dumb bug in CoordinateTransform
      
      * Forgot to commit some stuff in merge
      
      * Disable tests that currently don't work on CPU
      
      * Fix temporarily disabled test that should pass on NGVM and INTERPRETER but wasn't due to new axis-selection convention for dot
      
      * Remove obsolete ScalarTensorProduct kernel/instruction
      
      * Review comment
      
      * s/n_dot_axes/dot_axis_count/
      
      * s/dot_axis_count/reduction_axes_count/
      
      * Adapt CPU emitter dot fallback to new kernel
      cba4e54e
  31. 04 Dec, 2017 1 commit
    • Adam Procter's avatar
      Finish de-Eigenization (#282) · 7b305e3e
      Adam Procter authored
      * Simpler kernel for broadcast
      
      * Fixed behavior for integer divide-by-zero, added unit tests
      
      * Strided and higher-dimensional slice (just tested to 3D)
      
      * Higher-dimensional sum
      
      * Replace-slice de-Eigenized; NOT TESTED AT HIGHER DIMENSIONS YET
      
      * Correct sum behavior when eliminating zero-length axes; add unit tests; also, add higher-dim unit tests for replace-slice
      
      * Higher-dimensional reduce, 'cause hey, why not?
      
      * Remove BroadcastScalarInstruction
      
      * Adding test for an observed failure at trivial sum on 5-tensors
      
      * De-Eigenized and higher-dimmified concat
      
      * Replace 'auto' in the kernels
      
      * temporary delete to ease merge
      
      * Re-insert tests that were deleted to ease merge
      
      * Refactor view-iteration
      
      * De-Eigenize reshape
      
      * Rework divide kernel to use std::enable_if to distinguish between floating and non-floating types
      
      * Update docs to reflect newly implemented cases in several ops
      
      * Rename parameters to View for more clarity; remove axis_walk_order (it's redundant)
      
      * Formatting
      
      * More terminological rejiggering
      
      * De-Eigenize scalar-tensor product
      
      * De-Eigenize dot
      
      * Update docstrings
      
      * Remove 'implementation status' tables from docstrings
      
      * Change step -> strides everywhere for consistent terminology
      
      * Formatting
      
      * Replace asserts in view.cpp with exceptions
      
      * Fix typo
      
      * Fix incorrect result type in dot1d test (ouch...)
      
      * Add missing support for Float64 to ngvm/external_function
      
      * Add int16 and uint16 (how was this missing?)
      
      * A few more additions relative to the missing element types
      
      * Disable tests that will not pass on CPU; they can still be run with test/unit-test --gtest_also_run_disabled_tests --gtest_filter='DISABLED_NGVM.*'
      
      * Move project_ and inject_ functions to common.[ch]pp, not view.[ch]pp
      
      * Rename View to CoordinateTransform
      
      * Add prefix ++ and += to CoordinateIterator
      7b305e3e
  32. 01 Dec, 2017 1 commit
  33. 29 Nov, 2017 1 commit
    • Adam Procter's avatar
      Backprop for some ops (#257) · 13330d49
      Adam Procter authored
      * Autodiff for abs
      
      * Formatting, more tests for abs
      
      * Cos autodiff; also a clarifying comment in the abs test
      
      * Forgot cos.cpp
      
      * Sin autodiff
      
      * Again, forgot to add sin.cpp  :/
      
      * Tan autodiff
      
      * Minor formatting tweak
      
      * Commit partial work on select backprop so I can run valgrind on the server  :/
      
      * Fix boolean thingy so it works on Linux
      
      * Autodiff for ceiling, convert (untested), floor, sign. Fix unit test for tan. Implement ceiling, floor in VM.
      
      * Fix bug in abs/sign unit test ranges
      
      * Add multiplicative inverse and square-root ops (needed for hyperbolic trig autodiff)
      
      * Better formula for sqrt adjoints
      
      * Autodiff for hyperbolic trig ops
      
      * Forgot to add cpp files for hyperbolics
      
      * Remove inv (don't need it after all); also formatting (oops)
      
      * fix bug with Convert autodiff
      
      * Autodiff for concat
      
      * Restore the accidentally-commented-out unit test for abs
      
      * Formatting
      
      * Fix 'unordered_map.at' exception when Adjoints::Adjoints visit a node that has never been add_delta'd; remove workarounds for that bug
      
      * Fix erroneous 'not implemented' docstring for op::Not
      
      * Autodiff for sum
      
      * Checking in broken support for replace_slice so I can test it with valgrind on the dev box
      
      * Fix unit test bug with tensor initialization; formatting
      
      * Implement replace-slice in CPU backend
      
      * Autodiff for Slice and ReplaceSlice
      
      * Tweak docs for ReplaceSlice
      
      * Remove no-longer-needed cast of arg list to runtime::TensorView
      13330d49
  34. 17 Nov, 2017 1 commit
  35. 11 Nov, 2017 1 commit
  36. 10 Nov, 2017 1 commit