1. 03 Jan, 2020 1 commit
    • Pruthvi's avatar
      [MLIR] Affine lowering support for Comparison Ops (#3872) · 9a01762a
      Pruthvi authored
      * Affine lowering support for
          1) GreaterEq
          2) LessEq
          3) Equal
          4) NotEqual
      
      * - cast result op from i1 to i8 for comparision operators
      
      * Addressed PR comments
      
      * Style fix
      
      * - style check
      - use select instead of zero_extendi durinng CompOp lowering
      
      * - fix style
      - use createOneConstant and createZeroConstant helpers in select intrinsic
      
      * Use NG_U8_TYPE_ID for BooleanType in ngraph dialect
      
      * Diable CE and Softmax unit test in MLIR
      
      * - LIT parser test for comparision ops
      
      * - Affine dailect LIT tests for Comparision Ops
      
      * Address PR feedback
      
      * fix typo
      
      * - use `cast` to deduce element Type
      - add more strict type checking to LIT Test
      
      * fix CHECK label's for comparision ops
      
      * Use UInt8 in verification logic for CMP op's
      
      * - use UInt8 for the resultOp verification Logic in CMP op
      - fix unit test failures
      9a01762a
  2. 01 Jan, 2020 1 commit
  3. 23 Dec, 2019 1 commit
  4. 17 Dec, 2019 1 commit
    • Diego Caballero's avatar
      [MLIR] Improve lit test config files and tools (#4010) · 6e38579b
      Diego Caballero authored
      This PR fixes some of the inconveniences that we had with lit in nGraph
      and aligns configuration files with MLIR/LLVM.
      In particular:
        - `make install` is not needed to run lit test with the latest
          compiled version of testing tools (ngraph-opt).
        - LD_LIBRARY_PATH doesn't need to be modified.
      6e38579b
  5. 06 Dec, 2019 1 commit
  6. 27 Nov, 2019 2 commits
    • Nagy Mostafa's avatar
      [MLIR] Enable ViewOp in Affine Lowerer (#3911) · 96062512
      Nagy Mostafa authored
      * Map each ng tensor to a linear buffer and a view
      
      * fix comment
      
      * Create views only when a value is assigned a buffer id
      
      * style
      
      * Fix lit test
      96062512
    • Nagy Mostafa's avatar
      [MLIR] Fused Ops dialect declaration (#3860) · e5436889
      Nagy Mostafa authored
      * WIP
      
      * WIP
      
      * WIP
      
      * All ops
      
      * Fix layernorm backprop op name
      
      * WIP: Adding tests
      
      * WIP: Adding LIT parsing/printing tests
      
      * WIP
      
      * Added LSTM cells. Fixed some ops
      
      * All builder tests
      
      * PR fixes
      
      * Fix spacing. Add missing setter to SpaceToDepth
      
      * Update spaceToDepth lit test
      
      * PR fixes
      
      * Build fix
      
      * Another fix
      
      * Fixed optional args
      e5436889
  7. 21 Nov, 2019 1 commit
  8. 18 Nov, 2019 2 commits
  9. 11 Nov, 2019 1 commit
    • Pruthvi's avatar
      [MLIR] Graph pass to lower ngraph to ngraph dialect (#3835) · 6fbed3b9
      Pruthvi authored
      *  WIP graph pass to lower ngraph to ngraph dialect
      
      * resolved compiler errors
      
      * - refactor ngraph-dialect to graph pass
      
      * - fix compilation issue
      - unit test passes
      
      *  - style fix
      
      * Addressed PR comments
      
      * - move NgDialectConversionPass to anonymous namespace
      
      * - use getModule() to access module inside the graph pass
      - address PR comments
      
      *  - fix failing unit test case for negative padding
      - make builder as an object isntead of pointer to an object
      
      * Address PR Comments
      6fbed3b9
  10. 04 Nov, 2019 1 commit
    • Nagy Mostafa's avatar
      [MLIR] New Core Ops (V0) and Ops Versioning in NG dialect (#3764) · 8ef5b0ca
      Nagy Mostafa authored
      * Init commit to implement interface
      
      *  Add two op interfaces for v0 and v1. Add a unit-test
      
      * Add missing files
      
      * Move test to separate file
      
      * Add Fused Op interface
      
      * Missing files
      
      * style
      
      * fused ops
      
      * Remove V1 ops for now
      
      * Added enum attributes. WIP
      
      * Completed non-experiemntal non-fused-ops
      
      * Add ops_attributes
      
      * Minor fixes
      
      * Minor fixes
      
      * Added enum setting/reading test
      
      * style-apply
      
      * Added attributes tests
      
      * Fix dialect init
      
      * style
      
      * fix typo
      
      * Fix merge errors
      
      * Include file with MLIR on
      8ef5b0ca
  11. 30 Oct, 2019 1 commit
    • Pruthvi's avatar
      [MLIR] Graph pass to lower standardDialect to llvm module (#3810) · 3f3153f5
      Pruthvi authored
      * Re-organize files. Create MLIR backend classes
      
      * WIP
      
      * Refactored. Code compiles
      
      * Moved context to Runtime class to outlive compilation and execution
      
      * style-apply
      
      * Base Runtime class. Few other modifications
      
      * Minor fixes
      
      * Fixed Runtime::run() to take type-erased pointer
      
      * renamed core compiler
      
      * rename backend compiler
      
      * rename runtime compiler
      
      * PR feedback
      
      * Fix build fails
      
      * - refactor LowerNGDialect
      - addgraph pass to lower standardDialect to llvm module
      
      * Addressed PR Comments
      
      * i) Style fix ii) restore deleted file
      3f3153f5
  12. 29 Oct, 2019 1 commit
    • Nagy Mostafa's avatar
      [MLIR] MLIR Compiler refactoring (#3786) · f143bb13
      Nagy Mostafa authored
      * Re-organize files. Create MLIR backend classes
      
      * WIP
      
      * Refactored. Code compiles
      
      * Moved context to Runtime class to outlive compilation and execution
      
      * style-apply
      
      * Base Runtime class. Few other modifications
      
      * Minor fixes
      
      * Fixed Runtime::run() to take type-erased pointer
      
      * renamed core compiler
      
      * rename backend compiler
      
      * rename runtime compiler
      
      * PR feedback
      
      * Fix build fails
      f143bb13
  13. 23 Oct, 2019 1 commit
  14. 10 Oct, 2019 3 commits
  15. 09 Oct, 2019 2 commits
  16. 03 Oct, 2019 1 commit
  17. 02 Oct, 2019 1 commit
    • Diego Caballero's avatar
      [MLIR] Pass optimization level to MLIR ExecutionEngine (#3703) · 1ddda541
      Diego Caballero authored
      An optional optimization level was added to ExecutionEngine, initialized
      to None by default. This caused fast-isel to be used in LLVM CG,
      overriding all the flags related to not using fast-isel.
      
      In this PR we pass the right optimization level to ExecutionEngine.
      1ddda541
  18. 30 Sep, 2019 1 commit
    • Diego Caballero's avatar
      [MLIR] Improve gather op lowering (#3667) · 3aa4db1d
      Diego Caballero authored
      * [MLIR] Add support for parsing nGraph tensor type
      
      Initial commit that enables nGraph parsing. It's needed for testing.
      
      * [MLIR] Enable nGraph dialect in ngraph-opt
      
      This PR registers nGraph dialect in ngraph-opt and prepares
      nGraph lowering pass for LIT testing, fixing all the related issues.
      Among other things, lowering pass has to be turned into a function pass,
      dead argument in constructor was removed and `convert-ngraph-to-affine`
      flag was added.
      
      * Fix issue with function name and multiple functions
      
      * Extend module_function.mlir lit test
      
      * [MLIR] Add support for parsing nGraph element types
      
      It introduces initial support for parsing nGraph signed/unsigned
      integer and floating point data types.
      
      * [MLIR] Improve gather op lowering
      
      This PR interchanges indices and param loops in gather lowering so
      that a better memory access patter is generated. Fusion of gather
      with other ops is also observed with this change.
      3aa4db1d
  19. 28 Sep, 2019 1 commit
    • Diego Caballero's avatar
      [MLIR] Enable nGraph dialect in ngraph-opt (#3657) · 9db8f874
      Diego Caballero authored
      * [MLIR] Add support for parsing nGraph tensor type
      
      Initial commit that enables nGraph parsing. It's needed for testing.
      
      * [MLIR] Enable nGraph dialect in ngraph-opt
      
      This PR registers nGraph dialect in ngraph-opt and prepares
      nGraph lowering pass for LIT testing, fixing all the related issues.
      Among other things, lowering pass has to be turned into a function pass,
      dead argument in constructor was removed and `convert-ngraph-to-affine`
      flag was added.
      
      * Fix issue with function name and multiple functions
      
      * Extend module_function.mlir lit test
      
      * Improve module_function.mlir test
      
      Remove ngraph to affine dialect conversion since we just need to verify
      that we can parse and print modules and functions.
      Add verification for parsing the printed code.
      
      * [MLIR] Add support for parsing nGraph element types (#3665)
      
      * [MLIR] Add support for parsing nGraph element types
      
      It introduces initial support for parsing nGraph signed/unsigned
      integer and floating point data types.
      
      * Improve LIT tests
      
      Test parsing and printing of types separately from lowering to affine
      since these tests will evolve differently, particularly for tensor
      types.
      
      * Missed file
      
      I left this file behind in the previous commit
      9db8f874
  20. 25 Sep, 2019 1 commit
  21. 24 Sep, 2019 2 commits
    • Diego Caballero's avatar
      [MLIR] Add support for parsing nGraph tensor type (#3654) · e2bddf19
      Diego Caballero authored
      * [MLIR] Add support for parsing nGraph tensor type
      
      Initial commit that enables nGraph parsing. It's needed for testing.
      
      * Clang format
      
      * Fix return in parser
      e2bddf19
    • Diego Caballero's avatar
      [MLIR] Add `ngraph` prefix to MLIR flags (#3625) · 1c9a1996
      Diego Caballero authored
      * [MLIR] Add `ngraph` prefix to MLIR flags
      
      Some flags collision with some MLIR flags.
      
      * [MLIR] Add support for nGraph tensor type in parser
      
      Initial commit that enables nGraph parsing. It's needed for testing.
      
      * Rename ngraph print flag
      
      * Rename ngraph dump mlir flags
      
      * Clang format
      
      * Revert "[MLIR] Add support for nGraph tensor type in parser"
      
      This reverts commit ae371d6a5c8ea590322d5d3b9ba110159d4bf5fa.
      1c9a1996
  22. 19 Sep, 2019 1 commit
  23. 18 Sep, 2019 2 commits
  24. 17 Sep, 2019 2 commits
  25. 16 Sep, 2019 1 commit
  26. 10 Sep, 2019 3 commits
    • Nagy Mostafa's avatar
      [MLIR] Remove Fake Instructions (#3568) · 1fb6fa96
      Nagy Mostafa authored
      * WIP
      
      * Fixes
      
      * Increase bitwidth for arg idx attrib
      
      * Minor fixes
      
      * style-apply
      1fb6fa96
    • Diego Caballero's avatar
      [MLIR] Introduce ngraph-opt tool (#3560) · f159e196
      Diego Caballero authored
      * [MLIR] Enable LIT testing in CMAKE
      
      This PR enables LIT testing in nGraph for MLIR Compiler, introduced in
      PR3523. We can now do `make check-mlir-lit` to run LIT tests.
      
      * Address feedback
      
      * Revisit PR after cmake clean-up
      
      * [MLIR] Introduce ngraph-opt tool
      
      To be used, among other things, for LIT testing.
      `elementwise_binary_ops.mlir` shows a simple LIT test
      using ngraph-opt.
      
      Dummy affine_lowering/lit_test.mlir test that served as initial testing
      of LIT tool configuration is now removed.
      
      * Address feedback
      f159e196
    • Nagy Mostafa's avatar
      [MLIR] Bump commits (#3584) · 3287ca6f
      Nagy Mostafa authored
      * Bump MLIR version and minor fixes in nGraph
      
      * advance commit ids
      
      * fix commit id
      3287ca6f
  27. 06 Sep, 2019 1 commit
  28. 05 Sep, 2019 1 commit
  29. 04 Sep, 2019 2 commits
    • Amy Zhuang's avatar
    • Diego Caballero's avatar
      [MLIR] Clean up MLIR related CMake files (#3541) · f6425cbd
      Diego Caballero authored
      * [MLIR] Move MLIR compiler files to contrib/mlir/compiler
      
      We'll add contrib/mlir/tools directory in subsequent PRs for ngrpah-opt
      and other tools.
      
      * [MLIR] Clean up MLIR related CMake files
      
      This PR prepares the introduction of src/contrib/mlir/tools and LIT testing by
      refactoring and cleaning up the common part with src/contrib/mlir/compiler:
      
      - Common code for src/contrib/mlir/tools and src/contrib/mlir/compiler is
      moved to src/contrib/mlir/CMakeList.txt.
      - More generic code, common for src/contrib/mlir/* and LIT configuration
      files, is moved to cmake/external_mlir.cmake with pre-existing similar code.
      - Redundant environment var LLVM_DIR is removed in favor of LLVM_CMAKE_PATH.
      - Redundant cmake messages are removed.
      
      * Replacing LLVM_CMAKE_PATH with LLVM_DIR
      f6425cbd