1. 19 Dec, 2017 2 commits
    • Robert Kimball's avatar
      Remove ParameterizedConstant (#309) · 833a8f14
      Robert Kimball authored
      * remove use of ParameterizedConstant from unit test. Now using Constant instead. Constant is not a templated class.
      
      * move ParameterizedTensorView to NGVM directory
      
      * element_type cleanup
      833a8f14
    • Robert Kimball's avatar
      Parameter as output support (#315) · 8fc6473e
      Robert Kimball authored
      * add unit test
      
      * fix Parameter as output in INTERPRETER
      
      * cpu working
      
      * parameter_as_output passing for INTERPRETER
      
      * still works
      
      * cleanup
      8fc6473e
  2. 18 Dec, 2017 3 commits
    • Scott Cyphers's avatar
      Cyphers/shape (#310) · 8a569f27
      Scott Cyphers authored
      * Add and use get_shape() and get_element_type() on Input/Output
      
      * Fix Output
      
      * Formatting.
      
      * Format.
      
      * Use reference
      
      * Convolution.
      8a569f27
    • Adam Procter's avatar
      Convolution forward prop (#294) · 122db5ff
      Adam Procter authored
      * Test GitHub-JIRA integration, nothing useful in this commit
      
      NGTF-388 #comment Testing JIRA integration
      
      * WIP on convolution
      
      * Type checking for convolution
      
      * Docstrings for convolution
      
      * Add convolution reference kernel; it works on some unit tests copied and pasted from my old branch.
      
      * Bugfix for dilated conv, and improvement to conv test generation
      
      * Remove get_arguments calls from convolution stuff
      
      * Add convolution to CPU; also a few fixes to the test generation stuff
      
      * Add copyright header to convolution ref script
      
      * Move copyright header to the correct place
      
      * A few more tests
      
      * Remove fallback behavior of blanking out the convolution ref file, since we're not generating it from the build system anymore
      
      * Delete stale comment
      
      * Merge stuff for the convolution ref script
      
      * Clean up rebase mess
      
      * Review comments
      
      * Review comment (n_foo -> foo_count)
      122db5ff
    • Adam Procter's avatar
      Interpreter tweaks (#311) · 3b84d91a
      Adam Procter authored
      * Replace function->get_result()->get_outputs() call with function->get_outputs()
      
      * Test for parameter straight to output
      
      * Roll back cmake modification for INTERPRETER autodiff
      3b84d91a
  3. 15 Dec, 2017 4 commits
  4. 14 Dec, 2017 1 commit
    • Nick Korovaiko's avatar
      Toward removing tuples and m_arguments (yuge rebase and fixes) (#301) · fce3c524
      Nick Korovaiko authored
      * tuple -> xla_tuple (+headers)
      
      xla_get_tuple_element
      
      get_tuple_element headers
      
      adding get_tuple_element + fixes
      
      get_tuple_element
      
      XLAFunction; breaks tests
      
      compiling libngraph.so w/ XLAFunction and Function; fixing tests is next
      
      build & test fixes
      
      formatting
      
      m_arguments -> get_arguments (first step to hide m_arguments)
      
      removing some get_arguments
      
      get_arguments -> get_arguments_DEPRECATED
      
      more DEPRECATED
      
      formatting
      
      m_arguments no more! at least technically
      
      halfway
      
      tests pass
      
      xla_function.cpp/hpp
      
      move defs into cpp files
      
      get_input_argument -> get_input_op
      
      formatting
      
      * add xla_function.* and assert -> throw
      
      * assert -> throw, remove cassert
      
      * removing emitter.cpp; poor guy got left behind
      
      * addressing feedback p1
      
      * rename GetTupleElement -> GetOutputElement
      
      * adding a comment to get_arguments_FOR_GRAPH_REWRITE_ONLY
      
      * removing virtual off set_name
      fce3c524
  5. 13 Dec, 2017 8 commits
  6. 12 Dec, 2017 5 commits
  7. 11 Dec, 2017 2 commits
    • Adam Procter's avatar
      Generalized dot (#291) · cba4e54e
      Adam Procter authored
      * WIP generalized dot
      
      * Add some multi-axis 3D, 4D, and 5D tests
      
      * Add test on some 'pretty big' tensors
      
      * Reworked dot to have less flexible axis-pairing behavior
      
      * Backprop for dot... and a fix for a dumb bug in CoordinateTransform
      
      * Forgot to commit some stuff in merge
      
      * Disable tests that currently don't work on CPU
      
      * Fix temporarily disabled test that should pass on NGVM and INTERPRETER but wasn't due to new axis-selection convention for dot
      
      * Remove obsolete ScalarTensorProduct kernel/instruction
      
      * Review comment
      
      * s/n_dot_axes/dot_axis_count/
      
      * s/dot_axis_count/reduction_axes_count/
      
      * Adapt CPU emitter dot fallback to new kernel
      cba4e54e
    • Robert Kimball's avatar
      Bob/backend work (#295) · a960f07e
      Robert Kimball authored
      * add support for n-dimensional operations by calling runtime/kernels
      
      * rename cpu backend classes and files
      
      * add tuple support to INTERPRETER
      
      * move ndarray out of runtime to test where it belonged
      
      * fix Tuple op per review comment
      a960f07e
  8. 06 Dec, 2017 2 commits
    • Nick Korovaiko's avatar
      Subgraph Labels (#285) · ab63fd33
      Nick Korovaiko authored
      * subgraph labels
      
      * adding more documentation for Label
      
      * minor fixes
      ab63fd33
    • Adam Procter's avatar
      New checks for Function's constructor (#292) · 8c50b179
      Adam Procter authored
      * Remove unnecessary dependency on codegen in interpreter
      
      * Check for incorrect return type and undeclared parameters in Function's constructor
      
      * Address review comments
      
      * Add scarier error message when the result node has null return type (should never happen)
      * Add new constructor for Function that doesn't require the return type, and unit test for same
      8c50b179
  9. 05 Dec, 2017 2 commits
    • Robert Kimball's avatar
      New Interpreter backend (#287) · 025a1b92
      Robert Kimball authored
      * New Interpreter backend
      
      * PR review comments
      
      * More RP fixes
      
      * oops
      
      * make autodiff tests backend aware
      
      * wip
      
      * wip
      
      * more ops
      
      * wip
      
      * fix merge error
      
      * merge fixes
      025a1b92
    • Matthew Brookhart's avatar
      Fix a bug in traverse Nodes (#288) · f0810b5f
      Matthew Brookhart authored
      * We were pushing parameters that have been seen to the stack in traverse nodes. This causes an infinite loop in RNNs.
      
      * fix formatting
      
      * style fix for Scott
      f0810b5f
  10. 04 Dec, 2017 1 commit
    • Adam Procter's avatar
      Finish de-Eigenization (#282) · 7b305e3e
      Adam Procter authored
      * Simpler kernel for broadcast
      
      * Fixed behavior for integer divide-by-zero, added unit tests
      
      * Strided and higher-dimensional slice (just tested to 3D)
      
      * Higher-dimensional sum
      
      * Replace-slice de-Eigenized; NOT TESTED AT HIGHER DIMENSIONS YET
      
      * Correct sum behavior when eliminating zero-length axes; add unit tests; also, add higher-dim unit tests for replace-slice
      
      * Higher-dimensional reduce, 'cause hey, why not?
      
      * Remove BroadcastScalarInstruction
      
      * Adding test for an observed failure at trivial sum on 5-tensors
      
      * De-Eigenized and higher-dimmified concat
      
      * Replace 'auto' in the kernels
      
      * temporary delete to ease merge
      
      * Re-insert tests that were deleted to ease merge
      
      * Refactor view-iteration
      
      * De-Eigenize reshape
      
      * Rework divide kernel to use std::enable_if to distinguish between floating and non-floating types
      
      * Update docs to reflect newly implemented cases in several ops
      
      * Rename parameters to View for more clarity; remove axis_walk_order (it's redundant)
      
      * Formatting
      
      * More terminological rejiggering
      
      * De-Eigenize scalar-tensor product
      
      * De-Eigenize dot
      
      * Update docstrings
      
      * Remove 'implementation status' tables from docstrings
      
      * Change step -> strides everywhere for consistent terminology
      
      * Formatting
      
      * Replace asserts in view.cpp with exceptions
      
      * Fix typo
      
      * Fix incorrect result type in dot1d test (ouch...)
      
      * Add missing support for Float64 to ngvm/external_function
      
      * Add int16 and uint16 (how was this missing?)
      
      * A few more additions relative to the missing element types
      
      * Disable tests that will not pass on CPU; they can still be run with test/unit-test --gtest_also_run_disabled_tests --gtest_filter='DISABLED_NGVM.*'
      
      * Move project_ and inject_ functions to common.[ch]pp, not view.[ch]pp
      
      * Rename View to CoordinateTransform
      
      * Add prefix ++ and += to CoordinateIterator
      7b305e3e
  11. 03 Dec, 2017 1 commit
  12. 01 Dec, 2017 3 commits
  13. 30 Nov, 2017 6 commits