address klocwork issues (#2555)

src/ngraph/codegen/compiler.cpp

@@ -615,7 +615,7 @@ int codegen::CompilerCore::full_version_number(const std::string& path, const st
     }
 
     // create full version number and return
-    std::string full_version = {};
+    std::string full_version = "0";
     // Assume versioning like X.Y.Z
     int padding = 3 - tokens.size();
     for (std::string s : tokens)
@@ -633,7 +633,7 @@ std::string codegen::CompilerCore::find_header_version(const std::string& path)
 {
     // Step 1: find highest g++ version
     std::string gpp_prefix = file_util::path_join(path, "bin/g++-");
-    std::string gpp_ver = {};
+    std::string gpp_ver = "0";
     for (auto i : {"8", "7", "6", "5", "4.9", "4.8"})
     {
         if (file_util::exists(gpp_prefix + i))

src/ngraph/log.cpp

@@ -84,10 +84,13 @@ std::string ngraph::get_timestamp()
     auto timer = std::chrono::system_clock::to_time_t(now);
 
     // convert to broken time
-    std::tm* bt = std::localtime(&timer);
-
     char buffer[256];
+    buffer[0] = 0;
+    std::tm* bt = std::localtime(&timer);
+    if (bt)
+    {
         strftime(buffer, sizeof(buffer), "%H:%M:%S", bt);
+    }
 
     std::ostringstream timestamp;
     timestamp << buffer;

src/ngraph/runtime/cpu/pass/cpu_rnn_fusion.cpp

@@ -804,8 +804,8 @@ void ngraph::runtime::cpu::pass::BiDirectionalRnn::construct_bidirectional_rnn()
                                                         rnn_right_to_left](pattern::Matcher& m) {
 
         auto pattern_map = m.get_pattern_map();
-        auto rnn_ltor_node = std::dynamic_pointer_cast<op::Rnn>(pattern_map[rnn_left_to_right]);
-        auto rnn_rtol_node = std::dynamic_pointer_cast<op::Rnn>(pattern_map[rnn_right_to_left]);
+        auto rnn_ltor_node = std::static_pointer_cast<op::Rnn>(pattern_map[rnn_left_to_right]);
+        auto rnn_rtol_node = std::static_pointer_cast<op::Rnn>(pattern_map[rnn_right_to_left]);
 
         if (rnn_ltor_node->get_src_sequence_length() != rnn_rtol_node->get_src_sequence_length())
         {

src/ngraph/runtime/hybrid/hybrid_util.cpp

@@ -161,6 +161,10 @@ void runtime::hybrid::rewrite_function(const shared_ptr<Function>& f,
         if (cluster.size() > 0)
         {
             shared_ptr<Node> tmp_node = *cluster.begin();
+            if (tmp_node == nullptr)
+            {
+                throw runtime_error("cluster contains nullptr instead of nodes");
+            }
             auto placement = tmp_node->get_placement_index();
             if (placement != 0)
             {

test/cpu_test.cpp

@@ -775,6 +775,7 @@ TEST(cpu_test, memory_reuse_destructive_oi_relu)
 
     shared_ptr<runtime::Executable> handle = backend->compile(f);
     handle->call_with_validate({result}, {a, b, c});
+    ASSERT_NE(handle, nullptr);
     EXPECT_EQ(read_vector<float>(result), expected);
 }
 
@@ -802,6 +803,7 @@ TEST(cpu_test, memory_reuse_cacheable_no_destructive_oi_relu)
     vector<float> expected{0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
 
     shared_ptr<runtime::Executable> handle = backend->compile(f);
+    ASSERT_NE(handle, nullptr);
     handle->call_with_validate({result}, {a, b, c});
     EXPECT_EQ(read_vector<float>(result), expected);
 
@@ -864,6 +866,7 @@ TEST(cpu_test, memory_reuse_in_place_slice_after_in_place_concat)
     auto result = backend->create_tensor(element::f32, shape_r);
 
     shared_ptr<runtime::Executable> handle = backend->compile(f);
+    ASSERT_NE(handle, nullptr);
     handle->call_with_validate({result}, {a, b, c, d});
     EXPECT_EQ((vector<float>{3, 7}), read_vector<float>(result));
 }