Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
N
ngraph
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
ngraph
Commits
f6637801
Commit
f6637801
authored
Sep 06, 2017
by
Scott Cyphers
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Review comments.
parent
7bcb5eb9
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
3 deletions
+7
-3
op.hpp
src/ngraph/op.hpp
+2
-2
type_prop.cpp
test/type_prop.cpp
+5
-1
No files found.
src/ngraph/op.hpp
View file @
f6637801
...
...
@@ -84,7 +84,7 @@ namespace ngraph
class
UnaryElementwiseBuiltin
:
public
Builtin
{
protected
:
UnaryElementwiseBuiltin
(
const
std
::
shared_ptr
<
Node
>
arg
)
UnaryElementwiseBuiltin
(
const
std
::
shared_ptr
<
Node
>
&
arg
)
:
Builtin
(
Nodes
{
arg
})
{
}
...
...
@@ -97,7 +97,7 @@ namespace ngraph
class
BinaryElementwiseBuiltin
:
public
Builtin
{
protected
:
BinaryElementwiseBuiltin
(
std
::
shared_ptr
<
Node
>
arg0
,
std
::
shared_ptr
<
Node
>
arg1
)
BinaryElementwiseBuiltin
(
const
std
::
shared_ptr
<
Node
>&
arg0
,
const
std
::
shared_ptr
<
Node
>&
arg1
)
:
Builtin
(
Nodes
{
arg0
,
arg1
})
{
}
...
...
test/type_prop.cpp
View file @
f6637801
...
...
@@ -57,6 +57,7 @@ TEST(type_prop, broadcast_deduce_incorrect)
try
{
bc
->
propagate_types
();
// Should have thrown, so fail if it didn't
FAIL
()
<<
"Deduced type should disagree with specified type"
;
}
catch
(
const
ngraph_error
&
error
)
...
...
@@ -77,6 +78,7 @@ TEST(type_prop, broadcast_bad_arguments)
try
{
bc
->
propagate_types
();
// Should have thrown, so fail if it didn't
FAIL
()
<<
"Tuple argument to broadcast not detected."
;
}
catch
(
const
ngraph_error
&
error
)
...
...
@@ -94,6 +96,7 @@ void test_binary_bad_arguments_tuple(const shared_ptr<Node>& node)
try
{
node
->
propagate_types
();
// Should have thrown, so fail if it didn't
FAIL
()
<<
"Tuple argument not detected."
;
}
catch
(
const
ngraph_error
&
error
)
...
...
@@ -111,7 +114,8 @@ void test_binary_bad_arguments_views(const shared_ptr<Node>& node)
try
{
node
->
propagate_types
();
FAIL
()
<<
"incompatible view argumenta not detected."
;
// Should have thrown, so fail if it didn't
FAIL
()
<<
"Incompatible view arguments not detected."
;
}
catch
(
const
ngraph_error
&
error
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment