Add asserts to reference to make sure we don't overshoot iterators (#1757)

* Add some asserts to make sure we don't overshoot certain iterators in the reference kernels

* Add missing assertion.hpp include

src/ngraph/runtime/reference/concat.hpp

@@ -18,6 +18,7 @@
 
 #include <cmath>
 
+#include "ngraph/assertion.hpp"
 #include "ngraph/coordinate_transform.hpp"
 
 namespace ngraph
@@ -60,6 +61,9 @@ namespace ngraph
                     CoordinateTransform output_chunk_transform(
                         out_shape, out_start_coord, out_end_coord);
 
+                    NGRAPH_ASSERT(shape_size(input_transform.get_target_shape()) ==
+                                  shape_size(output_chunk_transform.get_target_shape()));
+
                     CoordinateTransform::Iterator output_chunk_it = output_chunk_transform.begin();
 
                     for (const Coordinate& input_coord : input_transform)

src/ngraph/runtime/reference/pad.hpp

@@ -18,6 +18,7 @@
 
 #include <cmath>
 
+#include "ngraph/assertion.hpp"
 #include "ngraph/axis_vector.hpp"
 #include "ngraph/coordinate_transform.hpp"
 
@@ -77,6 +78,9 @@ namespace ngraph
 
                 CoordinateTransform::Iterator output_it = output_transform.begin();
 
+                NGRAPH_ASSERT(shape_size(input_transform.get_target_shape()) ==
+                              shape_size(output_transform.get_target_shape()));
+
                 for (const Coordinate& in_coord : input_transform)
                 {
                     const Coordinate& out_coord = *output_it;

src/ngraph/runtime/reference/replace_slice.hpp

@@ -18,6 +18,7 @@
 
 #include <cmath>
 
+#include "ngraph/assertion.hpp"
 #include "ngraph/coordinate_transform.hpp"
 
 namespace ngraph
@@ -49,6 +50,9 @@ namespace ngraph
                 CoordinateTransform output_transform(
                     out_shape, lower_bounds, upper_bounds, strides);
 
+                NGRAPH_ASSERT(shape_size(input_transform.get_target_shape()) ==
+                              shape_size(output_transform.get_target_shape()));
+
                 CoordinateTransform::Iterator output_it = output_transform.begin();
 
                 for (const Coordinate& input_coord : input_transform)

src/ngraph/runtime/reference/reshape.hpp

@@ -18,6 +18,7 @@
 
 #include <cmath>
 
+#include "ngraph/assertion.hpp"
 #include "ngraph/axis_vector.hpp"
 #include "ngraph/coordinate_transform.hpp"
 
@@ -41,8 +42,11 @@ namespace ngraph
 
                 CoordinateTransform input_transform(
                     in_shape, in_start_corner, in_shape, in_strides, in_axis_order);
-
                 CoordinateTransform output_transform(out_shape);
+
+                NGRAPH_ASSERT(shape_size(input_transform.get_target_shape()) ==
+                              shape_size(output_transform.get_target_shape()));
+
                 CoordinateTransform::Iterator output_it = output_transform.begin();
 
                 for (const Coordinate& input_coord : input_transform)

src/ngraph/runtime/reference/slice.hpp

@@ -18,6 +18,7 @@
 
 #include <cmath>
 
+#include "ngraph/assertion.hpp"
 #include "ngraph/coordinate_transform.hpp"
 
 namespace ngraph
@@ -40,6 +41,9 @@ namespace ngraph
 
                 CoordinateTransform::Iterator output_it = output_transform.begin();
 
+                NGRAPH_ASSERT(shape_size(input_transform.get_target_shape()) ==
+                              shape_size(output_transform.get_target_shape()));
+
                 for (const Coordinate& in_coord : input_transform)
                 {
                     const Coordinate& out_coord = *output_it;