Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
N
ngraph
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
ngraph
Commits
e8138511
Commit
e8138511
authored
Jan 29, 2018
by
Jaikrishnan Menon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
CPU: change TODO
parent
dd1c264a
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
cpu_emitter.cpp
src/ngraph/runtime/cpu/cpu_emitter.cpp
+4
-4
No files found.
src/ngraph/runtime/cpu/cpu_emitter.cpp
View file @
e8138511
...
@@ -1853,7 +1853,7 @@ void runtime::cpu::CPU_Emitter::EmitConvolution(codegen::CodeWriter& writer,
...
@@ -1853,7 +1853,7 @@ void runtime::cpu::CPU_Emitter::EmitConvolution(codegen::CodeWriter& writer,
images_dilated
=
images_dilated
||
(
s
!=
1
);
images_dilated
=
images_dilated
||
(
s
!=
1
);
}
}
// TODO: MKLDNN streams should be static so we need to either implement
// TODO
(jmenon)
: MKLDNN streams should be static so we need to either implement
// codegen for statics or move primitive and stream construction out
// codegen for statics or move primitive and stream construction out
// of the generated function and only generate code to run/rerun the stream
// of the generated function and only generate code to run/rerun the stream
...
@@ -1975,9 +1975,9 @@ void runtime::cpu::CPU_Emitter::EmitMaxPool(codegen::CodeWriter& writer,
...
@@ -1975,9 +1975,9 @@ void runtime::cpu::CPU_Emitter::EmitMaxPool(codegen::CodeWriter& writer,
auto
result_shape
=
out
[
0
].
get_shape
();
auto
result_shape
=
out
[
0
].
get_shape
();
// TODO: Optimize for 1D
// TODO
(jmenon)
: Optimize for 1D
// TODO: Remove element type restriction
// TODO
(jmenon)
: Remove element type restriction
if
(
arg_rank
==
4
&&
max_pool
->
get_window_shape
().
size
()
==
2
&&
if
(
arg_rank
==
4
&&
max_pool
->
get_window_shape
().
size
()
==
2
&&
args
[
0
].
get_element_type
()
==
element
::
f32
)
args
[
0
].
get_element_type
()
==
element
::
f32
)
{
{
...
@@ -1995,7 +1995,7 @@ void runtime::cpu::CPU_Emitter::EmitMaxPool(codegen::CodeWriter& writer,
...
@@ -1995,7 +1995,7 @@ void runtime::cpu::CPU_Emitter::EmitMaxPool(codegen::CodeWriter& writer,
<<
");
\n
"
;
<<
");
\n
"
;
writer
<<
"auto result = memory({result_desc, cpu_engine}, "
<<
out
[
0
].
get_name
()
<<
");
\n
"
;
writer
<<
"auto result = memory({result_desc, cpu_engine}, "
<<
out
[
0
].
get_name
()
<<
");
\n
"
;
// TODO: Use a workspace
// TODO
(jmenon)
: Use a workspace
writer
<<
"auto max_pooling = pooling_forward({"
writer
<<
"auto max_pooling = pooling_forward({"
<<
"{prop_kind::forward_inference, algorithm::pooling_max, "
<<
"{prop_kind::forward_inference, algorithm::pooling_max, "
<<
"input_data_desc, result_desc, {"
<<
join
(
max_pool
->
get_window_movement_strides
())
<<
"input_data_desc, result_desc, {"
<<
join
(
max_pool
->
get_window_movement_strides
())
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment