Klocwork issues (#4442)

src/ngraph/node.cpp

@@ -116,7 +116,6 @@ std::shared_ptr<Node> Node::copy_with_new_args(const NodeVector& args) const
 {
     NODE_VALIDATION_CHECK(
         this, false, "Internal error: copy_with_new_args not replaced by clone_with_new_inputs");
-    return nullptr;
 }
 
 std::shared_ptr<Node> Node::clone_with_new_inputs(const OutputVector& inputs) const

src/ngraph/node.hpp

@@ -558,6 +558,7 @@ namespace ngraph
         }
         RawNodeOutput(const RawNodeOutput&) = default;
         RawNodeOutput() = default;
+        RawNodeOutput& operator=(const RawNodeOutput&) = default;
 
         Node* node;
         size_t index{0};

src/ngraph/op/constant.hpp

@@ -94,6 +94,7 @@ namespace ngraph
                 Constant(const element::Type& type, const Shape& shape, const void* data);
 
                 Constant(const Constant& other);
+                Constant& operator=(const Constant&) = delete;
 
                 virtual ~Constant() override;
 

src/ngraph/pass/algebraic_simplification.cpp

@@ -575,7 +575,7 @@ bool pass::AlgebraicSimplification::run_on_function(shared_ptr<Function> f)
         auto eh = ops_to_simplifiers.find(n->get_type_info());
         if (eh != ops_to_simplifiers.end())
         {
-            replaced |= eh->second(n);
+            replaced = eh->second(n) || replaced;
         }
     }
     return replaced;

test/util/test_case.hpp

@@ -84,7 +84,7 @@ namespace ngraph
                              "Input data shape must be provided, if shape defined in Functions is "
                              "not fully known.");
 
-                return add_input<T>(input_pshape.to_shape(), values);
+                add_input<T>(input_pshape.to_shape(), values);
             }
 
             template <typename T>