[MLIR] Remove warnings (unused code + wrong neg op) (#3512)

src/contrib/mlir/dialect/ops.cpp

@@ -199,7 +199,7 @@ mlir::LogicalResult verifyOp(NGGatherOp* op)
     NGTensorType resType = r0.cast<NGTensorType>();
 
     // ensure result is compatible with input
-    if (!resType.getRank() == inputType.getRank() + indicesType.getRank() - 1)
+    if (resType.getRank() != inputType.getRank() + indicesType.getRank() - 1)
         return op->emitOpError("Incompatible result shape and/or type");
 
     return mlir::success();

src/contrib/mlir/lowerer.cpp

@@ -127,11 +127,6 @@ namespace
         SmallVector<Value*, 4> buildOutputDefs(Operation* op, PatternRewriter& rewriter);
         Value* createTempTensor(Type type, PatternRewriter& rewriter);
 
-        mlir::FuncOp getCallDecl(StringRef name,
-                                 ArrayRef<Type> args,
-                                 ArrayRef<Type> output,
-                                 PatternRewriter& rewriter);
-
         /// Inserts dealloc Ops for each temporary allocated by AllocOp
         void insertDeallocs(PatternRewriter& rewriter);
 
@@ -143,7 +138,6 @@ namespace
         void findOutputValues();
         void processFakeInstrs();
         void insertNoAliasArgAttrs();
-        Value* insertMemMgrDef(PatternRewriter* rewriter = nullptr);
 
     private:
         NGraphTypeConverter typeConverter;
@@ -230,21 +224,6 @@ namespace
         loweredOutputValues.resize(outputCount, nullptr);
     }
 
-    /// Inserts a fake def for Mem Mgr pointer at converted func start
-    Value* DialectLoweringPass::insertMemMgrDef(PatternRewriter* rewriter)
-    {
-        // it would be nice to insert one fake def at the start of the new func
-        // however, due to how DialectConversion framework works, new func is only
-        // materialized after conversion is done (rewriter->getFunction, or even
-        // rewriter->getInsertionBlock()->getFunction() will give you the original func). This
-        // makes it very convoluted to insert instructions at entry block.
-        auto op = rewriter->create<NGFakeInputOp>(rewriter->getUnknownLoc(),
-                                                  IndexType::get(&getContext()));
-        // will be fixed later to read passed arg instead.
-        memMgrDefs.push_back(op.getResult());
-        return op.getResult();
-    }
-
     SmallVector<Value*, 4> DialectLoweringPass::buildOutputDefs(Operation* op,
                                                                 PatternRewriter& rewriter)
     {
@@ -368,21 +347,6 @@ namespace
         }
     }
 
-    mlir::FuncOp DialectLoweringPass::getCallDecl(StringRef name,
-                                                  ArrayRef<Type> args,
-                                                  ArrayRef<Type> output,
-                                                  PatternRewriter& rewriter)
-    {
-        auto callBackFunc = getModule().lookupSymbol<mlir::FuncOp>(name);
-        if (!callBackFunc)
-        {
-            auto callBackType = rewriter.getFunctionType(args, output);
-            auto callBackFunc = mlir::FuncOp::create(rewriter.getUnknownLoc(), name, callBackType);
-            getModule().push_back(callBackFunc);
-        }
-        return callBackFunc;
-    }
-
     // NGDialect converters
     Type NGraphTypeConverter::convertType(Type type)
     {