Commit 9a7ddbc0 authored by adstraw's avatar adstraw Committed by Robert Kimball

mark convolution and pooling as non-functionally equivalent (temp workaround) (#435)

* mark convolution and pooling as non-functionally equivalent
temporary workaround for MKLDNN issue

* fix build warning
parent d86dce5d
......@@ -201,6 +201,10 @@ op::AvgPool::AvgPool(const std::shared_ptr<Node>& arg, const Shape& window_shape
bool op::AvgPool::is_functionally_identical(const Node& other) const
{
// TODO: temporary workaround for MKLDNN issue
// remove 'return false' and uncomment below when fixed
return false;
/*
bool rc = true;
if (Node::is_functionally_identical(other))
{
......@@ -215,6 +219,7 @@ bool op::AvgPool::is_functionally_identical(const Node& other) const
rc = false;
}
return rc;
*/
}
op::AvgPoolBprop::AvgPoolBprop(const std::shared_ptr<Node>& arg,
......
......@@ -371,6 +371,10 @@ std::shared_ptr<Node>
bool op::Convolution::is_functionally_identical(const Node& other) const
{
// TODO: temporary workaround for MKLDNN issue
// remove 'return false' and uncomment below when fixed
return false;
/*
bool rc = true;
if (Node::test_identical(other))
{
......@@ -386,6 +390,7 @@ bool op::Convolution::is_functionally_identical(const Node& other) const
rc = false;
}
return rc;
*/
}
void op::Convolution::generate_adjoints(autodiff::Adjoints& adjoints,
......
......@@ -159,6 +159,10 @@ op::MaxPool::MaxPool(const std::shared_ptr<Node>& arg, const Shape& window_shape
bool op::MaxPool::is_functionally_identical(const Node& other) const
{
// TODO: temporary workaround for MKLDNN issue
// remove 'return false' and uncomment below when fixed
return false;
/*
bool rc = true;
if (Node::test_identical(other))
{
......@@ -171,6 +175,7 @@ bool op::MaxPool::is_functionally_identical(const Node& other) const
rc = false;
}
return rc;
*/
}
void op::MaxPool::generate_adjoints(autodiff::Adjoints& adjoints,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment