Restore DEFAULT_FLOAT_TOLERANCE_BITS logic in lrn, sigmoid, softmax. Should…

Restore DEFAULT_FLOAT_TOLERANCE_BITS logic in lrn, sigmoid, softmax. Should allow re-enabling PlaidML tests (#3285)

src/ngraph/runtime/plaidml/unit_test.manifest

@@ -315,16 +315,3 @@ avg_pool_3d_uneven_strided_padded
 rnn_cell_activation_function
 gru_cell_bias_clip
 gru_cell_linear_before_reset
-
-# After https://github.com/NervanaSystems/ngraph/pull/3262, these tests began
-# failing with what appear to be precision issues. That PR simply split the
-# old "backend_test.in.cpp" into multiple files. The only relevant side effect
-# I can think of here is that the order of test execution changed as a result.
-softmax_all
-softmax_axis
-softmax_underflow
-softmax_overflow
-sigmoid_n1c1h2w2
-sigmoid_n1c1h4
-sigmoid_bprop_n1c1h4
-lrn

test/backend/lrn.in.cpp

@@ -14,6 +14,16 @@
 // limitations under the License.
 //*****************************************************************************
 
+// clang-format off
+#ifdef ${BACKEND_NAME}_FLOAT_TOLERANCE_BITS
+#define DEFAULT_FLOAT_TOLERANCE_BITS ${BACKEND_NAME}_FLOAT_TOLERANCE_BITS
+#endif
+
+#ifdef ${BACKEND_NAME}_DOUBLE_TOLERANCE_BITS
+#define DEFAULT_DOUBLE_TOLERANCE_BITS ${BACKEND_NAME}_DOUBLE_TOLERANCE_BITS
+#endif
+// clang-format on
+
 #include "gtest/gtest.h"
 #include "ngraph/ngraph.hpp"
 #include "util/all_close.hpp"

test/backend/sigmoid.in.cpp

@@ -14,6 +14,16 @@
 // limitations under the License.
 //*****************************************************************************
 
+// clang-format off
+#ifdef ${BACKEND_NAME}_FLOAT_TOLERANCE_BITS
+#define DEFAULT_FLOAT_TOLERANCE_BITS ${BACKEND_NAME}_FLOAT_TOLERANCE_BITS
+#endif
+
+#ifdef ${BACKEND_NAME}_DOUBLE_TOLERANCE_BITS
+#define DEFAULT_DOUBLE_TOLERANCE_BITS ${BACKEND_NAME}_DOUBLE_TOLERANCE_BITS
+#endif
+// clang-format on
+
 #include "gtest/gtest.h"
 #include "ngraph/ngraph.hpp"
 #include "util/all_close.hpp"

test/backend/softmax.in.cpp

@@ -14,6 +14,16 @@
 // limitations under the License.
 //*****************************************************************************
 
+// clang-format off
+#ifdef ${BACKEND_NAME}_FLOAT_TOLERANCE_BITS
+#define DEFAULT_FLOAT_TOLERANCE_BITS ${BACKEND_NAME}_FLOAT_TOLERANCE_BITS
+#endif
+
+#ifdef ${BACKEND_NAME}_DOUBLE_TOLERANCE_BITS
+#define DEFAULT_DOUBLE_TOLERANCE_BITS ${BACKEND_NAME}_DOUBLE_TOLERANCE_BITS
+#endif
+// clang-format on
+
 #include "gtest/gtest.h"
 #include "ngraph/ngraph.hpp"
 #include "util/all_close.hpp"