Skip to content

N
ngraph
Commit 9664b96f authored by mbencer's avatar mbencer
Browse files
Options

Code review remakrs introduced

parent 310fcf07
Hide whitespace changes
Inline Side-by-side
Showing with 24 additions and 23 deletions
src/ngraph/builder/split.cpp
View file @ 9664b96f
......@@ -104,7 +104,7 @@ NodeVector builder::opset1::split(const Output<Node>& value,
const std::vector<size_t>& split_lengths,
int64_t axis)
{
const auto axis_node = op::Constant::create(element::u64, Shape{}, {axis});
const auto axis_node = ngraph::opset1::Constant::create(element::u64, Shape{}, {axis});
const auto split_lengths_node =
ngraph::opset1::Constant::create(element::u64, Shape{split_lengths.size()}, split_lengths);
const auto variadic_split =
......
src/ngraph/builder/split.hpp
View file @ 9664b96f
......@@ -23,11 +23,11 @@ namespace ngraph
{
namespace builder
{
/// \brief Split value on specified axis into multiple parts.
/// \brief Split value on specified axis into multiple parts.
///
/// \param[in] value The value to be split.
/// \param[in] length_parts The vector defining the lengths of each split part.
/// \param[in] axis The axis we split input node on. Default value is zero axis.
/// \param value The value to be split.
/// \param length_parts The vector defining the lengths of each split part.
/// \param axis The axis we split input node on. Default value is zero axis.
///
/// \return The vector containing multiple nodes we split input node into.
///
......@@ -37,11 +37,11 @@ namespace ngraph
/// \brief Split node on specified axis into multiple parts.
///
/// \param[in] value The value to split.
/// \param[in] split_parts The number of parts we want to split output at given
/// axis. The length of the axis to split must be divisible by
/// this value.
/// \param[in] axis The axis we split input node on. Default value is zero axis.
/// \param value The value to split.
/// \param split_parts The number of parts we want to split output at given
/// axis. The length of the axis to split must be divisible by
/// this value.
/// \param axis The axis we split input node on. Default value is zero axis.
///
/// \note This implementation supports negative `axis` values (similar to NumPy
/// indexing). This means that the axis to split on will be counted from
......@@ -55,10 +55,10 @@ namespace ngraph
{
/// \brief Split value on specified axis into multiple parts.
///
/// \param[in] value The value to be split.
/// \param[in] split_lengths The vector defining the lengths of each split part.
/// \param[in] axis The axis we split input node on. Default value is zero
/// axis.
/// \param value The value to be split.
/// \param split_lengths The vector defining the lengths of each split part.
/// \param axis The axis we split input node on. Default value is zero
/// axis.
/// \note This implementation supports negative `axis` values (similar to NumPy
/// indexing). This means that the axis to split on will be counted from
/// the back of the tensor (negative values are subtracted from its rank).
......@@ -70,14 +70,14 @@ namespace ngraph
const std::vector<size_t>& split_lengths,
int64_t axis = 0);
/// \brief Split node on specified axis into multiple parts.
/// \brief Split value on specified axis into multiple parts.
///
/// \param[in] value The value to split.
/// \param[in] num_splits The number of parts we want to split output at given
/// axis. The length of the axis to split must be divisible by
/// this value.
/// \param[in] axis The axis we split input node on. Default value is zero
/// axis.
/// \param value The value to split.
/// \param num_splits The number of parts we want to split output at given
/// axis. The length of the axis to split must be divisible by
/// this value.
/// \param axis The axis we split input node on. Default value is zero
/// axis.
///
/// \note This implementation supports negative `axis` values (similar to NumPy
/// indexing). This means that the axis to split on will be counted from
......
src/ngraph/frontend/onnx_import/utils/pooling_factory.hpp
View file @ 9664b96f
......@@ -78,7 +78,7 @@ namespace ngraph
///
/// \brief Factory class which generates sub-graphs for ONNX 'local' pooling
/// operators.
/// \note Kernel shape attribute is required
/// \note For a 'local' pooling operation, the kernel shape attribute is required
class LocalPoolingFactory : public PoolingFactory
{
public:
......@@ -89,7 +89,8 @@ namespace ngraph
///
/// \brief Factory class which generates sub-graphs for ONNX 'global' pooling
/// operators.
/// \note Kernel shape is calculated based on spatial dims
/// \note In a 'global' pooling operation, the kernel shape is calculated
/// based on spatial dims
class GlobalPoolingFactory : public PoolingFactory
{
public:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment