remove unimplemented Remainder op (#1631)

src/ngraph/CMakeLists.txt

@@ -84,7 +84,6 @@ set (SRC
     op/reduce.cpp
     op/reduce_window.cpp
     op/relu.cpp
-    op/remainder.cpp
     op/replace_slice.cpp
     op/reshape.cpp
     op/result.cpp

src/ngraph/ngraph.hpp

@@ -107,7 +107,6 @@
 #include "ngraph/op/reduce.hpp"
 #include "ngraph/op/reduce_window.hpp"
 #include "ngraph/op/relu.hpp"
-#include "ngraph/op/remainder.hpp"
 #include "ngraph/op/replace_slice.hpp"
 #include "ngraph/op/reshape.hpp"
 #include "ngraph/op/reverse.hpp"

src/ngraph/op/remainder.cpp

-//*****************************************************************************
-// Copyright 2017-2018 Intel Corporation
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//*****************************************************************************
-
-#include "ngraph/op/remainder.hpp"
-
-using namespace std;
-using namespace ngraph;
-
-op::Remainder::Remainder(const shared_ptr<Node>& arg0, const shared_ptr<Node>& arg1)
-    : BinaryElementwiseArithmetic("Remainder", arg0, arg1)
-{
-    constructor_validate_and_infer_types();
-}
-
-shared_ptr<Node> op::Remainder::copy_with_new_args(const NodeVector& new_args) const
-{
-    check_new_args_count(this, new_args);
-    return make_shared<Remainder>(new_args.at(0), new_args.at(1));
-}

src/ngraph/op/remainder.hpp

-//*****************************************************************************
-// Copyright 2017-2018 Intel Corporation
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//*****************************************************************************
-
-#pragma once
-
-#include "ngraph/op/util/binary_elementwise_arithmetic.hpp"
-
-namespace ngraph
-{
-    namespace op
-    {
-        /// \brief (NOT IMPLEMENTED) Elementwise remainder operation.
-        ///
-        /// (TODO: Get a bit more clarity on this: is it just "mod"? What about negative numbers and floats?)
-        ///
-        /// ## Inputs
-        ///
-        /// |        | Type                              | Description                                            |
-        /// | ------ | --------------------------------- | ------------------------------------------------------ |
-        /// | `arg0` | \f$N[d_1,\dots,d_n]~(n \geq 0)\f$ | A tensor of any shape and numeric element type.        |
-        /// | `arg1` | \f$N[d_1,\dots,d_n]~(n \geq 0)\f$ | A tensor of the same shape and element type as `arg0`. |
-        ///
-        /// ## Output
-        ///
-        /// | Type                   | Description                                                                                                       |
-        /// | ---------------------- | ----------------------------------------------------------------------------------------------------------------- |
-        /// | \f$N[d_1,\dots,d_n]\f$ | The tensor \f$T\f$, where \f$T[i_1,\dots,i_n] = \texttt{arg0}[i_1,\dots,i_n] \mod \texttt{arg1}[i_1,\dots,i_n]\f$ |
-        class Remainder : public util::BinaryElementwiseArithmetic
-        {
-        public:
-            /// \brief Constructs a remainder operation.
-            ///
-            /// \param arg0 Node that produces the first input tensor.
-            /// \param arg1 Node that produces the second input tensor.
-            Remainder(const std::shared_ptr<Node>& arg0, const std::shared_ptr<Node>& arg1);
-
-            virtual std::shared_ptr<Node>
-                copy_with_new_args(const NodeVector& new_args) const override;
-        };
-    }
-}

src/ngraph/pass/cse.cpp

@@ -46,7 +46,6 @@
 #include "ngraph/op/power.hpp"
 #include "ngraph/op/product.hpp"
 #include "ngraph/op/relu.hpp"
-#include "ngraph/op/remainder.hpp"
 #include "ngraph/op/reshape.hpp"
 #include "ngraph/op/sigmoid.hpp"
 #include "ngraph/op/sign.hpp"
@@ -162,7 +161,6 @@ static std::unordered_map<std::type_index,
          {TI(op::Minimum), cse_binarywise},
          {TI(op::Multiply), cse_binarywise},
          {TI(op::Power), cse_binarywise},
-         //{TI(op::Remainder), cse_binarywise},
          {TI(op::Subtract), cse_binarywise},
          {TI(op::Sum), cse_reduction},
          {TI(op::Product), cse_reduction},

src/ngraph/runtime/cpu/cpu_emitter.cpp

@@ -74,7 +74,6 @@
 #include "ngraph/op/reduce.hpp"
 #include "ngraph/op/reduce_window.hpp"
 #include "ngraph/op/relu.hpp"
-#include "ngraph/op/remainder.hpp"
 #include "ngraph/op/replace_slice.hpp"
 #include "ngraph/op/reshape.hpp"
 #include "ngraph/op/result.hpp"

src/ngraph/runtime/cpu/cpu_external_function.cpp

@@ -97,7 +97,6 @@
 #include "ngraph/op/reduce.hpp"
 #include "ngraph/op/reduce_window.hpp"
 #include "ngraph/op/relu.hpp"
-#include "ngraph/op/remainder.hpp"
 #include "ngraph/op/replace_slice.hpp"
 #include "ngraph/op/reshape.hpp"
 #include "ngraph/op/result.hpp"

src/ngraph/runtime/gpu/gpu_emitter.cpp

@@ -75,7 +75,6 @@
 #include "ngraph/op/reduce.hpp"
 #include "ngraph/op/reduce_window.hpp"
 #include "ngraph/op/relu.hpp"
-#include "ngraph/op/remainder.hpp"
 #include "ngraph/op/replace_slice.hpp"
 #include "ngraph/op/reshape.hpp"
 #include "ngraph/op/result.hpp"

src/ngraph/runtime/gpu/gpu_external_function.cpp

@@ -79,7 +79,6 @@
 #include "ngraph/op/reduce.hpp"
 #include "ngraph/op/reduce_window.hpp"
 #include "ngraph/op/relu.hpp"
-#include "ngraph/op/remainder.hpp"
 #include "ngraph/op/replace_slice.hpp"
 #include "ngraph/op/reshape.hpp"
 #include "ngraph/op/result.hpp"

test/copy.cpp

@@ -310,11 +310,6 @@ TEST(copy, reduce)
     EXPECT_TRUE(axes == node_cast->get_reduction_axes());
 }
 
-TEST(copy, remainder)
-{
-    ASSERT_TRUE(check_binary<op::Remainder>());
-}
-
 TEST(copy, reshape)
 {
     Shape shape_in{2, 3, 4};

test/includes.cpp

@@ -103,7 +103,6 @@ TEST(DISABLED_include, complete)
                                     "ngraph/op/reduce.hpp",
                                     "ngraph/op/reduce_window.hpp",
                                     "ngraph/op/relu.hpp",
-                                    "ngraph/op/remainder.hpp",
                                     "ngraph/op/replace_slice.hpp",
                                     "ngraph/op/reshape.hpp",
                                     "ngraph/op/reverse.hpp",