Commit 72010e76 authored by Jaikrishnan Menon's avatar Jaikrishnan Menon

Review comments

parent 910743cd
...@@ -228,7 +228,7 @@ void runtime::cpu::CPU_ExternalFunction::compile() ...@@ -228,7 +228,7 @@ void runtime::cpu::CPU_ExternalFunction::compile()
pass_manager.register_pass<runtime::cpu::pass::CPULayout>(); pass_manager.register_pass<runtime::cpu::pass::CPULayout>();
pass_manager.register_pass<ngraph::pass::Liveness>(); pass_manager.register_pass<ngraph::pass::Liveness>();
pass_manager.register_pass<ngraph::pass::MemoryLayout>(64); pass_manager.register_pass<ngraph::pass::MemoryLayout>(MemoryPoolAlignment);
pass_manager.run_passes(m_function); pass_manager.run_passes(m_function);
codegen::CodeWriter writer; codegen::CodeWriter writer;
......
...@@ -92,10 +92,6 @@ namespace ngraph ...@@ -92,10 +92,6 @@ namespace ngraph
if (offset != p_other->offset) if (offset != p_other->offset)
return false; return false;
//TODO: Numeric backend-specific properties
// if (mkldnn_format != p_other->mkldnn_format)
// return false;
return true; return true;
} }
} }
......
...@@ -47,11 +47,6 @@ const Strides& runtime::TensorView::get_strides() const ...@@ -47,11 +47,6 @@ const Strides& runtime::TensorView::get_strides() const
return m_descriptor->get_tensor_view_layout()->get_strides(); return m_descriptor->get_tensor_view_layout()->get_strides();
} }
const element::Type& runtime::TensorView::get_element_type() const
{
return m_descriptor->get_tensor_view_type()->get_element_type();
}
shared_ptr<descriptor::layout::TensorViewLayout> runtime::TensorView::get_tensor_view_layout() const shared_ptr<descriptor::layout::TensorViewLayout> runtime::TensorView::get_tensor_view_layout() const
{ {
return m_descriptor->get_tensor_view_layout(); return m_descriptor->get_tensor_view_layout();
......
...@@ -53,7 +53,6 @@ namespace ngraph ...@@ -53,7 +53,6 @@ namespace ngraph
const ngraph::Shape& get_shape() const; const ngraph::Shape& get_shape() const;
const ngraph::Strides& get_strides() const; const ngraph::Strides& get_strides() const;
const ngraph::element::Type& get_element_type() const;
size_t get_element_count() const; size_t get_element_count() const;
const ngraph::descriptor::Tensor& get_tensor() const; const ngraph::descriptor::Tensor& get_tensor() const;
......
...@@ -40,7 +40,7 @@ void copy_data(std::shared_ptr<ngraph::runtime::TensorView> tv, const std::vecto ...@@ -40,7 +40,7 @@ void copy_data(std::shared_ptr<ngraph::runtime::TensorView> tv, const std::vecto
template <typename T> template <typename T>
std::vector<T> read_vector(std::shared_ptr<ngraph::runtime::TensorView> tv) std::vector<T> read_vector(std::shared_ptr<ngraph::runtime::TensorView> tv)
{ {
if (ngraph::element::from<T>() != tv->get_element_type()) if (ngraph::element::from<T>() != tv->get_tensor_view_layout()->get_element_type())
{ {
throw std::invalid_argument("read_vector type must match TensorView type"); throw std::invalid_argument("read_vector type must match TensorView type");
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment