Commit 619b3f84 authored by Adam Procter's avatar Adam Procter

Comment cleanup, minor simplification

parent 3deed15c
...@@ -86,14 +86,12 @@ bool PartialShape::compatible(const PartialShape& s) const ...@@ -86,14 +86,12 @@ bool PartialShape::compatible(const PartialShape& s) const
{ {
return false; return false;
} }
// If we know both the ranks and they are equal, we check each component elementwise. We are // If we know both the ranks and they are equal, then *this and s are compatible iff they
// compatible iff the shapes are elementwise compatible. // are elementwise compatible everywhere.
else else
{ {
for (size_t i = 0; i < size_t(s.rank()); i++) for (size_t i = 0; i < size_t(rank()); i++)
{ {
// If we don't know that these two corresponding elements are equal, we don't know
// that s1 and s2 are equal.
if (!m_dimensions[i].compatible(s.m_dimensions[i])) if (!m_dimensions[i].compatible(s.m_dimensions[i]))
{ {
return false; return false;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment