Rename auto broadcast parameter name in constructors (#3437)

* Renamed auto broadcast name in constructors

* Fixed argument doc for Or op

* Changed names of fields to serialization

* Changed name of auto_broadcast in XOR op

* Clang styles applied

src/ngraph/op/add.cpp

@@ -21,8 +21,10 @@ using namespace ngraph;
 
 const string op::Add::type_name{"Add"};
 
-op::Add::Add(const Output<Node>& arg0, const Output<Node>& arg1, const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+op::Add::Add(const Output<Node>& arg0,
+             const Output<Node>& arg1,
+             const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/add.hpp

@@ -41,13 +41,13 @@ namespace ngraph
             /// `[d0, ...]`
             /// \param arg1 Output that produces the second input tensor.<br>
             /// `[d0, ...]`
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             ///
             /// Output `[d0, ...]`
             ///
             Add(const Output<Node>& arg0,
                 const Output<Node>& arg1,
-                const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             std::shared_ptr<Node> copy_with_new_args(const NodeVector& new_args) const override;
 

src/ngraph/op/and.cpp

@@ -21,8 +21,10 @@ using namespace ngraph;
 
 const string op::And::type_name{"And"};
 
-op::And::And(const Output<Node>& arg0, const Output<Node>& arg1, const AutoBroadcastSpec& autob)
-    : BinaryElementwiseLogical(arg0, arg1, autob)
+op::And::And(const Output<Node>& arg0,
+             const Output<Node>& arg1,
+             const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseLogical(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/and.hpp

@@ -41,13 +41,13 @@ namespace ngraph
             /// `[d0, ...]`
             /// \param arg1 Output that produces the second input tensor.<br>
             /// `[d0, ...]`
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             ///
             /// Output `[d0, ...]`
             ///
             And(const Output<Node>& arg0,
                 const Output<Node>& arg1,
-                const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             std::shared_ptr<Node> copy_with_new_args(const NodeVector& new_args) const override;
 

src/ngraph/op/divide.cpp

@@ -25,8 +25,8 @@ const string op::Divide::type_name{"Divide"};
 
 op::Divide::Divide(const Output<Node>& arg0,
                    const Output<Node>& arg1,
-                   const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+                   const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }
@@ -34,8 +34,8 @@ op::Divide::Divide(const Output<Node>& arg0,
 op::Divide::Divide(const Output<Node>& arg0,
                    const Output<Node>& arg1,
                    bool pythondiv,
-                   const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+                   const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
     , m_pythondiv(pythondiv)
 {
     constructor_validate_and_infer_types();

src/ngraph/op/divide.hpp

@@ -36,20 +36,20 @@ namespace ngraph
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
             /// \param pythondiv Use Python style rounding for integral type
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Divide(const Output<Node>& arg0,
                    const Output<Node>& arg1,
                    bool pythondiv,
-                   const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                   const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             /// \brief Constructs a division operation.
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Divide(const Output<Node>& arg0,
                    const Output<Node>& arg1,
-                   const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                   const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             bool is_pythondiv() const { return m_pythondiv; }
             void set_is_pythondiv(bool pythondiv) { m_pythondiv = pythondiv; }

src/ngraph/op/equal.cpp

@@ -21,8 +21,10 @@ using namespace ngraph;
 
 const string op::Equal::type_name{"Equal"};
 
-op::Equal::Equal(const Output<Node>& arg0, const Output<Node>& arg1, const AutoBroadcastSpec& autob)
-    : BinaryElementwiseComparison(arg0, arg1, autob)
+op::Equal::Equal(const Output<Node>& arg0,
+                 const Output<Node>& arg1,
+                 const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseComparison(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/equal.hpp

@@ -51,10 +51,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Equal(const Output<Node>& arg0,
                   const Output<Node>& arg1,
-                  const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                  const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/greater.cpp

@@ -23,8 +23,8 @@ const string op::Greater::type_name{"Greater"};
 
 op::Greater::Greater(const Output<Node>& arg0,
                      const Output<Node>& arg1,
-                     const AutoBroadcastSpec& autob)
-    : BinaryElementwiseComparison(arg0, arg1, autob)
+                     const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseComparison(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/greater.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Greater(const Output<Node>& arg0,
                     const Output<Node>& arg1,
-                    const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                    const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/greater_eq.cpp

@@ -23,8 +23,8 @@ const string op::GreaterEq::type_name{"GreaterEq"};
 
 op::GreaterEq::GreaterEq(const Output<Node>& arg0,
                          const Output<Node>& arg1,
-                         const AutoBroadcastSpec& autob)
-    : BinaryElementwiseComparison(arg0, arg1, autob)
+                         const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseComparison(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/greater_eq.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             GreaterEq(const Output<Node>& arg0,
                       const Output<Node>& arg1,
-                      const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                      const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/less.cpp

@@ -21,8 +21,10 @@ using namespace ngraph;
 
 const string op::Less::type_name{"Less"};
 
-op::Less::Less(const Output<Node>& arg0, const Output<Node>& arg1, const AutoBroadcastSpec& autob)
-    : BinaryElementwiseComparison(arg0, arg1, autob)
+op::Less::Less(const Output<Node>& arg0,
+               const Output<Node>& arg1,
+               const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseComparison(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/less.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Less(const Output<Node>& arg0,
                  const Output<Node>& arg1,
-                 const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                 const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/less_eq.cpp

@@ -23,8 +23,8 @@ const string op::LessEq::type_name{"LessEq"};
 
 op::LessEq::LessEq(const Output<Node>& arg0,
                    const Output<Node>& arg1,
-                   const AutoBroadcastSpec& autob)
-    : BinaryElementwiseComparison(arg0, arg1, autob)
+                   const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseComparison(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/less_eq.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             LessEq(const Output<Node>& arg0,
                    const Output<Node>& arg1,
-                   const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                   const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/maximum.cpp

@@ -29,8 +29,8 @@ const string op::Maximum::type_name{"Maximum"};
 
 op::Maximum::Maximum(const Output<Node>& arg0,
                      const Output<Node>& arg1,
-                     const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+                     const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/maximum.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Maximum(const Output<Node>& arg0,
                     const Output<Node>& arg1,
-                    const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                    const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/minimum.cpp

@@ -29,8 +29,8 @@ const string op::Minimum::type_name{"Minimum"};
 
 op::Minimum::Minimum(const Output<Node>& arg0,
                      const Output<Node>& arg1,
-                     const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+                     const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/minimum.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Minimum(const Output<Node>& arg0,
                     const Output<Node>& arg1,
-                    const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                    const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/multiply.cpp

@@ -23,8 +23,8 @@ const string op::Multiply::type_name{"Multiply"};
 
 op::Multiply::Multiply(const Output<Node>& arg0,
                        const Output<Node>& arg1,
-                       const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+                       const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/multiply.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Multiply(const Output<Node>& arg0,
                      const Output<Node>& arg1,
-                     const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                     const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/not_equal.cpp

@@ -23,8 +23,8 @@ const string op::NotEqual::type_name{"NotEqual"};
 
 op::NotEqual::NotEqual(const Output<Node>& arg0,
                        const Output<Node>& arg1,
-                       const AutoBroadcastSpec& autob)
-    : BinaryElementwiseComparison(arg0, arg1, autob)
+                       const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseComparison(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/not_equal.hpp

@@ -35,10 +35,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             NotEqual(const Output<Node>& arg0,
                      const Output<Node>& arg1,
-                     const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                     const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/or.cpp

@@ -21,8 +21,10 @@ using namespace ngraph;
 
 const string op::Or::type_name{"Or"};
 
-op::Or::Or(const Output<Node>& arg0, const Output<Node>& arg1, const AutoBroadcastSpec& autob)
-    : BinaryElementwiseLogical(arg0, arg1, autob)
+op::Or::Or(const Output<Node>& arg0,
+           const Output<Node>& arg1,
+           const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseLogical(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/or.hpp

@@ -38,13 +38,13 @@ namespace ngraph
             /// `[d0, ...]`
             /// \param arg1 Node that produces the second input tensor.<br>
             /// `[d0, ...]`
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             ///
             /// Output `[d0, ...]`
             ///
             Or(const Output<Node>& arg0,
                const Output<Node>& arg1,
-               const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+               const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/power.cpp

@@ -24,8 +24,10 @@ using namespace ngraph;
 
 const string op::Power::type_name{"Power"};
 
-op::Power::Power(const Output<Node>& arg0, const Output<Node>& arg1, const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+op::Power::Power(const Output<Node>& arg0,
+                 const Output<Node>& arg1,
+                 const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/power.hpp

@@ -49,10 +49,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Power(const Output<Node>& arg0,
                   const Output<Node>& arg1,
-                  const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                  const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/subtract.cpp

@@ -24,8 +24,8 @@ const string op::Subtract::type_name{"Subtract"};
 
 op::Subtract::Subtract(const Output<Node>& arg0,
                        const Output<Node>& arg1,
-                       const AutoBroadcastSpec& autob)
-    : BinaryElementwiseArithmetic(arg0, arg1, autob)
+                       const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseArithmetic(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/subtract.hpp

@@ -34,10 +34,10 @@ namespace ngraph
             ///
             /// \param arg0 Node that produces the first input tensor.
             /// \param arg1 Node that produces the second input tensor.
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             Subtract(const Output<Node>& arg0,
                      const Output<Node>& arg1,
-                     const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                     const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;

src/ngraph/op/xor.cpp

@@ -21,8 +21,10 @@ using namespace ngraph;
 
 const string op::Xor::type_name{"Xor"};
 
-op::Xor::Xor(const Output<Node>& arg0, const Output<Node>& arg1, const AutoBroadcastSpec& autob)
-    : BinaryElementwiseLogical(arg0, arg1, autob)
+op::Xor::Xor(const Output<Node>& arg0,
+             const Output<Node>& arg1,
+             const AutoBroadcastSpec& auto_broadcast)
+    : BinaryElementwiseLogical(arg0, arg1, auto_broadcast)
 {
     constructor_validate_and_infer_types();
 }

src/ngraph/op/xor.hpp

@@ -38,13 +38,13 @@ namespace ngraph
             /// `[d0, ...]`
             /// \param arg1 Node that produces the second input tensor.<br>
             /// `[d0, ...]`
-            /// \param autob Auto broadcast specification
+            /// \param auto_broadcast Auto broadcast specification
             ///
             /// Output `[d0, ...]`
             ///
             Xor(const Output<Node>& arg0,
                 const Output<Node>& arg1,
-                const AutoBroadcastSpec& autob = AutoBroadcastSpec());
+                const AutoBroadcastSpec& auto_broadcast = AutoBroadcastSpec());
 
             virtual std::shared_ptr<Node>
                 copy_with_new_args(const NodeVector& new_args) const override;