Remove redundant using definitions for NodeVector and OutputVector (#4110)

* Fix using statements

* Add missing line ending

* Add license
Co-authored-by: Scott Cyphers <diyessi@users.noreply.github.com>

src/ngraph/autodiff/adjoints.hpp

@@ -21,6 +21,7 @@
 #include <unordered_map>
 
 #include "ngraph/coordinate.hpp"
+#include "ngraph/output_vector.hpp"
 #include "ngraph/strides.hpp"
 
 namespace ngraph
@@ -30,10 +31,6 @@ namespace ngraph
 
     template <typename T>
     class Output;
-    // Need duplicate definition here to avoid g++ issues
-    // Keep consistent with version in node.hpp
-    using NodeVector = std::vector<std::shared_ptr<Node>>;
-    using OutputVector = std::vector<Output<Node>>;
 
     namespace autodiff
     {

src/ngraph/node.hpp

@@ -38,6 +38,7 @@
 #include "ngraph/descriptor/tensor.hpp"
 #include "ngraph/op/util/attr_types.hpp"
 #include "ngraph/op/util/op_annotations.hpp"
+#include "ngraph/output_vector.hpp"
 #include "ngraph/placement.hpp"
 #include "ngraph/strides.hpp"
 #include "ngraph/type.hpp"
@@ -53,8 +54,6 @@ namespace ngraph
     class AttributeVisitor;
     class Variant;
     class Node;
-    using NodeVector = std::vector<std::shared_ptr<Node>>;
-    using OutputVector = std::vector<Output<Node>>;
 
     class Function;
 

src/ngraph/output_vector.hpp

+//*****************************************************************************
+// Copyright 2017-2019 Intel Corporation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//*****************************************************************************
+
+#pragma once
+
+#include <memory>
+#include <vector>
+
+namespace ngraph
+{
+    class Node;
+
+    template <typename T>
+    class Output;
+
+    using NodeVector = std::vector<std::shared_ptr<Node>>;
+    using OutputVector = std::vector<Output<Node>>;
+}