Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
N
ngraph
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
ngraph
Commits
432e037d
Commit
432e037d
authored
Sep 06, 2019
by
mbencer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Code review remarks introduced
parent
c732705f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
10 deletions
+6
-10
normalize_l2.cpp
src/ngraph/op/fused/normalize_l2.cpp
+5
-7
normalize.cpp
test/type_prop/normalize.cpp
+1
-3
No files found.
src/ngraph/op/fused/normalize_l2.cpp
View file @
432e037d
...
...
@@ -42,22 +42,20 @@ op::NormalizeL2::NormalizeL2(const Output<Node>& data,
void
op
::
NormalizeL2
::
pre_validate_and_infer_types
()
{
auto
axes_node
=
input
(
1
).
get_source_output
(
).
get_node_shared_ptr
();
auto
axes_node
=
input
_value
(
1
).
get_node_shared_ptr
();
const
auto
&
input_pshape
=
get_input_partial_shape
(
0
);
const
auto
&
axes_pshape
=
get_input_partial_shape
(
1
);
const
auto
&
input_rank
=
input_pshape
.
rank
();
const
auto
&
axes_rank
=
axes_pshape
.
rank
();
NODE_VALIDATION_CHECK
(
this
,
axes_node
->
is_constant
(),
"doesn't support 'axes' input of other type than a Constant."
);
NODE_VALIDATION_CHECK
(
this
,
axes_node
->
is_constant
(),
"Input axes must be Constant type"
);
if
(
axes_rank
.
is_static
())
{
NODE_VALIDATION_CHECK
(
this
,
static_cast
<
size_t
>
(
axes_
pshape
.
rank
()
)
==
1
,
"Input axes must have rank equals 1 (axes
shape
: "
,
axes_
pshape
,
static_cast
<
size_t
>
(
axes_
rank
)
==
1
,
"Input axes must have rank equals 1 (axes
rank
: "
,
axes_
rank
,
")."
);
if
(
input_rank
.
is_static
())
...
...
test/type_prop/normalize.cpp
View file @
432e037d
...
...
@@ -37,9 +37,7 @@ TEST(type_prop, normalize_axes_input_not_constant)
}
catch
(
const
NodeValidationFailure
&
error
)
{
EXPECT_HAS_SUBSTRING
(
error
.
what
(),
std
::
string
(
"doesn't support 'axes' input of other type than a Constant."
));
EXPECT_HAS_SUBSTRING
(
error
.
what
(),
std
::
string
(
"Input axes must be Constant type"
));
}
catch
(...)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment