Fixed constant operation for u1 format (#4045)

* Fixed bin constant ops

* Added export

* Fixed buffer size

* Fixed code style

src/ngraph/op/constant.hpp

@@ -16,6 +16,7 @@
 
 #pragma once
 
+#include <cmath>
 #include <cstring>
 #include <sstream>
 
@@ -46,8 +47,9 @@ namespace ngraph
             Constant(const element::Type& type, Shape shape, const std::vector<T>& values)
                 : m_element_type(type)
                 , m_shape(shape)
-                , m_data(new runtime::AlignedBuffer(shape_size(m_shape) * m_element_type.size(),
-                                                    host_alignment()))
+                , m_data(new runtime::AlignedBuffer(
+                      std::ceil(shape_size(m_shape) * m_element_type.bitwidth() / 8.f),
+                      host_alignment()))
             {
                 NODE_VALIDATION_CHECK(
                     this,
@@ -82,8 +84,9 @@ namespace ngraph
             Constant(const element::Type& type, Shape shape, const std::vector<std::string>& values)
                 : m_element_type(type)
                 , m_shape(shape)
-                , m_data(new runtime::AlignedBuffer(shape_size(m_shape) * m_element_type.size(),
-                                                    host_alignment()))
+                , m_data(new runtime::AlignedBuffer(
+                      std::ceil(shape_size(m_shape) * m_element_type.bitwidth() / 8.f),
+                      host_alignment()))
             {
                 NODE_VALIDATION_CHECK(
                     this,
@@ -143,9 +146,8 @@ namespace ngraph
                 , m_shape(shape)
                 , m_data(nullptr)
             {
-                size_t size = shape_size(m_shape) * m_element_type.size();
-                m_data.reset(new runtime::AlignedBuffer(shape_size(m_shape) * m_element_type.size(),
-                                                        host_alignment()));
+                size_t size = std::ceil(shape_size(m_shape) * m_element_type.bitwidth() / 8.f);
+                m_data.reset(new runtime::AlignedBuffer(size, host_alignment()));
                 std::memcpy(m_data->get_ptr(), data, size);
                 constructor_validate_and_infer_types();
                 m_all_elements_bitwise_identical = are_all_data_elements_bitwise_identical();

src/ngraph/op/reduce_logical_and.hpp

@@ -28,10 +28,9 @@ namespace ngraph
             ///
             /// The reduction is performed over slices of the first input. The slices shape depends
             /// on the values passed to the second input - the axes.
-            class ReduceLogicalAnd : public util::LogicalReductionKeepDims
+            class NGRAPH_API ReduceLogicalAnd : public util::LogicalReductionKeepDims
             {
             public:
-                NGRAPH_API
                 static constexpr NodeTypeInfo type_info{"ReduceLogicalAnd", 1};
                 const NodeTypeInfo& get_type_info() const override { return type_info; }
                 ReduceLogicalAnd() = default;

src/ngraph/op/reduce_logical_or.hpp

@@ -28,10 +28,9 @@ namespace ngraph
             ///
             /// The reduction is performed over slices of the first input. The slices shape depends
             /// on the values passed to the second input - the axes.
-            class ReduceLogicalOr : public util::LogicalReductionKeepDims
+            class NGRAPH_API ReduceLogicalOr : public util::LogicalReductionKeepDims
             {
             public:
-                NGRAPH_API
                 static constexpr NodeTypeInfo type_info{"ReduceLogicalOr", 1};
                 const NodeTypeInfo& get_type_info() const override { return type_info; }
                 ReduceLogicalOr() = default;

src/ngraph/opsets/opset.hpp

@@ -98,6 +98,6 @@ namespace ngraph
         std::map<std::string, NodeTypeInfo> m_name_type_info_map;
     };
 
-    const OpSet& get_opset0();
-    const OpSet& get_opset1();
+    const NGRAPH_API OpSet& get_opset0();
+    const NGRAPH_API OpSet& get_opset1();
 }
\ No newline at end of file

src/ngraph/specialize_function.hpp

@@ -103,6 +103,7 @@ namespace ngraph
     ///       parameter_shapes[i] can be created.
     ///
     /// TODO(amprocte): convert this to a pass.
+    NGRAPH_API
     std::shared_ptr<Function>
         specialize_function(std::shared_ptr<Function> f,
                             const std::vector<element::Type>& parameter_element_types,
@@ -195,6 +196,7 @@ namespace ngraph
     ///       parameter_shapes[i] can be created.
     ///
     /// TODO(amprocte): convert this to a pass.
+    NGRAPH_API
     std::shared_ptr<Function>
         specialize_function(std::shared_ptr<Function> f,
                             const std::vector<element::Type>& parameter_element_types,

test/convert_u1_to_string.cpp

@@ -32,4 +32,4 @@ TEST(convert_u1_to_string, convert_u1_to_string)
     {
         ASSERT_EQ(constant->convert_value_to_string(i), ref[i]);
     }
-}
\ No newline at end of file
+}