Merge branch 'master' into bob/simple_function_call

CMakeLists.txt

@@ -43,6 +43,9 @@ endif()
 set(CMAKE_DISABLE_SOURCE_CHANGES ON)
 set(CMAKE_DISABLE_IN_SOURCE_BUILD ON)
 
+# Create compilation database compile_commands.json
+set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
+
 # set directory where the custom finders live
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/Modules/")
 

src/ngraph/codegen/compiler.cpp

@@ -341,7 +341,7 @@ std::unique_ptr<llvm::Module> StaticCompiler::compile(const string& source)
 
 void StaticCompiler::generate_pch(const string& source)
 {
-    m_pch_path = file_util::path_join(file_util::get_temp_directory(), "ngraph.pch");
+    m_pch_path = file_util::tmp_filename();
     m_compiler->getFrontendOpts().OutputFile = m_pch_path;
 
     // Map code filename to a memoryBuffer

src/ngraph/runtime/cpu/emitter.cpp

@@ -479,14 +479,14 @@ void Emitter::EmitParameterizedConstantBool(const ngraph::Node* n,
         // Special case where constant is stored directly in the output
         for (size_t i = 0; i < value.size(); i++)
         {
-            TU << outputs[0].get_tensor().get_name() << "[" << i << "] = static_cast<bool>("
+            TU << outputs[0].get_tensor().get_name() << "[" << i << "] = static_cast<char>("
                << (value[i] ? "true" : "false") << ");\n";
         }
     }
     else
     {
         TU << "// this should be const but eigen hates const :(\n";
-        TU << "bool " << outputs[0].get_tensor().get_name() << "[] = {\n";
+        TU << "char " << outputs[0].get_tensor().get_name() << "[] = {\n";
         for (size_t i = 0; i < value.size(); i++)
         {
             if (i != 0)

test/backend_test.in.cpp

@@ -2708,3 +2708,30 @@ TEST(${BACKEND_NAME}, sign)
     (*cf)({a}, {result});
     ASSERT_EQ((vector<float>{1, -1, 0, -1, 1, 0}), result->get_vector<float>());
 }
+
+TEST(${BACKEND_NAME}, constant_equality_bool)
+{
+    auto shape = Shape{4};
+    // auto A = make_shared<op::Parameter>(element::Bool::element_type(), shape);
+    // auto B = make_shared<op::Parameter>(element::Bool::element_type(), shape);
+    // auto result_type = make_shared<TensorViewType>(element::Bool::element_type(), shape);
+    // auto f = make_shared<Function>(make_shared<op::Equal>(A, B), result_type, op::Parameters{A, B});
+
+    auto a = runtime::make_tensor<element::Bool>(shape, {true, false, true, false});
+    auto A = make_shared<op::ParameterizedConstant<element::Bool>>(shape, a);
+    auto b = runtime::make_tensor<element::Bool>(shape, {true, true, true, true});
+    auto B = make_shared<op::ParameterizedConstant<element::Bool>>(shape, b);
+    auto rt = make_shared<TensorViewType>(element::Bool::element_type(), shape);
+    auto f = make_shared<Function>(make_shared<op::Equal>(A, B), rt, op::Parameters{});
+
+    auto manager = runtime::Manager::get("${BACKEND_NAME}");
+    auto external = manager->compile(f);
+    auto backend = manager->allocate_backend();
+    auto cf = backend->make_call_frame(external);
+
+    // Create some tensors for input/output
+    auto result = backend->make_primary_tensor_view(element::Bool::element_type(), shape);
+
+    (*cf)({}, {result});
+    ASSERT_EQ((vector<char>{true, false, true, false}), result->get_vector<char>());
+}