- 21 Apr, 2016 1 commit
-
-
somdoron authored
-
- 19 Apr, 2016 2 commits
-
-
Luca Boccassi authored
Problem: Linker search path warnings on OS X
-
hitstergtd authored
Problem: A per-test Linker search path was added in commit a911fa41 to CMakeLists.txt as part of fixing Windows builds. Whilst this is silently ignored by ld(1) on Linux, it doesn't settle well with OS X. Spurious warnings are generated about missing directories leading to convoluted build logs. Solution: Make per-Test LINK_DIRECTORIES() conditional for non-Apple platforms.
-
- 18 Apr, 2016 8 commits
-
-
Constantin Rack authored
-
Luca Boccassi authored
Solution: try to resolve the TCP endpoint passed by the user in the zmq_unbind call before giving up, if it doesn't match. This fixes a breakage in the API, where after a call to zmq_bind(s, "tcp://127.0.0.1:9999") with IPv6 enabled on s would result in the call to zmq_unbind(s, "tcp://127.0.0.1:9999") failing. Add more test cases to increase coverage on all combinations of TCP endpoints.
-
Luca Boccassi authored
Solution: add one test run in a docket container environment, which is currently the only environment where it's possibile to bind a socket to ::1.
-
Luca Boccassi authored
Solution: add helper function is_ipv6_available to testutil.hpp to test if IPv6 is available on the building platform. This function will try to open and bind a socket to ::1:*, as it's the ultimate way of knowing if, at least on the loopback, IPv6 is enabled.
-
Luca Boccassi authored
Problem: comment not well formed in CMakeLists.txt
-
hitstergtd authored
Solution: fix comment
-
Luca Boccassi authored
Problem: test_udp does not release resources properly
-
hitstergtd authored
Solution: - call zmq_msg_close() if there is an error - call free() to release resources if there is an error (CWE-404)
-
- 15 Apr, 2016 4 commits
-
-
Constantin Rack authored
Problem: check_protocol() logic duplicated twice and needs cleanup
-
hitstergtd authored
Problem: Conditional logic in check_protocol() that checks if a protocol is supported, is duplicated twice. Moreover, the first set of checks to ascertain if a protocol is supported is done regardless of whether the particular protocol will be built into the library or not. Solution: * Simplify/collapse all supported protocol checks into one in check_protocol() * Enclose pgm/epgm/norm socket+protocol match checks with requisite macros
-
Joe Eli McIlvain authored
Problem: errno not set if UDP is NOT used with ZMQ_RADIO or ZMQ_DISH
-
hitstergtd authored
Solution: set errno to ENOCOMPATPROTO in check_protocol()
-
- 14 Apr, 2016 6 commits
-
-
Luca Boccassi authored
Problem: Running Linux-only tests results in 10% of tests failing on non-Linux systems (OSX, et. al.)
-
hitstergtd authored
Move tests specific to Linux under a platform conditional thereby eliminating unnecessary builds and fixing "make test" on Mac OS X and possibly other non-Linux systems. Tests specific to Linux: - abstract namespace support for AF_UNIX sockets - TIPC support (AF_TIPC) Test success rate jumps from 90% to 100% on Mac OS X after this change.
-
Constantin Rack authored
Fix typos similar to #1894
-
hitstergtd authored
-
Constantin Rack authored
Fix typo
-
hitstergtd authored
-
- 13 Apr, 2016 4 commits
-
-
Constantin Rack authored
-
Constantin Rack authored
-
Patrik Wenger authored
Solution: make the same change for the ZMQ_POLL_BASED_ON_SELECT case
-
Patrik Wenger authored
Solution: correct it to spaces
-
- 12 Apr, 2016 7 commits
-
-
Luca Boccassi authored
Solution: disable pedantic and Werror, as libsodium headers use pragma diagnostic which are not available in gcc 3.4.
-
Luca Boccassi authored
Solution: pass a struct addrinfo hint to getaddrinfo with a hint about the address family to avoid a failure.
-
Luca Boccassi authored
Solution: check for GCC version before using pragma diagnostic in src/tweetnacl.c to avoid an additional warning.
-
Luca Boccassi authored
Solution: add Wnosign-compare to CPPFLAGS. GCC version is too old on Solaris 10 to use pragma diagnostic (min 4.2 needed, but 3.4 is available)
-
Constantin Rack authored
Fix return value of zmq_poller_wait when used on empty poller
-
Patrik Wenger authored
Solution: return -1 (no event) instead of 0 (event) For some reason, this just returns 0 if there are no sockets registered on the poller. Usually this would mean there has been an event. So the caller would have to check the return value AND the event, or write code that takes the number of registered sockets into consideration. By returning -1 and setting errno = ETIMEDOUT like in the usual timeout cases, it's more consistent and convenient. Test case included.
-
Patrik Wenger authored
Solution: use zmq_assert to ensure it's not a nullpointer
-
- 10 Apr, 2016 3 commits
-
-
ipc://*Luca Boccassi authored
Solution: if options.use_fd do not create temporary random directory for ipc://*, since the socket is already created and passed to the library by the user.
-
Luca Boccassi authored
Solution: check for availability in autoconf and cmake, and if not available fall back to random file name rather than random directory.
-
Luca Boccassi authored
Solution: use the less nice but correct int constant 1000000000 instead of the shorter 1E9 to avoid a compiler warning when assigning to timespec.tv_nsec, which is a long int.
-
- 08 Apr, 2016 2 commits
-
-
Constantin Rack authored
-
Satyajit Padalkar authored
-
- 07 Apr, 2016 3 commits
-
-
Pieter Hintjens authored
Problem: zmq_bind IPv4 fallback still tries IPv6
-
Luca Boccassi authored
Solution: in the Windows-specific ifdef in tcp_listener set_address, check for error and set errno only after the IPv4 fallback has failed too, to avoid setting errno when the socket creation succeeds through the fallback.
-
Luca Boccassi authored
Solution: if opening an IPv6 TCP socket fails because IPv6 is not available, try to open an IPv4 socket instead when creating and connecting a TCP endpoint.
-